Thinktomorrow\Chief\Management\Nomadic

Complexity

Total Complexity

5

Size/Duplication

Total Lines	10
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	nomadicCan()	0	8	5

<?php

namespace Thinktomorrow\Chief\Management;

use Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute;

trait Nomadic
{
    public function nomadicCan($verb)
    {
        if (in_array($verb, ['create', 'store', 'delete']) && ! auth()->guard('chief')->user()->hasRole('developer')) {

The method hasRole() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            throw NotAllowedManagerRoute::notAllowedVerb($verb, $this);

$this of type Thinktomorrow\Chief\Management\Nomadic is incompatible with the type Thinktomorrow\Chief\Management\Manager expected by parameter $manager of Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute::notAllowedVerb().

        }

        if (in_array($verb, ['create', 'store']) && $this->indexCollection()->count() > 0) {

It seems like indexCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw NotAllowedManagerRoute::create($this);

$this of type Thinktomorrow\Chief\Management\Nomadic is incompatible with the type Thinktomorrow\Chief\Management\Manager expected by parameter $manager of Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute::create().

        }
    }
}