AbstractStateAssistant::guard() - Code Metrics - Inspection of "WIP states refactor" - thinktomorrow/chief - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — ft/states ( d4f7ca...0e1fde )

by Ben

created 2020-01-02 16:02 UTC

AbstractStateAssistant::guard() A

↳ Parent: AbstractStateAssistant

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
dl	0
loc	7
rs	10
c	1
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Thinktomorrow\Chief\States;

use Thinktomorrow\Chief\Management\Manager;
use Thinktomorrow\Chief\States\State\StatefulContract;
use Thinktomorrow\Chief\Management\Assistants\Assistant;
use Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute;

abstract class AbstractStateAssistant
{
    /** @var Manager */
    protected $manager;

    /** @var StatefulContract $model */
    protected $model;

    public function manager(Manager $manager)
    {
        $this->manager  = $manager;
        $this->model    = $manager->model();

        if(!$this->model instanceof StatefulContract){
            throw new \InvalidArgumentException(static::class . ' requires the model to implement the ' . StatefulContract::class);
        }
    }

    abstract public static function key(): string;

    abstract public function route($verb): ?string;

    public function can($verb): bool
    {
        return !is_null($this->route($verb));
    }

    public function guard($verb): Assistant
    {
        if (! $this->can($verb)) {
            NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
        }

        return $this;

    }
}


1			<?php
2
3			namespace Thinktomorrow\Chief\States;
4
5			use Thinktomorrow\Chief\Management\Manager;
6			use Thinktomorrow\Chief\States\State\StatefulContract;
7			use Thinktomorrow\Chief\Management\Assistants\Assistant;
8			use Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute;
9
10			abstract class AbstractStateAssistant
11			{
12			/** @var Manager */
13			protected $manager;
14
15			/** @var StatefulContract $model */
16			protected $model;
17
18			public function manager(Manager $manager)
19			{
20			$this->manager = $manager;
21			$this->model = $manager->model();
22
23			if(!$this->model instanceof StatefulContract){
24			throw new \InvalidArgumentException(static::class . ' requires the model to implement the ' . StatefulContract::class);
25			}
26			}
27
28			abstract public static function key(): string;
29
30			abstract public function route($verb): ?string;
31
32			public function can($verb): bool
33			{
34			return !is_null($this->route($verb));
35			}
36
37			public function guard($verb): Assistant
38			{
39			if (! $this->can($verb)) {
40			NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
41			}
42
43			return $this;
			0 ignored issues – show Bug Best Practice introduced 2020-01-02 16:11 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `Thinktomorrow\Chief\States\AbstractStateAssistant` which is incompatible with the type-hinted return `Thinktomorrow\Chief\Mana...nt\Assistants\Assistant`. Loading history...
44			}
45			}
46

thinktomorrow / chief

Push — ft/states ( d4f7ca...0e1fde )

AbstractStateAssistant::guard() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like