Thinktomorrow\Chief\Mediagallery\Http\BulkActionsController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	download()	0	6	1
A	__construct()	0	4	1
A	bulk()	0	8	3
A	remove()	0	9	2

<?php

namespace Thinktomorrow\Chief\Mediagallery\Http;

use Illuminate\Support\Str;
use Illuminate\Http\Request;
use Thinktomorrow\Chief\MediaGallery\Application\ZipAction;
use Thinktomorrow\Chief\MediaGallery\Application\RemovalAction;
    use Thinktomorrow\Chief\App\Http\Controllers\Controller;

class BulkActionsController extends Controller
{
    /** @var ZipAction */
    private $zipAction;

    /** @var RemovalAction */
    private $removalAction;

    public function __construct(ZipAction $zipAction, RemovalAction $removalAction)
    {
        $this->zipAction = $zipAction;
        $this->removalAction = $removalAction;
    }

    public function bulk(Request $request)
    {
        if($request->input('type') == 'download') {
            return $this->download($request);

Are you sure the usage of $this->download($request) targeting Thinktomorrow\Chief\Mediagallery\Http\BulkActionsController::download() seems to always return null.

        }

        if($request->input('type') == 'remove') {
            return $this->remove($request);
        }
    }

    private function download(Request $request)
    {
        $filename = Str::slug(config('app.name')) . '_assets_' . date('YmdHis') . '.zip';

        // TODO: do the response here instead of the zip action itself
        return $this->zipAction->handle($filename, $request);

Are you sure the usage of $this->zipAction->handle($filename, $request) targeting Thinktomorrow\Chief\MediaGallery\Application\ZipAction::handle() seems to always return null.

    }

    private function remove(Request $request)
    {
        $result = $this->removalAction->handle($request);

        if($result) {
            return redirect()->back()->with('messages.success', 'De mediabestanden zijn verwijderd');
        }

        return redirect()->back()->with('messages.error', 'Er ging iets mis, er zijn geen bestanden verwijderd. Mogelijks probeerde je een bestand te verwijderen dat nog gebruikt wordt.');
    }
}