Thinktomorrow\Chief\Settings\SettingFieldsManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	fields()	0	20	1
A	fieldValue()	0	3	1
A	saveFields()	0	24	5

<?php

namespace Thinktomorrow\Chief\Settings;

use Illuminate\Http\Request;
use Thinktomorrow\Chief\Fields\Fields;
use Thinktomorrow\Chief\Fields\FieldManager;
use Thinktomorrow\Chief\Fields\RenderingFields;
use Thinktomorrow\Chief\Fields\Types\Field;
use Thinktomorrow\Chief\Fields\Types\InputField;
use Thinktomorrow\Chief\Fields\Types\SelectField;
use Thinktomorrow\Chief\Settings\Application\ChangeHomepage;
use Thinktomorrow\Chief\Urls\UrlHelper;
use Thinktomorrow\Chief\Urls\UrlRecord;

class SettingFieldsManager extends Fields implements FieldManager
{
    use RenderingFields;

The trait Thinktomorrow\Chief\Fields\RenderingFields requires the property $model which is not provided by Thinktomorrow\Chief\Settings\SettingFieldsManager.

    /** @var Settings */
    private $settings;

    public function __construct(Settings $settings)
    {
        $this->settings = $settings;
    }

    public function fields(): Fields
    {
        return new Fields([
            SelectField::make('homepage')
                ->name('homepage[:locale]')
                ->options(UrlHelper::allOnlineSingles())
                ->translatable(config('translatable.locales'))
                ->grouped()
                ->label('Homepagina')

The method label() does not exist on Thinktomorrow\Chief\Fields\Types\SelectField. Since you implemented __call, consider adding a @method annotation.

                ->description('Geef hier de homepagina voor de site op.'),

The method description() does not exist on Thinktomorrow\Chief\Fields\Types\SelectField. Since you implemented __call, consider adding a @method annotation.

            InputField::make('app_name')
                ->label('Site naam')

The method label() does not exist on Thinktomorrow\Chief\Fields\Types\InputField. Since you implemented __call, consider adding a @method annotation.

                ->description('Naam van de applicatie. Dit wordt getoond in o.a. de mail communicatie.'),

The method description() does not exist on Thinktomorrow\Chief\Fields\Types\InputField. Since you implemented __call, consider adding a @method annotation.

            InputField::make('contact_email')
                ->validation('email')
                ->label('Webmaster email')
                ->description('Het emailadres van de webmaster. Hierop ontvang je standaard alle contactnames.'),
            InputField::make('contact_name')
                ->label('Webmaster naam')
                ->description('Voor en achternaam van de webmaster.'),
        ]);
    }

    public function fieldValue(Field $field, $locale = null)
    {
        return $this->settings->get($field->key(), $locale);

The method key() does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __call, consider adding a @method annotation.

    }

    public function saveFields(Request $request)
    {
        $existingHomepageValue = [];

        foreach ($this->fields() as $key => $field) {
            if (!$setting = Setting::where('key', $key)->first()) {
                Setting::create([
                    'key' => $key,
                    'value' => $request->get($key, ''),
                ]);

                continue;
            }

            if ($key === Setting::HOMEPAGE) {
                $existingHomepageValue = $setting->value;
            }

            $setting->update(['value' => $request->get($key, '')]);
        }

        // A changed homepage needs to be reflected in the urls as well in order to respond to incoming requests.
        if ($request->filled(Setting::HOMEPAGE)) {
            app(ChangeHomepage::class)->onSettingChanged($existingHomepageValue);

It seems like $existingHomepageValue can also be of type string; however, parameter $existingValues of Thinktomorrow\Chief\Settings\Application\ChangeHomepage::onSettingChanged() does only seem to accept array, maybe add an additional type check?

        }
    }
}