Thinktomorrow\Chief\States\Publishable\Publishable

Complexity

Total Complexity

9

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	scopeDrafted()	0	3	1
A	isDraft()	0	3	1
A	getAllPublished()	0	3	1
A	isPublished()	0	3	1
A	draft()	0	4	1
A	scopeSortedByPublished()	0	3	1
A	publish()	0	4	1
A	scopePublished()	0	8	2

<?php

namespace Thinktomorrow\Chief\States\Publishable;

trait Publishable
{
    public function isPublished()
    {
        return (!!$this->published);
    }

    public function isDraft()
    {
        return (!$this->published);
    }

    public function scopePublished($query)
    {
        // Here we widen up the results in case of preview mode and ignore the published scope
        if (PreviewMode::fromRequest()->check()) {
            return;
        }

        $query->where('published', 1);
    }

    public function scopeDrafted($query)
    {
        $query->where('published', 0);
    }

    public function publish()
    {
        $this->published = 1;

The property published does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function draft()
    {
        $this->published = 0;

The property published does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->save();
    }

    public static function getAllPublished()
    {
        return self::published()->get();

The method published() does not exist on Thinktomorrow\Chief\States\Publishable\Publishable. Did you maybe mean publish()?

    }

    public function scopeSortedByPublished($query)
    {
        return $query->orderBy('published', 'DESC');
    }
}