Thinktomorrow\Chief\Settings\Homepage

Complexity

Total Complexity

6

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Test Coverage

Coverage

88.89%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	is()	0	9	4
A	url()	0	7	2

<?php

namespace Thinktomorrow\Chief\Settings;

use Thinktomorrow\Chief\Settings\Setting;
use Thinktomorrow\Chief\FlatReferences\FlatReferenceFactory;
use Thinktomorrow\Chief\FlatReferences\ProvidesFlatReference;

class Homepage
{
    public static function is($model, string $locale = null): bool
    {
        $homepageValue = chiefSetting(Setting::HOMEPAGE, $locale);

        if(!$homepageValue || !is_object($model) || !$model instanceof ProvidesFlatReference) {
            return false;
        }

        return $model->flatReference()->is($homepageValue);
    }

    public static function url($locale = null): string
    {
        if($id = chiefSetting(Setting::HOMEPAGE, $locale))
        {
            return FlatReferenceFactory::fromString($id)->instance()->url($locale);

The expression return Thinktomorrow\Chief\FlatReferences\FlatReferenceFactory::fromString($id)->instance()->url($locale) could return the type Illuminate\Database\Eloquent\Builder which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

        }
        return '';
    }
}