Thinktomorrow\Chief\Concerns\HasPeriod\HasPeriodTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

57.14%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	bootHasPeriodTrait()	0	3	1
A	initializeHasPeriodTrait()	0	3	1
A	scopePassed()	0	3	1
A	scopeUpcoming()	0	3	1
A	saveStartAtField()	0	6	1
A	scopeOngoing()	0	3	1
A	saveEndAtField()	0	5	2

<?php

namespace Thinktomorrow\Chief\Concerns\HasPeriod;

use Illuminate\Support\Carbon;

trait HasPeriodTrait
{
    protected static function bootHasPeriodTrait()
    {
        static::addGlobalScope(new SortPeriodDateScope);
    }

    public function initializeHasPeriodTrait()
    {
        $this->dates = array_merge($this->dates, ['start_at', 'end_at']);

The property dates does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function scopePassed($query)
    {
        return $query->where('end_at', '<', Carbon::now());
    }

    public function scopeUpcoming($query)
    {
        return $query->where('start_at', '>', Carbon::now());
    }

    public function scopeOngoing($query)
    {
        return $query->where('start_at', '<', Carbon::now())->where('end_at', '>', Carbon::now());
    }

    public function saveStartAtField($start_at)
    {
        $this->start_at = Carbon::parse($start_at)->startOfDay();

The property start_at does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->end_at   = $this->start_at->endOfDay();

The property end_at does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function saveEndAtField($end_at)
    {
        if ($end_at) {
            $this->end_at = Carbon::parse($end_at)->endOfDay();

The property end_at does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->save();
        }
    }
}