Passed
Pull Request — master (#313)
by Philippe
48:08 queued 10:51
created
src/Fields/Types/FieldType.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -6,19 +6,19 @@  discard block
 block discarded – undo
6 6
 
7 7
 class FieldType
8 8
 {
9
-    const INPUT = 'input';   // oneliner text (input)
10
-    const TEXT = 'text';    // Plain text (textarea)
9
+    const INPUT = 'input'; // oneliner text (input)
10
+    const TEXT = 'text'; // Plain text (textarea)
11 11
     const NUMBER = 'number'; // number
12 12
     const RANGE = 'range'; // range slider
13
-    const DATE = 'date';    // Timestamp input
14
-    const PHONENUMBER = 'phonenumber';    // Timestamp input
15
-    const HTML = 'html';    // Html text (wysiwyg)
16
-    const SELECT = 'select';  // Select options
17
-    const MEDIA = 'media';  // media file (slim uploader)
18
-    const DOCUMENT = 'document';  // documents
19
-    const RADIO = 'radio';  // radio select
20
-    const CHECKBOX = 'checkbox';  // checkbox select
21
-    const PAGEBUILDER = 'pagebuilder';  // the most special field there is...
13
+    const DATE = 'date'; // Timestamp input
14
+    const PHONENUMBER = 'phonenumber'; // Timestamp input
15
+    const HTML = 'html'; // Html text (wysiwyg)
16
+    const SELECT = 'select'; // Select options
17
+    const MEDIA = 'media'; // media file (slim uploader)
18
+    const DOCUMENT = 'document'; // documents
19
+    const RADIO = 'radio'; // radio select
20
+    const CHECKBOX = 'checkbox'; // checkbox select
21
+    const PAGEBUILDER = 'pagebuilder'; // the most special field there is...
22 22
 
23 23
     /** @var string */
24 24
     private $type;
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
     public static function fromString(string $type): self
39 39
     {
40
-        $class = 'Thinktomorrow\Chief\Fields\Types\\' . ucfirst($type . 'Field');
40
+        $class = 'Thinktomorrow\Chief\Fields\Types\\'.ucfirst($type.'Field');
41 41
 
42 42
         return new $class(new static($type));
43 43
     }
Please login to merge, or discard this patch.
src/Fields/Types/CheckboxField.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace Thinktomorrow\Chief\Fields\Types;
5 5
 
Please login to merge, or discard this patch.
src/Modules/Module.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return static::$managedModelKey;
68 68
         }
69 69
 
70
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
70
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
71 71
     }
72 72
 
73 73
     /**
@@ -76,9 +76,9 @@  discard block
 block discarded – undo
76 76
      */
77 77
     public static function availableForCreation(): Collection
78 78
     {
79
-        $managers = app(Managers::class)->findByTag('module')->filter(function ($manager) {
79
+        $managers = app(Managers::class)->findByTag('module')->filter(function($manager) {
80 80
             return $manager->can('create');
81
-        })->map(function ($manager) {
81
+        })->map(function($manager) {
82 82
             return $manager->details();
83 83
         });
84 84
 
Please login to merge, or discard this patch.
src/Management/Nomadic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 {
9 9
     public function nomadicCan($verb)
10 10
     {
11
-        if (in_array($verb, ['create', 'store', 'delete']) && ! auth()->guard('chief')->user()->hasRole('developer')) {
11
+        if (in_array($verb, ['create', 'store', 'delete']) && !auth()->guard('chief')->user()->hasRole('developer')) {
12 12
             throw NotAllowedManagerRoute::notAllowedVerb($verb, $this);
13 13
         }
14 14
 
Please login to merge, or discard this patch.
src/Management/Managers.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $registrations = collect($this->register->filterByTag($tag)->all());
52 52
 
53
-        return $registrations->map(function ($registration) {
53
+        return $registrations->map(function($registration) {
54 54
             return $this->instance($registration);
55 55
         });
56 56
     }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     {
66 66
         $registrations = collect($this->register->filterByTag($tag)->all());
67 67
 
68
-        return $registrations->map(function ($registration) {
68
+        return $registrations->map(function($registration) {
69 69
             return $this->instance($registration)->details();
70 70
         });
71 71
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         //return array with group name and values
77 77
         $grouped = [];
78 78
 
79
-        $managers = $managers->map(function (Manager $item) {
79
+        $managers = $managers->map(function(Manager $item) {
80 80
             return [
81 81
                 'id'    => $item->details()->id,
82 82
                 'group' => $item->details()->plural,
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
     {
91 91
         $registrations = collect($this->register->all());
92 92
 
93
-        return $registrations->map(function ($registration) {
93
+        return $registrations->map(function($registration) {
94 94
             return $this->instance($registration);
95 95
         });
96 96
     }
97 97
 
98 98
     public function anyRegisteredByTag($tag)
99 99
     {
100
-        return ! empty($this->register->filterByTag($tag)->all());
100
+        return !empty($this->register->filterByTag($tag)->all());
101 101
     }
102 102
 
103 103
     /**
Please login to merge, or discard this patch.
src/Management/AbstractManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
     protected $pageCount = 20;
39 39
     protected $paginated = true;
40
-    protected static $booted    = [];
40
+    protected static $booted = [];
41 41
 
42 42
     public function __construct(Registration $registration)
43 43
     {
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return $this->indexPagination($builder);
85 85
         }
86 86
         
87
-        return $builder->get()->map(function ($model) {
87
+        return $builder->get()->map(function($model) {
88 88
             return (new static($this->registration))->manage($model);
89 89
         });
90 90
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $paginator = $builder->paginate($this->pageCount);
114 114
 
115
-        $modifiedCollection = $builder->paginate($this->pageCount)->getCollection()->transform(function ($model) {
115
+        $modifiedCollection = $builder->paginate($this->pageCount)->getCollection()->transform(function($model) {
116 116
             return (new static($this->registration))->manage($model);
117 117
         });
118 118
 
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 
187 187
     public function guard($verb): Manager
188 188
     {
189
-        if (! $this->can($verb)) {
189
+        if (!$this->can($verb)) {
190 190
             NotAllowedManagerRoute::notAllowedVerb($verb, $this);
191 191
         }
192 192
 
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
         $fields = $this->fields();
210 210
 
211 211
         foreach ($this->assistants() as $assistant) {
212
-            if (! method_exists($assistant, 'fields')) {
212
+            if (!method_exists($assistant, 'fields')) {
213 213
                 continue;
214 214
             }
215 215
 
@@ -291,9 +291,9 @@  discard block
 block discarded – undo
291 291
             static::$booted[$baseMethod] = [];
292 292
         
293 293
             foreach (class_uses_recursive($class) as $trait) {
294
-                $method = class_basename($trait) . ucfirst($baseMethod);
294
+                $method = class_basename($trait).ucfirst($baseMethod);
295 295
                 
296
-                if (method_exists($class, $method) && ! in_array($method, static::$booted[$baseMethod])) {
296
+                if (method_exists($class, $method) && !in_array($method, static::$booted[$baseMethod])) {
297 297
                     static::$booted[$baseMethod][] = lcfirst($method);
298 298
                 }
299 299
             }
Please login to merge, or discard this patch.
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     private function saveRecord(string $locale, ?string $slug)
58 58
     {
59 59
         // Existing ones for this locale?
60
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
60
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
61 61
             return (
62 62
                 $record->locale == $locale &&
63 63
                 !$record->isRedirect()
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         // If slug entry is left empty, all existing records will be deleted
68 68
         if (!$slug) {
69
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
69
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
70 70
                 $existingRecord->delete();
71 71
             });
72 72
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         // Only replace the existing records that differ from the current passed slugs
85
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
85
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
86 86
             if ($existingRecord->slug != $slug) {
87 87
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
88 88
             }
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
129 129
     {
130
-        $existingRecords->filter(function ($record) use ($locale) {
130
+        $existingRecords->filter(function($record) use ($locale) {
131 131
             return (
132 132
                 $record->locale == $locale &&
133 133
                 $record->isRedirect()
134 134
             );
135
-        })->each(function ($existingRecord) use ($slug) {
135
+        })->each(function($existingRecord) use ($slug) {
136 136
             if ($existingRecord->slug == $slug) {
137 137
                 $existingRecord->delete();
138 138
             }
@@ -147,11 +147,11 @@  discard block
 block discarded – undo
147 147
 
148 148
         // The old homepage url should be removed since this is no longer in effect.
149 149
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
150
-        $existingRecords->reject(function ($existingRecord) {
150
+        $existingRecords->reject(function($existingRecord) {
151 151
             return (
152 152
                 $existingRecord->model_type == $this->model->getMorphClass() &&
153 153
                 $existingRecord->model_id == $this->model->id);
154
-        })->each(function ($existingRecord) {
154
+        })->each(function($existingRecord) {
155 155
 
156 156
             // TODO: if there is a redirect to this page, we'll take this one as the new url
157 157
             $existingRecord->delete();
Please login to merge, or discard this patch.
src/Urls/ProvidesUrl/BaseUrlSegment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
      */
15 15
     public static function prepend(ProvidesUrl $model, string $slug, $locale): string
16 16
     {
17
-        $slugWithBaseSegment = $model->baseUrlSegment($locale) . '/' . $slug;
17
+        $slugWithBaseSegment = $model->baseUrlSegment($locale).'/'.$slug;
18 18
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
19 19
 
20 20
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.
src/Management/Assistants/UrlAssistant.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
 
26 26
     public function manager(Manager $manager)
27 27
     {
28
-        $this->manager  = $manager;
28
+        $this->manager = $manager;
29 29
 
30
-        if (! $manager->model() instanceof ProvidesUrl) {
31
-            throw new \Exception('UrlAssistant requires the model interfaced by ' . ProvidesUrl::class . '.');
30
+        if (!$manager->model() instanceof ProvidesUrl) {
31
+            throw new \Exception('UrlAssistant requires the model interfaced by '.ProvidesUrl::class.'.');
32 32
         }
33 33
 
34 34
         $this->model = $manager->model();
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
                         'url-slugs.*' => 'taalspecifieke link',
64 64
                     ])
65 65
                 ->view('chief::back._fields.url-slugs')
66
-                ->viewData(['fields' => UrlSlugFields::fromModel($this->model) ]),
66
+                ->viewData(['fields' => UrlSlugFields::fromModel($this->model)]),
67 67
         ]);
68 68
     }
69 69
 
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 
74 74
         // Push update to homepage setting value
75 75
         // TODO: we should just fetch the homepages and push that instead...
76
-        UrlRecord::getByModel($this->model)->reject(function ($record) {
76
+        UrlRecord::getByModel($this->model)->reject(function($record) {
77 77
             return ($record->isRedirect() || !$record->isHomepage());
78
-        })->each(function ($record) {
78
+        })->each(function($record) {
79 79
             app(ChangeHomepage::class)->onUrlChanged($record);
80 80
         });
81 81
     }
Please login to merge, or discard this patch.