Thinktomorrow\Chief\Settings\Settings

Complexity

Total Complexity

12

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	configValues()	0	3	1
A	set()	0	3	1
A	fetch()	0	13	3
A	get()	0	21	6
A	fresh()	0	5	1

<?php

namespace Thinktomorrow\Chief\Settings;

use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Schema;

class Settings extends Collection
{
    public static function configValues(): array
    {
        return config('thinktomorrow.chief-settings');
    }

    public function get($key, $locale = null, $default = null)
    {
        $this->fetch();

        if (!isset($this->items[$key])) {
            return $default;
        }

        if (is_array($this->items[$key])) {
            if (!$locale) {
                $locale = app()->getLocale();

The method getLocale() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

            }

            if ($this->items[$key] == null || !isset($this->items[$key][$locale])) {
                return $default;
            }

            return $this->items[$key][$locale] ?? $default;
        }

        return $this->items[$key];
    }

    public function set($key, $value)
    {
        $this->items[$key] = $value;
    }

    private function fetch()
    {
        if ($this->items) {

The expression $this->items of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $config_values = static::configValues();

        $database_values = Schema::hasTable((new Setting)->getTable())
            ? Setting::all()->pluck('value', 'key')->toArray()
            : [];

        $this->items = array_merge($config_values, $database_values);
    }

    public function fresh()
    {
        $this->items = null;

        return $this;
    }
}