Thinktomorrow\Chief\Fields\Validators\FieldValidatorFactory

Complexity

Total Complexity

13

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Test Coverage

Coverage

85.19%

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	composeValidatorFromRules()	0	10	3
A	__construct()	0	3	1
A	create()	0	16	4
A	normalizeRules()	0	14	5

<?php

namespace Thinktomorrow\Chief\Fields\Validators;

use Illuminate\Contracts\Validation\Validator;
use Illuminate\Contracts\Validation\Factory;
use Thinktomorrow\Chief\Fields\LocalizedFieldValidationRules;
use Thinktomorrow\Chief\Fields\Types\Field;

class FieldValidatorFactory
{
    /** @var Factory */
    private $validatorFactory;

    public function __construct(Factory $validatorFactory)
    {
        $this->validatorFactory = $validatorFactory;
    }

    public function create(Field $field, array $data): Validator
    {
        if (!$field->hasValidation()) {
            return new NullValidator();
        }

        if ($field->validation instanceof Validator) {

The property validation does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __get, consider adding a @property annotation.

            return $field->validation;
        }

        if ($field->validation instanceof \Closure) {
            $closure = $field->validation;
            return $closure($this->validatorFactory, $data);
        }

        return $this->composeValidatorFromRules($field, $data);
    }

    private function composeValidatorFromRules(Field $field, array $data): Validator
    {
        if (!is_array($field->validation) || !isset($field->validation[0])) {

The property validation does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __get, consider adding a @property annotation.

            throw new \Exception('Invalid validation given. Rules should be passed as non-associative array.');
        }

        return $this->validatorFactory->make($data,
            $this->normalizeRules($field, $field->validation[0], $data),

It seems like $this->normalizeRules($field, $field->validation[0], $data) can also be of type null; however, parameter $rules of Illuminate\Validation\Factory::make() does only seem to accept array, maybe add an additional type check?

            $field->validation[1] ?? [], // messages
            $field->validation[2] ?? [] // custom attributes
        );
    }

    /**
     * @param Field $field
     * @param string|array $rules
     * @param array $data
     * @return array|null
     */
    private function normalizeRules(Field $field, $rules, array $data)
    {
        // Normalize rules: If no attribute is passed for the rule, we use the field name.
        if (!is_array($rules) || isset($rules[0])) {
            $rules = [$field->name => (is_array($rules) ? reset($rules) : $rules)];

The property name does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __get, consider adding a @property annotation.

            if ($field->isTranslatable()) {
                $rules = (new LocalizedFieldValidationRules($field->locales))

The property locales does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __get, consider adding a @property annotation.

It seems like $field->locales can also be of type null; however, parameter $locales of Thinktomorrow\Chief\Fields\LocalizedFieldValidationRules::__construct() does only seem to accept array, maybe add an additional type check?

                    ->influenceByPayload($data)
                    ->rules($rules);
            }
        }

        return $rules;
    }
}