Completed
Pull Request — master (#195)
by Ben
69:52 queued 31:43
created
src/Snippets/FileLoader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\Snippets;
6 6
 
Please login to merge, or discard this patch.
src/Snippets/SnippetParser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
             return $value;
13 13
         }
14 14
 
15
-        $value = preg_replace_callback(static::$pattern, function ($matches) {
15
+        $value = preg_replace_callback(static::$pattern, function($matches) {
16 16
 
17 17
             // First entry of matches contains our full captured group, which we want to replace.
18 18
             // Second entry is the text itself, without the brackets
Please login to merge, or discard this patch.
src/Filters/Filter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\Filters;
6 6
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
     public function render(array $requestInput = []): string
52 52
     {
53
-        $path = $this->viewpath ?? 'chief::back._filters.' . $this->type;
53
+        $path = $this->viewpath ?? 'chief::back._filters.'.$this->type;
54 54
         $this->default($requestInput[$this->name] ?? null);
55 55
 
56 56
         return view($path, ['filter' => $this])->render();
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         if (!in_array($name, ['name', 'label', 'description', 'query', 'viewpath', 'default'])) {
67
-            throw new \InvalidArgumentException('Cannot set value by ['. $name .'].');
67
+            throw new \InvalidArgumentException('Cannot set value by ['.$name.'].');
68 68
         }
69 69
 
70 70
         $this->values[$name] = $arguments[0];
Please login to merge, or discard this patch.
src/Filters/Types/SelectFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
     public function apply($value = null): Closure
17 17
     {
18
-        return $this->query && $this->query instanceof Closure ? $this->query : function ($query) {
18
+        return $this->query && $this->query instanceof Closure ? $this->query : function($query) {
19 19
             return $query;
20 20
         };
21 21
     }
Please login to merge, or discard this patch.
src/Filters/Types/FilterType.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,8 +6,8 @@  discard block
 block discarded – undo
6 6
 
7 7
 class FilterType
8 8
 {
9
-    const INPUT = 'input';   // oneliner text (input)
10
-    const SELECT = 'select';  // Select options
9
+    const INPUT = 'input'; // oneliner text (input)
10
+    const SELECT = 'select'; // Select options
11 11
 
12 12
     /**
13 13
      * @var string
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
             static::INPUT,
21 21
             static::SELECT,
22 22
         ])) {
23
-            throw new \Exception('Invalid type identifier given [' . $type . '].');
23
+            throw new \Exception('Invalid type identifier given ['.$type.'].');
24 24
         }
25 25
 
26 26
         $this->type = $type;
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
     public static function fromString(string $type)
30 30
     {
31
-        $class = 'Thinktomorrow\Chief\Filters\Types\\' . ucfirst($type . 'Filter');
31
+        $class = 'Thinktomorrow\Chief\Filters\Types\\'.ucfirst($type.'Filter');
32 32
 
33 33
         return new $class(new static($type));
34 34
     }
Please login to merge, or discard this patch.
src/Management/Assistants/PublishAssistant.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 
72 72
     public function findAll(): Collection
73 73
     {
74
-        return $this->model->published()->get()->map(function ($model) {
74
+        return $this->model->published()->get()->map(function($model) {
75 75
             return $this->managers->findByModel($model);
76 76
         });
77 77
     }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
     public function guard($verb): Assistant
95 95
     {
96
-        if (! $this->can($verb)) {
96
+        if (!$this->can($verb)) {
97 97
             NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
98 98
         }
99 99
 
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 
103 103
     public function previewUrl(): string
104 104
     {
105
-        if (! $this->model instanceof ProvidesUrl) {
106
-            throw new \Exception('Managed model ' . get_class($this->model) . ' should implement ' . ProvidesUrl::class);
105
+        if (!$this->model instanceof ProvidesUrl) {
106
+            throw new \Exception('Managed model '.get_class($this->model).' should implement '.ProvidesUrl::class);
107 107
         }
108 108
 
109 109
         return $this->model->previewUrl();
Please login to merge, or discard this patch.
src/Management/Assistants/ArchiveAssistant.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     public function findAll(): Collection
71 71
     {
72
-        return $this->model->archived()->get()->map(function ($model) {
72
+        return $this->model->archived()->get()->map(function($model) {
73 73
             return $this->managers->findByModel($model);
74 74
         });
75 75
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
     public function guard($verb): Assistant
101 101
     {
102
-        if (! $this->can($verb)) {
102
+        if (!$this->can($verb)) {
103 103
             NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
104 104
         }
105 105
 
Please login to merge, or discard this patch.
src/Management/Exceptions/NotAllowedManagerRoute.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@
 block discarded – undo
39 39
 
40 40
     public static function notAllowedVerb($verb, Manager $manager)
41 41
     {
42
-        throw new static('Not allowed to '.$verb.' a model. '.ucfirst($verb).' route is not allowed by the ' . $manager->details()->key.' manager.');
42
+        throw new static('Not allowed to '.$verb.' a model. '.ucfirst($verb).' route is not allowed by the '.$manager->details()->key.' manager.');
43 43
     }
44 44
 
45 45
     public static function notAllowedPermission($permission, Manager $manager)
46 46
     {
47
-        throw new static('Not allowed permission for '.$permission.' on a model as managed by the ' . $manager->details()->key.' manager.');
47
+        throw new static('Not allowed permission for '.$permission.' on a model as managed by the '.$manager->details()->key.' manager.');
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
src/Management/Details/Details.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 
65 65
     public function __toString()
66 66
     {
67
-        return (string) $this->get('key');
67
+        return (string)$this->get('key');
68 68
     }
69 69
 
70 70
     /**
Please login to merge, or discard this patch.