Test Failed
Push — ft/fields-refactor ( b1c0b9...6b3c14 )
by Ben
35:23
created
src/Management/Details/Sections.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 
65 65
     public function __toString()
66 66
     {
67
-        return (string) $this->get('key');
67
+        return (string)$this->get('key');
68 68
     }
69 69
 
70 70
     /**
Please login to merge, or discard this patch.
src/PageBuilder/PresentSections.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
             $this->addModelToCollection($i, $child);
79 79
         }
80 80
 
81
-        return $this->sets->values()->map(function (ViewableContract $child) {
81
+        return $this->sets->values()->map(function(ViewableContract $child) {
82 82
             return ($this->withSnippets && method_exists($child, 'withSnippets'))
83 83
                 ? $child->withSnippets()->setViewParent($this->parent)->renderView()
84 84
                 : $child->setViewParent($this->parent)->renderView();
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     {
96 96
         // Only published pages you fool!
97 97
         // TODO: check for assistant instead of method existence
98
-        if (method_exists($model, 'isPublished') && ! $model->isPublished()) {
98
+        if (method_exists($model, 'isPublished') && !$model->isPublished()) {
99 99
             return;
100 100
         }
101 101
 
Please login to merge, or discard this patch.
src/Pages/PageManager.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -87,11 +87,11 @@
 block discarded – undo
87 87
         return parent::fields()->add(
88 88
             $this->pageBuilderField(),
89 89
             InputField::make('title')->translatable($this->model->availableLocales())
90
-                                     ->validation('required-fallback-locale|max:200', [], [
91
-                                         'trans.'.config('app.fallback_locale', 'nl').'.title' => 'title',
92
-                                     ])
93
-                                     ->label('De titel van je '.$this->model->labelSingular ?? 'pagina')
94
-                                     ->description('Dit is de titel die zal worden getoond in de overzichten en modules.'),
90
+                                        ->validation('required-fallback-locale|max:200', [], [
91
+                                            'trans.'.config('app.fallback_locale', 'nl').'.title' => 'title',
92
+                                        ])
93
+                                        ->label('De titel van je '.$this->model->labelSingular ?? 'pagina')
94
+                                        ->description('Dit is de titel die zal worden getoond in de overzichten en modules.'),
95 95
             InputField::make('seo_title')
96 96
                 ->translatable($this->model->availableLocales())
97 97
                 ->label('Zoekmachine titel'),
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -61,15 +61,15 @@  discard block
 block discarded – undo
61 61
     {
62 62
         $permission = 'update-page';
63 63
 
64
-        if (in_array($verb, ['index','show'])) {
64
+        if (in_array($verb, ['index', 'show'])) {
65 65
             $permission = 'view-page';
66
-        } elseif (in_array($verb, ['create','store'])) {
66
+        } elseif (in_array($verb, ['create', 'store'])) {
67 67
             $permission = 'create-page';
68 68
         } elseif (in_array($verb, ['delete'])) {
69 69
             $permission = 'delete-page';
70 70
         }
71 71
 
72
-        if (! auth()->guard('chief')->user()->hasPermissionTo($permission)) {
72
+        if (!auth()->guard('chief')->user()->hasPermissionTo($permission)) {
73 73
             throw NotAllowedManagerRoute::notAllowedPermission($permission, $this);
74 74
         }
75 75
     }
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
     public function fieldArrangement($key = null): FieldArrangement
131 131
     {
132 132
         if ($key == 'create') {
133
-            return new FieldArrangement($this->fieldsWithAssistantFields()->filterBy(function ($field) {
133
+            return new FieldArrangement($this->fieldsWithAssistantFields()->filterBy(function($field) {
134 134
                 return in_array($field->key, ['title']);
135 135
             }));
136 136
         }
@@ -152,8 +152,8 @@  discard block
 block discarded – undo
152 152
         if ($this->model->id) {
153 153
             return parent::details()
154 154
                 ->set('title', $this->model->title)
155
-                ->set('intro', 'Aangepast ' . $this->model->updated_at->format('d/m/Y H:i'))
156
-                ->set('context', '<span class="inline-s">' . $this->assistant('publish')->publicationStatusAsLabel() . '</span>');
155
+                ->set('intro', 'Aangepast '.$this->model->updated_at->format('d/m/Y H:i'))
156
+                ->set('context', '<span class="inline-s">'.$this->assistant('publish')->publicationStatusAsLabel().'</span>');
157 157
         }
158 158
 
159 159
         return parent::details();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     public function saveFields(Request $request)
163 163
     {
164 164
         // Store the morph_key upon creation
165
-        if (! $this->model->morph_key) {
165
+        if (!$this->model->morph_key) {
166 166
             $this->model->morph_key = $this->model->morphKey();
167 167
         }
168 168
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
             if (is_array_empty($translation)) {
208 208
 
209 209
                 // Nullify all values
210
-                $trans[$locale] = array_map(function ($value) {
210
+                $trans[$locale] = array_map(function($value) {
211 211
                     return null;
212 212
                 }, $translation);
213 213
                 continue;
Please login to merge, or discard this patch.
src/Sets/Set.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
         // If no view has been created for this page collection, we try once again to fetch the content value if any. This will silently fail
48 48
         // if no content value is present. We don't consider the 'content' attribute to be a default as we do for module.
49
-        return $this->map(function ($item) {
49
+        return $this->map(function($item) {
50 50
             return ($this->viewParent && $item instanceof ViewableContract)
51 51
                 ? $item->setViewParent($this->viewParent)->renderView()
52 52
                 : ($item->content ?? '');
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     {
80 80
         $currentPage = $currentPage ?? request()->get('page', 1);
81 81
         $path = request()->path();
82
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage);
82
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage);
83 83
 
84 84
         return (new \Illuminate\Pagination\Paginator($items, $perPage, $currentPage))->setPath($path);
85 85
     }
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     {
97 97
         $currentPage = $currentPage ?? request()->get('page', 1);
98 98
         $path = request()->path();
99
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage, $perPage);
99
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage, $perPage);
100 100
 
101 101
         return (new \Illuminate\Pagination\LengthAwarePaginator($items, $this->count(), $perPage, $currentPage))->setPath($path);
102 102
     }
Please login to merge, or discard this patch.
src/Urls/UrlRecord.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -65,8 +65,8 @@  discard block
 block discarded – undo
65 65
     public static function getByModel(Model $model)
66 66
     {
67 67
         return static::where('model_type', $model->getMorphClass())
68
-                     ->where('model_id', $model->id)
69
-                     ->get();
68
+                        ->where('model_id', $model->id)
69
+                        ->get();
70 70
     }
71 71
 
72 72
     public function replaceAndRedirect(array $values): UrlRecord
@@ -119,9 +119,9 @@  discard block
 block discarded – undo
119 119
         if ($ignoredModel) {
120 120
             $builder->whereNotIn('id', function ($query) use ($ignoredModel) {
121 121
                 $query->select('id')
122
-                      ->from('chief_urls')
123
-                      ->where('model_type', '=', $ignoredModel->getMorphClass())
124
-                      ->where('model_id', '=', $ignoredModel->id);
122
+                        ->from('chief_urls')
123
+                        ->where('model_type', '=', $ignoredModel->getMorphClass())
124
+                        ->where('model_id', '=', $ignoredModel->id);
125 125
             });
126 126
         }
127 127
 
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -115,12 +115,12 @@  discard block
 block discarded – undo
115 115
             $builder->where('locale', $locale);
116 116
         }
117 117
 
118
-        if (! $includeRedirects) {
118
+        if (!$includeRedirects) {
119 119
             $builder->whereNull('redirect_id');
120 120
         }
121 121
 
122 122
         if ($ignoredModel) {
123
-            $builder->whereNotIn('id', function ($query) use ($ignoredModel) {
123
+            $builder->whereNotIn('id', function($query) use ($ignoredModel) {
124 124
                 $query->select('id')
125 125
                       ->from('chief_urls')
126 126
                       ->where('model_type', '=', $ignoredModel->getMorphClass())
@@ -133,16 +133,16 @@  discard block
 block discarded – undo
133 133
 
134 134
     public static function allOnlineModels(): array
135 135
     {
136
-        return chiefMemoize('all-online-models', function () {
136
+        return chiefMemoize('all-online-models', function() {
137 137
 
138 138
             $liveUrlRecords = static::whereNull('redirect_id')->select('model_type', 'model_id')->groupBy('model_type', 'model_id')->get()->mapToGroups(function($record) {
139 139
                 return [$record->model_type => $record->model_id];
140 140
             });
141 141
 
142 142
             // Get model for each of these records...
143
-            $models = $liveUrlRecords->map(function($record, $key){
143
+            $models = $liveUrlRecords->map(function($record, $key) {
144 144
                 return Morphables::instance($key)->find($record->toArray());
145
-            })->each->reject(function ($model) {
145
+            })->each->reject(function($model) {
146 146
                 // Invalid references to archived or removed models where url record still exists.
147 147
                 return is_null($model);
148 148
             })->flatten();
Please login to merge, or discard this patch.
src/Urls/MemoizedUrlRecord.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,14 +8,14 @@
 block discarded – undo
8 8
 {
9 9
     public static function findByModel(Model $model, string $locale = null): UrlRecord
10 10
     {
11
-        return chiefMemoize('url-records-find-by-model', function ($model, $locale = null) {
11
+        return chiefMemoize('url-records-find-by-model', function($model, $locale = null) {
12 12
             return parent::findByModel($model, $locale);
13 13
         }, [$model, $locale]);
14 14
     }
15 15
 
16 16
     public static function getByModel(Model $model)
17 17
     {
18
-        return chiefMemoize('url-records-get-by-model', function ($model) {
18
+        return chiefMemoize('url-records-get-by-model', function($model) {
19 19
             return parent::getByModel($model);
20 20
         }, [$model]);
21 21
     }
Please login to merge, or discard this patch.
src/Urls/SaveUrlSlugs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     private function saveRecord(string $locale, ?string $slug)
40 40
     {
41 41
         // Existing ones for this locale?
42
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
42
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
43 43
             return (
44 44
                 $record->locale == $locale &&
45 45
                 !$record->isRedirect()
@@ -55,14 +55,14 @@  discard block
 block discarded – undo
55 55
 
56 56
         // If slug entry is left empty, all existing records will be deleted
57 57
         if (!$slug) {
58
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
58
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
59 59
                 $existingRecord->delete();
60 60
             });
61 61
         } elseif ($nonRedirectsWithSameLocale->isEmpty()) {
62 62
             $this->createRecord($locale, $slug);
63
-        } else {
63
+        }else {
64 64
             // Only replace the existing records that differ from the current passed slugs
65
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
65
+            $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
66 66
                 if ($existingRecord->slug != $slug) {
67 67
                     $existingRecord->replaceAndRedirect(['slug' => $slug]);
68 68
                 }
@@ -87,12 +87,12 @@  discard block
 block discarded – undo
87 87
      */
88 88
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
89 89
     {
90
-        $existingRecords->filter(function ($record) use ($locale) {
90
+        $existingRecords->filter(function($record) use ($locale) {
91 91
             return (
92 92
                 $record->locale == $locale &&
93 93
                 $record->isRedirect()
94 94
             );
95
-        })->each(function ($existingRecord) use ($slug) {
95
+        })->each(function($existingRecord) use ($slug) {
96 96
             if ($existingRecord->slug == $slug) {
97 97
                 $existingRecord->delete();
98 98
             }
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      */
107 107
     private function prependBaseUrlSegment(string $slug, $locale): string
108 108
     {
109
-        $slugWithBaseSegment = $this->model->baseUrlSegment($locale) . '/' . $slug;
109
+        $slugWithBaseSegment = $this->model->baseUrlSegment($locale).'/'.$slug;
110 110
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
111 111
 
112 112
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.
src/Urls/ChiefResponse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
                 return static::createRedirect($model->url($locale));
40 40
             }
41 41
 
42
-            if (method_exists($model, 'isPublished') && ! $model->isPublished()) {
42
+            if (method_exists($model, 'isPublished') && !$model->isPublished()) {
43 43
 
44 44
                 /** When admin is logged in and this request is in preview mode, we allow the view */
45
-                if (! PreviewMode::fromRequest()->check()) {
46
-                    throw new NotFoundHttpException('Model found for request ['. $slug .'] but it is not published.');
45
+                if (!PreviewMode::fromRequest()->check()) {
46
+                    throw new NotFoundHttpException('Model found for request ['.$slug.'] but it is not published.');
47 47
                 }
48 48
             }
49 49
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             }
55 55
         }
56 56
 
57
-        throw new NotFoundHttpException('No url or model found for request ['. $slug .'] for locale ['.$locale.'].');
57
+        throw new NotFoundHttpException('No url or model found for request ['.$slug.'] for locale ['.$locale.'].');
58 58
     }
59 59
 
60 60
     private static function createRedirect(string $url)
Please login to merge, or discard this patch.
src/Concerns/Viewable/Viewable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         // If no view has been created for this model, we try once again to fetch the content value if any. This will silently fail
38 38
         // if no content value is present. We consider the 'content' attribute to be a default for our copy.
39
-        return isset($this->content) ? (string) $this->content : '';
39
+        return isset($this->content) ? (string)$this->content : '';
40 40
     }
41 41
 
42 42
     public function setViewParent(ActsAsParent $parent): ViewableContract
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         if (config('thinktomorrow.chief.strict')) {
67
-            throw new NotFoundViewKey('Missing view key. Please add a [viewKey] property to ' . get_class($this));
67
+            throw new NotFoundViewKey('Missing view key. Please add a [viewKey] property to '.get_class($this));
68 68
         };
69 69
 
70 70
         return '';
Please login to merge, or discard this patch.