UniqueSlug::isSlugUnique() - Code Metrics - Inspection of "Merge pull request #27 from thinktomorrow/analysis..." - thinktomorrow/chief - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — ft/package ( 5ee474...180175 )

by Philippe

created 2018-05-29 12:30 UTC

UniqueSlug::isSlugUnique() B

↳ Parent: UniqueSlug

Complexity

Conditions	5
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	5.2

Importance

Changes

Metric	Value
cc	5
eloc	4
nc	2
nop	2
dl	0
loc	9
ccs	4
cts	5
cp	0.8
crap	5.2
rs	8.8571
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Chief\Common;

use Thinktomorrow\Chief\Common\Contracts\SluggableContract;
use Illuminate\Support\Str;

class UniqueSlug
{
    /**
     * @var SluggableContract
     */
    private $model;

    public function __construct(SluggableContract $model)
    {
        $this->model = $model;
    }

    public static function make($model)
    {
        return new static($model);
    }

    public function get($title, SluggableContract $entity = null)
    {
        $slug = $originalslug = Str::slug($title);
        $i = 1;

        while (!$this->isSlugUnique($slug, $entity)) {
            $slug = $originalslug.'-'.$i;
            $i++;
        }

        return $slug;
    }

    /**
     *
     * @param $slug
     * @param SluggableContract $entity
     * @return bool
     */
    private function isSlugUnique($slug, SluggableContract $entity = null)
    {
        $model = $this->model->findBySlug($slug);

        if (!$model || ($entity && $entity->id && $model->id == $entity->id)) {

            return true;
        }

        return false;
    }
}


1		<?php
2
3		namespace Thinktomorrow\Chief\Common;
4
5		use Thinktomorrow\Chief\Common\Contracts\SluggableContract;
6		use Illuminate\Support\Str;
7
8		class UniqueSlug
9		{
10		/**
11		* @var SluggableContract
12		*/
13		private $model;
14
15	2	public function __construct(SluggableContract $model)
16		{
17	2	$this->model = $model;
18	2	}
19
20	2	public static function make($model)
21		{
22	2	return new static($model);
23		}
24
25	2	public function get($title, SluggableContract $entity = null)
26		{
27	2	$slug = $originalslug = Str::slug($title);
28	2	$i = 1;
29
30	2	while (!$this->isSlugUnique($slug, $entity)) {
31		$slug = $originalslug.'-'.$i;
32		$i++;
33		}
34
35	2	return $slug;
36		}
37
38		/**
39		*
40		* @param $slug
41		* @param SluggableContract $entity
42		* @return bool
43		*/
44	2	private function isSlugUnique($slug, SluggableContract $entity = null)
45		{
46	2	$model = $this->model->findBySlug($slug);
47
48	2	if (!$model \|\| ($entity && $entity->id && $model->id == $entity->id)) {
		0 ignored issues – show Bug introduced 2018-05-29 09:47 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Thinktomorrow\Chief\Comm...racts\SluggableContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
49	2	return true;
50		}
51
52		return false;
53		}
54		}
55

thinktomorrow / chief

Push — ft/package ( 5ee474...180175 )

UniqueSlug::isSlugUnique() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like