Thinktomorrow\Chief\Common\UniqueSlug

Complexity

Total Complexity

9

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

82.35%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	make()	0	3	1
A	__construct()	0	3	1
A	get()	0	11	2
B	isSlugUnique()	0	9	5

<?php

namespace Thinktomorrow\Chief\Common;

use Thinktomorrow\Chief\Common\Contracts\SluggableContract;
use Illuminate\Support\Str;

class UniqueSlug
{
    /**
     * @var SluggableContract
     */
    private $model;

    public function __construct(SluggableContract $model)
    {
        $this->model = $model;
    }

    public static function make($model)
    {
        return new static($model);
    }

    public function get($title, SluggableContract $entity = null)
    {
        $slug = $originalslug = Str::slug($title);
        $i = 1;

        while (!$this->isSlugUnique($slug, $entity)) {
            $slug = $originalslug.'-'.$i;
            $i++;
        }

        return $slug;
    }

    /**
     *
     * @param $slug
     * @param SluggableContract $entity
     * @return bool
     */
    private function isSlugUnique($slug, SluggableContract $entity = null)
    {
        $model = $this->model->findBySlug($slug);

        if (!$model || ($entity && $entity->id && $model->id == $entity->id)) {

Accessing id on the interface Thinktomorrow\Chief\Common\Contracts\SluggableContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            return true;
        }

        return false;
    }
}