CommandPaletteController::searchThroughAdminPages() - Code Metrics - Inspection of "Fix styling" - thinktomorrow/chief - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — ft/command-palette ( e46615...4ceb60 )

unknown

created 2022-02-10 20:54 UTC

searchThroughAdminPages() B

↳ Parent: CommandPaletteController

Complexity

Conditions	4
Paths	2

Size

Total Lines	85
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	58
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	85
rs	8.9163

How to fix Long Method

<?php

namespace Thinktomorrow\Chief\App\Http\Controllers\Back\CommandPalette;

use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Thinktomorrow\Chief\App\Http\Controllers\Controller;
use Thinktomorrow\Chief\Managers\Register\Registry;

class CommandPaletteController extends Controller
{
    public function __construct()
    {
        $this->pageModels = $this->getAllPageModels();

    }

    public function search(Request $request, string $term = '')
    {
        $lowercaseTerm = Str::lower($term);

        $results = [
            ...$this->searchThroughPageModels($lowercaseTerm),
            ...$this->searchThroughAdminPages($lowercaseTerm),
        ];

        return response()->view('chief::layout.nav.command-palette._result', [
            'term' => $term,
            'results' => $results,
        ]);
    }

    public function searchThroughPageModels($term)
    {
        $results = [];

        foreach ($this->pageModels as $modelGroup) {
            $resultGroup = [];

            foreach ($modelGroup['models'] as $model) {
                if (
                    Str::contains(Str::lower($model->adminConfig()->getModelName()), $term) ||
                    Str::contains(Str::lower($model->adminConfig()->getIndexTitle()), $term) ||
                    Str::contains(Str::lower($model->adminConfig()->getNavTitle()), $term) ||
                    Str::contains(Str::lower($model->adminConfig()->getPageTitle()), $term) ||
                    Str::contains(Str::lower($model->title ?? ''), $term)
                ) {
                    $resultGroup[$model->modelReference()->getShort()] = [
                        'label' => $model->title,
                        'url' => '/admin/' . $model->managedModelKey() . '/' . $model->id . '/edit',
                    ];
                }
            }

            if (count($resultGroup) !== 0) {
                $firstModel = $modelGroup['models']->first();

                array_push($resultGroup, [
                    'label' => ucfirst($modelGroup['label']) . ' overzicht',
                    'url' => '/admin/' . $firstModel->managedModelKey(),
                ]);

                array_push($results, [
                    'label' => $modelGroup['label'],
                    'models' => $resultGroup,
                ]);
            }
        }

        return $results;
    }

    public function searchThroughAdminPages($term)
    {
        $adminPages = collect([
            [
                'label' => 'Menu',
                'url' => route('chief.back.menus.index'),
                'permission' => 'update-page',
                'tags' => ['navigatie'],
            ], [
                'label' => 'Media',
                'url' => route('chief.mediagallery.index'),
                'permission' => 'update-page',
                'tags' => ['mediagalerij', 'mediabibliotheek', 'assets'],
            ], [
                'label' => 'Teksten',
                'url' => route('squanto.index'),
                'permission' => 'view-squanto',
                'tags' => ['squanto', 'mediagalerij', 'mediabibliotheek', 'assets'],
            ], [
                'label' => 'Sitemap',
                'url' => route('chief.back.sitemap.show'),
                'permission' => null,
                'tags' => [],
            ], [
                'label' => 'Admins',
                'url' => route('chief.back.users.index'),
                'permission' => 'view-user',
                'tags' => [],
            ], [
                'label' => 'Rechten',
                'url' => route('chief.back.roles.index'),
                'permission' => 'view-role',
                'tags' => ['roles'],
            ], [
                'label' => 'Settings',
                'url' => route('chief.back.settings.edit'),
                'permission' => 'update-setting',
                'tags' => ['instellingen'],
            ], [
                'label' => 'Audit',
                'url' => route('chief.back.audit.index'),
                'permission' => 'view-audit',
                'tags' => [],
            ], [
                'label' => chiefAdmin()->firstname,

                'url' => route('chief.back.you.edit'),
                'permission' => 'update-you',
                'tags' => ['account'],
            ], [
                'label' => 'Logout',
                'url' => route('chief.back.logout'),
                'permission' => null,
                'tags' => [],
            ],
        ]);

        $models = $adminPages->filter(function ($adminPage) use ($term) {
            // Check if label contains search term
            if (Str::contains(Str::lower($adminPage['label']), $term)) {
                return true;
            }

            // Check if any of tags contain search term
            if (collect($adminPage['tags'])->contains(function ($tag) use ($term) {
                return Str::contains(Str::lower($tag), $term);
            })) {
                return true;
            };

            return false;
        })->map(function ($adminPage) {
            return [
                'label' => $adminPage['label'],
                'url' => $adminPage['url'],
            ];
        })->toArray();

        if (count($models) === 0) {
            return [];
        }

        return [
            [
                'label' => 'Chief',
                'models' => $models,
            ],
        ];
    }

    private function getAllPageModels(): Collection
    {
        return collect(app(Registry::class)->models())
            // Filter out fragment models
            ->filter(function ($model) {
                return ! in_array('Thinktomorrow\Chief\Fragments\Fragmentable', class_implements($model));
                // Return all instances of the models
            })->map(function ($model) {
                $models = $model::all();

                return [
                    'label' => $model::make()->adminConfig()->getModelName(),
                    'models' => $models,
                ];
            });
    }

    // Add these pages to end of model groups search result
    public static function getAllPageModelIndices(): Collection
    {
        return collect(app(Registry::class)->models())
            // Filter out fragment models
            ->filter(function ($model) {
                return ! in_array('Thinktomorrow\Chief\Fragments\Fragmentable', class_implements($model));
                // Return all instances of the models
            })->map(function ($model) {
                $model = $model::make();

                return [
                    'label' => $model->adminConfig()->getNavTitle(),
                    'url' => '/admin/' . $model->managedModelKey(),
                ];
            });
    }
}


1			<?php
2
3			namespace Thinktomorrow\Chief\App\Http\Controllers\Back\CommandPalette;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Support\Collection;
7			use Illuminate\Support\Str;
8			use Thinktomorrow\Chief\App\Http\Controllers\Controller;
9			use Thinktomorrow\Chief\Managers\Register\Registry;
10
11			class CommandPaletteController extends Controller
12			{
13			public function __construct()
14			{
15			$this->pageModels = $this->getAllPageModels();
			0 ignored issues – show Bug Best Practice introduced 2022-02-08 22:56 UTC by Report Bug Copy Issue Report The property `pageModels` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
16			}
17
18			public function search(Request $request, string $term = '')
19			{
20			$lowercaseTerm = Str::lower($term);
21
22			$results = [
23			...$this->searchThroughPageModels($lowercaseTerm),
24			...$this->searchThroughAdminPages($lowercaseTerm),
25			];
26
27			return response()->view('chief::layout.nav.command-palette._result', [
28			'term' => $term,
29			'results' => $results,
30			]);
31			}
32
33			public function searchThroughPageModels($term)
34			{
35			$results = [];
36
37			foreach ($this->pageModels as $modelGroup) {
38			$resultGroup = [];
39
40			foreach ($modelGroup['models'] as $model) {
41			if (
42			Str::contains(Str::lower($model->adminConfig()->getModelName()), $term) \|\|
43			Str::contains(Str::lower($model->adminConfig()->getIndexTitle()), $term) \|\|
44			Str::contains(Str::lower($model->adminConfig()->getNavTitle()), $term) \|\|
45			Str::contains(Str::lower($model->adminConfig()->getPageTitle()), $term) \|\|
46			Str::contains(Str::lower($model->title ?? ''), $term)
47			) {
48			$resultGroup[$model->modelReference()->getShort()] = [
49			'label' => $model->title,
50			'url' => '/admin/' . $model->managedModelKey() . '/' . $model->id . '/edit',
51			];
52			}
53			}
54
55			if (count($resultGroup) !== 0) {
56			$firstModel = $modelGroup['models']->first();
57
58			array_push($resultGroup, [
59			'label' => ucfirst($modelGroup['label']) . ' overzicht',
60			'url' => '/admin/' . $firstModel->managedModelKey(),
61			]);
62
63			array_push($results, [
64			'label' => $modelGroup['label'],
65			'models' => $resultGroup,
66			]);
67			}
68			}
69
70			return $results;
71			}
72
73			public function searchThroughAdminPages($term)
74			{
75			$adminPages = collect([
76			[
77			'label' => 'Menu',
78			'url' => route('chief.back.menus.index'),
79			'permission' => 'update-page',
80			'tags' => ['navigatie'],
81			], [
82			'label' => 'Media',
83			'url' => route('chief.mediagallery.index'),
84			'permission' => 'update-page',
85			'tags' => ['mediagalerij', 'mediabibliotheek', 'assets'],
86			], [
87			'label' => 'Teksten',
88			'url' => route('squanto.index'),
89			'permission' => 'view-squanto',
90			'tags' => ['squanto', 'mediagalerij', 'mediabibliotheek', 'assets'],
91			], [
92			'label' => 'Sitemap',
93			'url' => route('chief.back.sitemap.show'),
94			'permission' => null,
95			'tags' => [],
96			], [
97			'label' => 'Admins',
98			'url' => route('chief.back.users.index'),
99			'permission' => 'view-user',
100			'tags' => [],
101			], [
102			'label' => 'Rechten',
103			'url' => route('chief.back.roles.index'),
104			'permission' => 'view-role',
105			'tags' => ['roles'],
106			], [
107			'label' => 'Settings',
108			'url' => route('chief.back.settings.edit'),
109			'permission' => 'update-setting',
110			'tags' => ['instellingen'],
111			], [
112			'label' => 'Audit',
113			'url' => route('chief.back.audit.index'),
114			'permission' => 'view-audit',
115			'tags' => [],
116			], [
117			'label' => chiefAdmin()->firstname,
			0 ignored issues – show Bug introduced 2022-02-10 20:59 UTC by Report Bug Copy Issue Report Accessing `firstname` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
118			'url' => route('chief.back.you.edit'),
119			'permission' => 'update-you',
120			'tags' => ['account'],
121			], [
122			'label' => 'Logout',
123			'url' => route('chief.back.logout'),
124			'permission' => null,
125			'tags' => [],
126			],
127			]);
128
129			$models = $adminPages->filter(function ($adminPage) use ($term) {
130			// Check if label contains search term
131			if (Str::contains(Str::lower($adminPage['label']), $term)) {
132			return true;
133			}
134
135			// Check if any of tags contain search term
136			if (collect($adminPage['tags'])->contains(function ($tag) use ($term) {
137			return Str::contains(Str::lower($tag), $term);
138			})) {
139			return true;
140			};
141
142			return false;
143			})->map(function ($adminPage) {
144			return [
145			'label' => $adminPage['label'],
146			'url' => $adminPage['url'],
147			];
148			})->toArray();
149
150			if (count($models) === 0) {
151			return [];
152			}
153
154			return [
155			[
156			'label' => 'Chief',
157			'models' => $models,
158			],
159			];
160			}
161
162			private function getAllPageModels(): Collection
163			{
164			return collect(app(Registry::class)->models())
165			// Filter out fragment models
166			->filter(function ($model) {
167			return ! in_array('Thinktomorrow\Chief\Fragments\Fragmentable', class_implements($model));
168			// Return all instances of the models
169			})->map(function ($model) {
170			$models = $model::all();
171
172			return [
173			'label' => $model::make()->adminConfig()->getModelName(),
174			'models' => $models,
175			];
176			});
177			}
178
179			// Add these pages to end of model groups search result
180			public static function getAllPageModelIndices(): Collection
181			{
182			return collect(app(Registry::class)->models())
183			// Filter out fragment models
184			->filter(function ($model) {
185			return ! in_array('Thinktomorrow\Chief\Fragments\Fragmentable', class_implements($model));
186			// Return all instances of the models
187			})->map(function ($model) {
188			$model = $model::make();
189
190			return [
191			'label' => $model->adminConfig()->getNavTitle(),
192			'url' => '/admin/' . $model->managedModelKey(),
193			];
194			});
195			}
196			}
197

thinktomorrow / chief

Push — ft/command-palette ( e46615...4ceb60 )

searchThroughAdminPages() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like