Completed
Pull Request — 0.3 (#235)
by Ben
95:19 queued 89:03
created
src/Concerns/Viewable/Viewable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         // If no view has been created for this model, we try once again to fetch the content value if any. This will silently fail
38 38
         // if no content value is present. We consider the 'content' attribute to be a default for our copy.
39
-        return isset($this->content) ? (string) $this->content : '';
39
+        return isset($this->content) ? (string)$this->content : '';
40 40
     }
41 41
 
42 42
     public function setViewParent(ActsAsParent $parent): ViewableContract
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         if (config('thinktomorrow.chief.strict')) {
67
-            throw new NotFoundViewKey('Missing view key. Please add a [viewKey] property to ' . get_class($this));
67
+            throw new NotFoundViewKey('Missing view key. Please add a [viewKey] property to '.get_class($this));
68 68
         };
69 69
 
70 70
         return '';
Please login to merge, or discard this patch.
src/Management/Assistants/AssistedManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
      */
18 18
     public function isAssistedBy(string $assistant): bool
19 19
     {
20
-        return !! $this->getAssistantClass($assistant);
20
+        return !!$this->getAssistantClass($assistant);
21 21
     }
22 22
 
23 23
     public function assistants(): array
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function assistant(string $assistant): Assistant
42 42
     {
43
-        if (! $this->isAssistedBy($assistant)) {
44
-            throw new MissingAssistant('No assistant [' . $assistant . '] present on manager ' . get_class($this));
43
+        if (!$this->isAssistedBy($assistant)) {
44
+            throw new MissingAssistant('No assistant ['.$assistant.'] present on manager '.get_class($this));
45 45
         }
46 46
 
47 47
         $instance = app($this->getAssistantClass($assistant));
Please login to merge, or discard this patch.
src/Management/Registration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,12 +83,12 @@
 block discarded – undo
83 83
         }
84 84
 
85 85
         $manager = new \ReflectionClass($managerClass);
86
-        if (! $manager->implementsInterface(Manager::class)) {
86
+        if (!$manager->implementsInterface(Manager::class)) {
87 87
             throw new \InvalidArgumentException('Class ['.$managerClass.'] is expected to implement the ['.Manager::class.'] contract.');
88 88
         }
89 89
 
90 90
         $model = new \ReflectionClass($modelClass);
91
-        if (! $model->implementsInterface(ManagedModel::class)) {
91
+        if (!$model->implementsInterface(ManagedModel::class)) {
92 92
             throw new \InvalidArgumentException('Class ['.$modelClass.'] is expected to implement the ['.ManagedModel::class.'] contract.');
93 93
         }
94 94
     }
Please login to merge, or discard this patch.
src/Fields/Fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
123 123
 
124 124
     public function offsetSet($offset, $value)
125 125
     {
126
-        if (! $value instanceof Field) {
127
-            throw new \InvalidArgumentException('Passed value must be of type ' . Field::class);
126
+        if (!$value instanceof Field) {
127
+            throw new \InvalidArgumentException('Passed value must be of type '.Field::class);
128 128
         }
129 129
 
130 130
         $this->fields[$offset] = $value;
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
     private function validateFields(array $fields)
155 155
     {
156
-        array_map(function (Field $field) {
156
+        array_map(function(Field $field) {
157 157
         }, $fields);
158 158
     }
159 159
 
Please login to merge, or discard this patch.
src/Modules/ModuleManager.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
     {
64 64
         $permission = 'update-page';
65 65
 
66
-        if (in_array($verb, ['index','show'])) {
66
+        if (in_array($verb, ['index', 'show'])) {
67 67
             $permission = 'view-page';
68
-        } elseif (in_array($verb, ['create','store'])) {
68
+        } elseif (in_array($verb, ['create', 'store'])) {
69 69
             $permission = 'create-page';
70 70
         } elseif (in_array($verb, ['delete'])) {
71 71
             $permission = 'delete-page';
72 72
         }
73 73
 
74
-        if (! auth()->guard('chief')->user()->hasPermissionTo($permission)) {
74
+        if (!auth()->guard('chief')->user()->hasPermissionTo($permission)) {
75 75
             throw NotAllowedManagerRoute::notAllowedPermission($permission, $this);
76 76
         }
77 77
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function saveFields(Request $request)
104 104
     {
105 105
         // Store the morph_key upon creation
106
-        if (! $this->model->morph_key) {
106
+        if (!$this->model->morph_key) {
107 107
             $this->model->morph_key = $this->model->morphKey();
108 108
         }
109 109
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
             if (is_array_empty($translation)) {
143 143
 
144 144
                 // Nullify all values
145
-                $trans[$locale] = array_map(function ($value) {
145
+                $trans[$locale] = array_map(function($value) {
146 146
                     return null;
147 147
                 }, $translation);
148 148
                 continue;
Please login to merge, or discard this patch.
src/Management/AbstractManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
             $this->filters()->apply($builder);
74 74
 
75 75
             $results = $builder->get();
76
-        } else {
76
+        }else {
77 77
             $results = $model::all();
78 78
         }
79 79
 
80
-        return $results->map(function ($model) {
80
+        return $results->map(function($model) {
81 81
             return (new static($this->registration))->manage($model);
82 82
         });
83 83
     }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 
146 146
     public function guard($verb): Manager
147 147
     {
148
-        if (! $this->can($verb)) {
148
+        if (!$this->can($verb)) {
149 149
             NotAllowedManagerRoute::notAllowedVerb($verb, $this);
150 150
         }
151 151
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $fields = $this->fields();
169 169
 
170 170
         foreach ($this->assistants() as $assistant) {
171
-            if (! method_exists($assistant, 'fields')) {
171
+            if (!method_exists($assistant, 'fields')) {
172 172
                 continue;
173 173
             }
174 174
 
Please login to merge, or discard this patch.
src/Fields/SavingFields.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
             // Media fields are treated separately
28 28
             if ($field->ofType(FieldType::MEDIA, FieldType::DOCUMENT)) {
29
-                if (! isset($this->saveMethods['_files'])) {
29
+                if (!isset($this->saveMethods['_files'])) {
30 30
                     $this->saveMethods['_files'] = ['field' => new Fields([$field]), 'method' => 'uploadMedia'];
31 31
                     continue;
32 32
                 }
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             }
37 37
 
38 38
             // Custom set methods - default is the generic setField() method.
39
-            $methodName = 'set'. ucfirst(Str::camel($field->key())) . 'Field';
39
+            $methodName = 'set'.ucfirst(Str::camel($field->key())).'Field';
40 40
             (method_exists($this, $methodName))
41 41
                 ? $this->$methodName($field, $request)
42 42
                 : $this->setField($field, $request);
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
     protected function detectCustomSaveMethods(Field $field): bool
55 55
     {
56
-        $saveMethodName = 'save'. ucfirst(Str::camel($field->key())) . 'Field';
56
+        $saveMethodName = 'save'.ucfirst(Str::camel($field->key())).'Field';
57 57
 
58 58
         // Custom save method on assistant
59 59
         foreach ($this->assistants() as $assistant) {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
             // Make our media fields able to be translatable as well...
97 97
             if ($field->ofType(FieldType::MEDIA, FieldType::DOCUMENT)) {
98
-                throw new \Exception('Cannot process the ' . $field->key . ' media field. Currently no support for translatable media files. We should fix this!');
98
+                throw new \Exception('Cannot process the '.$field->key.' media field. Currently no support for translatable media files. We should fix this!');
99 99
             }
100 100
 
101 101
             // Okay so this is a bit odd but since all translations are expected to be inside the trans
Please login to merge, or discard this patch.
src/Settings/SettingsServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function register()
15 15
     {
16
-        $this->app->singleton(Settings::class, function ($app) {
16
+        $this->app->singleton(Settings::class, function($app) {
17 17
             return new Settings();
18 18
         });
19 19
     }
Please login to merge, or discard this patch.
src/Urls/UrlSlugFields.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
     public static function redirectsFromModel(ProvidesUrl $model)
20 20
     {
21
-        $records = MemoizedUrlRecord::getByModel($model)->reject(function ($record) {
21
+        $records = MemoizedUrlRecord::getByModel($model)->reject(function($record) {
22 22
             return !$record->isRedirect();
23 23
         })->sortByDesc('created_at');
24 24
 
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             $fields[$key] = UrlSlugField::make($key)
30 30
                 ->setUrlRecord($record)
31 31
                 ->setBaseUrlSegment($model->baseUrlSegment($record->locale))
32
-                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)) .'/');
32
+                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)).'/');
33 33
         }
34 34
 
35 35
         return $fields;
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
         $fields = new static([]);
62 62
 
63 63
         foreach ($locales as $locale) {
64
-            $fields['url-slugs.' . $locale] = UrlSlugField::make('url-slugs.' . $locale)
64
+            $fields['url-slugs.'.$locale] = UrlSlugField::make('url-slugs.'.$locale)
65 65
                                                 ->setBaseUrlSegment($model->baseUrlSegment($locale))
66
-                                                ->prepend($model->resolveUrl($locale, $model->baseUrlSegment($locale)) .'/')
67
-                                                ->name('url-slugs[' . $locale . ']')
66
+                                                ->prepend($model->resolveUrl($locale, $model->baseUrlSegment($locale)).'/')
67
+                                                ->name('url-slugs['.$locale.']')
68 68
                                                 ->label($locale);
69 69
         }
70 70
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      */
78 78
     private static function fillWithExistingValues(ProvidesUrl $model, self $fields): void
79 79
     {
80
-        $records = UrlRecord::getByModel($model)->reject(function ($record) {
80
+        $records = UrlRecord::getByModel($model)->reject(function($record) {
81 81
             return $record->isRedirect();
82 82
         })->sortBy('locale');
83 83
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $fields['url-slugs.'.$record->locale]
90 90
                 ->setUrlRecord($record)
91 91
                 ->setBaseUrlSegment($model->baseUrlSegment($record->locale))
92
-                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)) .'/');
92
+                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)).'/');
93 93
         }
94 94
     }
95 95
 }
Please login to merge, or discard this patch.