Thinktomorrow\Chief\App\Http\Controllers\Back\Users\UserController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	7	1
A	edit()	0	7	1
A	store()	0	25	4
A	index()	0	7	1
B	update()	0	29	7

<?php

namespace Thinktomorrow\Chief\App\Http\Controllers\Back\Users;

use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Request;
use Thinktomorrow\Chief\Admin\Authorization\Role;
use Thinktomorrow\Chief\Admin\Users\Invites\Application\InviteUser;
use Thinktomorrow\Chief\Admin\Users\User;
use Thinktomorrow\Chief\App\Http\Controllers\Controller;

class UserController extends Controller
{
    public function index()
    {
        $this->authorize('view-user');

        $users = User::all();

        return view('chief::admin.users.index')->with('users', $users);
    }

    /**
     * Show the invite form
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
     */
    public function create()
    {
        $this->authorize('create-user');

        return view('chief::admin.users.create', [
            'user' => new User(),
            'roleNames' => Role::rolesForSelect(chiefAdmin()->hasRole('developer')),

The method hasRole() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

        ]);
    }

    public function store(Request $request)
    {
        $this->authorize('create-user');

        // Sanitize an empty array that is passed as [null]
        $requestRoles = $request->input('roles');
        if (is_array($requestRoles) && count($requestRoles) == 1 && reset($requestRoles) === null) {
            $request = $request->merge(['roles' => []]);
        }

        $this->validate($request, [
            'firstname' => 'required',
            'lastname' => 'required',
            'email' => 'required|email|unique:' . (new User())->getTable(),
            'roles' => 'required|array',
        ]);

        $user = User::create($request->only(['firstname', 'lastname', 'email']));

        $user->assignRole($request->get('roles', []));

        app(InviteUser::class)->handle($user, auth()->guard('chief')->user());

It seems like $user can also be of type Illuminate\Database\Eloquent\PendingHasThroughRelationship; however, parameter $invitee of Thinktomorrow\Chief\Admin\Users\Invites\Application\InviteUser::handle() does only seem to accept Thinktomorrow\Chief\Admin\Users\User, maybe add an additional type check?

        return redirect()->route('chief.back.users.index')
            ->with('messages.success', 'De nieuwe gebruiker is uitgenodigd en zal zodra een bevestiging ontvangen via mail.');
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
     */
    public function edit($id)
    {
        $this->authorize('update-user');

        return view('chief::admin.users.edit', [
            'user' => User::findOrFail($id),
            'roleNames' => Role::rolesForSelect(chiefAdmin()->hasRole('developer')),
        ]);
    }

    public function update(Request $request, $id)
    {
        $this->authorize('update-user');

        // Sanitize an empty array that is passed as [null]
        $requestRoles = $request->get('roles');
        if (is_array($requestRoles) && count($requestRoles) == 1 && reset($requestRoles) === null) {
            $request = $request->merge(['roles' => []]);
        }

        $this->validate($request, [
            'firstname' => 'required',
            'lastname' => 'required',
            'email' => 'required|email|unique:' . (new User())->getTable() . ',email,' . $id,
            'roles' => 'required|array',
        ]);

        $user = User::findOrFail($id);

        // Only another developer can change another developer.
        if (! chiefAdmin()->hasRole('developer') && ($user->hasRole('developer') || in_array('developer', $request->get('roles', [])))) {
            throw new AuthorizationException('Constraint: Only an user with role developer can update an user with developer role.');
        }

        $user->update($request->only(['firstname', 'lastname', 'email']));
        $user->syncRoles($request->get('roles', []));

        return redirect()->route('chief.back.users.index')
            ->with('messages.success', 'Gegevens van de gebruiker zijn aangepast.');
    }
}