Thinktomorrow\Chief\App\Http\Controllers\Back\Users\DisableUserController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	store()	0	15	2

<?php

namespace Thinktomorrow\Chief\App\Http\Controllers\Back\Users;

use Illuminate\Http\Request;
use Thinktomorrow\Chief\Admin\Users\Application\DisableUser;
use Thinktomorrow\Chief\Admin\Users\User;
use Thinktomorrow\Chief\App\Http\Controllers\Controller;

class DisableUserController extends Controller
{
    public function store(Request $request, $id)
    {
        $this->authorize('disable-user');

        if (chiefAdmin()->id == $id) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return redirect()->back()
                ->with('messages.error', 'U kan uzelf niet blokkeren.');
        }

        $user = User::findOrFail($id);

        app(DisableUser::class)->handle($user);

        return redirect()->route('chief.back.users.index')
            ->with('messages.success', 'De gebruikersaccount is geblokkeerd met onmiddellijke ingang.');
    }
}