Thinktomorrow\Chief\App\Http\Controllers\Back\Menu\MenuItemController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	19	2
A	destroy()	0	16	2
A	create()	0	17	1
A	__construct()	0	3	1
A	update()	0	11	1
A	store()	0	11	1

<?php

namespace Thinktomorrow\Chief\App\Http\Controllers\Back\Menu;

use Thinktomorrow\Chief\Admin\Audit\Audit;
use Thinktomorrow\Chief\App\Http\Controllers\Controller;
use Thinktomorrow\Chief\App\Http\Requests\MenuRequest;
use Thinktomorrow\Chief\Site\Menu\Application\CreateMenuItem;
use Thinktomorrow\Chief\Site\Menu\Application\DeleteMenuItem;
use Thinktomorrow\Chief\Site\Menu\Application\UpdateMenuItem;
use Thinktomorrow\Chief\Site\Menu\Menu;
use Thinktomorrow\Chief\Site\Menu\MenuItem;
use Thinktomorrow\Chief\Site\Menu\Tree\PrepareMenuItemsForAdminSelect;
use Thinktomorrow\Chief\Site\Urls\UrlHelper;

class MenuItemController extends Controller
{
    private PrepareMenuItemsForAdminSelect $prepareMenuItemsForAdminSelect;

    public function __construct(PrepareMenuItemsForAdminSelect $prepareMenuItemsForAdminSelect)
    {
        $this->prepareMenuItemsForAdminSelect = $prepareMenuItemsForAdminSelect;
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
     */
    public function create(string $menutype)
    {
        $this->authorize('create-page');

        $menuitem = new MenuItem();
        $menuitem->type = MenuItem::TYPE_INTERNAL;  // Default menu type
        $menuitem->menu_type = $menutype;

        $menuitems = $this->prepareMenuItemsForAdminSelect->prepare(
            Menu::tree($menutype, config('app.fallback_locale'))

The call to Thinktomorrow\Chief\Site\Menu\Menu::tree() has too many arguments starting with config('app.fallback_locale').

        );

        return view('chief::admin.menu.create', [
            'pages' => UrlHelper::allOnlineModels(),
            'menuitem' => $menuitem,
            'ownerReference' => null,
            'parents' => $menuitems,
        ]);
    }

    public function store(MenuRequest $request)
    {
        $this->authorize('create-page');

        $menu = app(CreateMenuItem::class)->handle($request);

        Audit::activity()
            ->performedOn($menu)
            ->log('created');

        return redirect()->route('chief.back.menus.show', $menu->menu_type)->with('messages.success', $menu->label . ' is aangemaakt');

The property label does not seem to exist on Thinktomorrow\Chief\Site\Menu\MenuItem. Are you sure there is no database migration missing?

    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
     */
    public function edit($id)
    {
        $this->authorize('update-page');

        $menuitem = MenuItem::findOrFail($id);

        $menuitems = $this->prepareMenuItemsForAdminSelect->prepare(
            Menu::tree(
                $menuitem->menuType(),
                config('app.fallback_locale')

The call to Thinktomorrow\Chief\Site\Menu\Menu::tree() has too many arguments starting with config('app.fallback_locale').

            ),
            $menuitem
        );

        return view('chief::admin.menu.edit', [
            'menuitem' => $menuitem,
            'pages' => UrlHelper::allOnlineModels(),
            'ownerReference' => $menuitem->owner ? $menuitem->owner->modelReference()->getShort() : null,
            'parents' => $menuitems,
        ]);
    }

    public function update(MenuRequest $request, $id)
    {
        $this->authorize('update-page');

        $menu = app(UpdateMenuItem::class)->handle($id, $request);

        Audit::activity()
            ->performedOn($menu)
            ->log('updated');

        return redirect()->route('chief.back.menus.show', $menu->menu_type)->with('messages.success', $menu->label . ' is aangepast');

The property label does not seem to exist on Thinktomorrow\Chief\Site\Menu\MenuItem. Are you sure there is no database migration missing?

    }

    public function destroy($id)
    {
        $this->authorize('delete-page');

        $menuItem = app(DeleteMenuItem::class)->handle($id);

        if ($menuItem) {

$menuItem is of type Thinktomorrow\Chief\Site\Menu\MenuItem, thus it always evaluated to true.

            $message = 'Het item werd verwijderd.';

            Audit::activity()
                ->performedOn($menuItem)
                ->log('deleted');

            return redirect()->route('chief.back.menus.show', $menuItem->menuType())->with('messages.warning', $message);
        } else {
            return redirect()->back()->with('messages.warning', 'Je menu item is niet verwijderd. Probeer opnieuw');
        }
    }
}