Thinktomorrow\Chief\App\Http\Controllers\Auth\ChangePasswordController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	13	1
A	edit()	0	5	1

<?php

namespace Thinktomorrow\Chief\App\Http\Controllers\Auth;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Str;
use Thinktomorrow\Chief\App\Http\Controllers\Controller;

class ChangePasswordController extends Controller
{
    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
     */
    public function edit()
    {
        $user = auth()->guard('chief')->user();

        return view('chief::admin.auth.passwords.edit', ['new_password' => ! $user->password]);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function update(Request $request)
    {
        $this->validate($request, [
            'password' => 'required|confirmed|min:6',
        ]);

        $user = auth()->guard('chief')->user();

        $user->password = Hash::make($request->password);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user->setRememberToken(Str::random(60));
        $user->save();

        return redirect()->route('chief.back.dashboard')->with('messages.success', 'Jouw wachtwoord is aangepast.');
    }
}