Thinktomorrow\AssetLibrary\Models\Application\SortAssets::handle()

Complexity

Conditions	2
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(HasAsset $model, $type, $sorting)
    {
        $files = $model->assets($type);

The method assets() does not exist on Thinktomorrow\AssetLibrary\Interfaces\HasAsset. Since it exists in all sub-types, consider adding an abstract or default implementation to Thinktomorrow\AssetLibrary\Interfaces\HasAsset.

        $files->each(function ($asset) use ($model, $sorting) {
            if (in_array($asset->id, $sorting)) {
                $pivot = $model->assetRelation->find($asset->id)->pivot;

Accessing assetRelation on the interface Thinktomorrow\AssetLibrary\Interfaces\HasAsset suggest that you code against a concrete implementation. How about adding an instanceof check?

                $pivot->order = array_search($asset->id, $sorting);
                $pivot->save();
            }