AssetLibraryServiceProvider::publishMigrations() - Code Metrics - Inspection of "Small refactorings" - thinktomorrow/assetlibrary - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — feature/cropping (36fe5e)

by Philippe

created 2017-10-30 09:20 UTC

AssetLibraryServiceProvider::publishMigrations() A

↳ Parent: AssetLibraryServiceProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	9
ccs	7
cts	7
cp	1
rs	9.6666
cc	2
eloc	6
nc	2
nop	0
crap	2

<?php

namespace Thinktomorrow\AssetLibrary;

use Illuminate\Database\Eloquent\Factory as EloquentFactory;
use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;
use Thinktomorrow\AssetLibrary\Models\Asset;

class AssetLibraryServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot()
    {
        $this->publishes([
            __DIR__.'/../config/thinktomorrow/assetlibrary.php' => config_path('assetlibrary.php'),
        ], 'config');

        $this->setupRoutes($this->app->router);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->publishMigrations();

        $this->registerModelBindings();
        $this->registerEloquentFactoriesFrom(__DIR__.'/../database/factories');
    }

    /**
     * Register factories.
     *
     * @param  string  $path
     * @return void
     */
    protected function registerEloquentFactoriesFrom($path)
    {
        $this->app->make(EloquentFactory::class)->load($path);
    }

    /**
     * Define the routes for the application.
     *
     * @param  \Illuminate\Routing\Router  $router
     * @return void
     */
    public function setupRoutes(Router $router)
    {
        $router->group(['namespace' => 'Thinktomorrow\AssetLibrary\Http\Controllers'], function ($router) {
            require __DIR__.'/Http/routes.php';
        });
    }

    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        $this->mergeConfigFrom(__DIR__.'/../config/assetlibrary.php', 'assetlibrary');

        $this->registerAssetLibrary();
    }

    protected function registerModelBindings()
    {
        //TODO implement this
    }

    /**
     *
     */
    private function registerAssetLibrary()
    {
        $this->app->singleton('asset', function ($app) {
            return new Asset($app);
        });
    }

    /**
     *
     */
    public function publishMigrations(): void
    {
        if (!class_exists('CreateAssetTable')) {
            $this->publishes([
                __DIR__ . '/../database/migrations/create_asset_table.php' => database_path('migrations/' . date('Y_m_d_His',

                        time()) . '_create_asset_table.php'),
            ], 'migrations');
        }
    }
}


1		<?php
2
3		namespace Thinktomorrow\AssetLibrary;
4
5		use Illuminate\Database\Eloquent\Factory as EloquentFactory;
6		use Illuminate\Routing\Router;
7		use Illuminate\Support\ServiceProvider;
8		use Thinktomorrow\AssetLibrary\Models\Asset;
9
10		class AssetLibraryServiceProvider extends ServiceProvider
11		{
12		/**
13		* Indicates if loading of the provider is deferred.
14		*
15		* @var bool
16		*/
17		protected $defer = false;
18
19		/**
20		* Perform post-registration booting of services.
21		*
22		* @return void
23		*/
24	43	public function boot()
25		{
26	43	$this->publishes([
27	43	__DIR__.'/../config/thinktomorrow/assetlibrary.php' => config_path('assetlibrary.php'),
28	43	], 'config');
29
30	43	$this->setupRoutes($this->app->router);
		0 ignored issues – show Bug introduced 2017-10-16 11:32 UTC by Report Bug Copy Issue Report Accessing `router` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
31
32	43	$this->publishMigrations();
33
34	43	$this->registerModelBindings();
35	43	$this->registerEloquentFactoriesFrom(__DIR__.'/../database/factories');
36	43	}
37
38		/**
39		* Register factories.
40		*
41		* @param string $path
42		* @return void
43		*/
44	43	protected function registerEloquentFactoriesFrom($path)
45		{
46	43	$this->app->make(EloquentFactory::class)->load($path);
47	43	}
48
49		/**
50		* Define the routes for the application.
51		*
52		* @param \Illuminate\Routing\Router $router
53		* @return void
54		*/
55		public function setupRoutes(Router $router)
56		{
57	43	$router->group(['namespace' => 'Thinktomorrow\AssetLibrary\Http\Controllers'], function ($router) {
58	43	require __DIR__.'/Http/routes.php';
59	43	});
60	43	}
61
62		/**
63		* Register any package services.
64		*
65		* @return void
66		*/
67	43	public function register()
68		{
69	43	$this->mergeConfigFrom(__DIR__.'/../config/assetlibrary.php', 'assetlibrary');
70
71	43	$this->registerAssetLibrary();
72	43	}
73
74	43	protected function registerModelBindings()
75		{
76		//TODO implement this
77	43	}
78
79		/**
80		*
81		*/
82		private function registerAssetLibrary()
83		{
84	43	$this->app->singleton('asset', function ($app) {
85		return new Asset($app);
86	43	});
87	43	}
88
89		/**
90		*
91		*/
92	43	public function publishMigrations(): void
93		{
94	43	if (!class_exists('CreateAssetTable')) {
95	1	$this->publishes([
96	1	__DIR__ . '/../database/migrations/create_asset_table.php' => database_path('migrations/' . date('Y_m_d_His',
		0 ignored issues – show Coding Style introduced 2017-10-16 11:32 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 125 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
97	1	time()) . '_create_asset_table.php'),
98	1	], 'migrations');
99		}
100	43	}
101		}
102

thinktomorrow / assetlibrary

Branch — feature/cropping (36fe5e)

AssetLibraryServiceProvider::publishMigrations() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like