Thinktomorrow\AssetLibrary\Application\DeleteAsset

Complexity

Total Complexity

10

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteAll()	0	3	1
A	delete()	0	11	4
A	remove()	0	13	5

<?php

namespace Thinktomorrow\AssetLibrary\Application;

use Thinktomorrow\AssetLibrary\Asset;
use Thinktomorrow\AssetLibrary\HasAsset;
use Thinktomorrow\AssetLibrary\Exceptions\FileNotAccessibleException;

class DeleteAsset
{
    /**
     * Removes an asset completely.
     *
     * @param $ids
     */
    public function delete($ids): void
    {
        if (is_array($ids)) {
            foreach ($ids as $id) {
                self::remove($id);

The method Thinktomorrow\AssetLibrary\Application\DeleteAsset::remove() is not static, but was called statically.

            }
        } else {
            if (! $ids) {
                return;
            }
            self::remove($ids);
        }
    }

    public function remove($id)
    {
        if (! $id) {
            return false;
        }
        $asset = Asset::find($id)->first();
        $media = $asset->media;
        foreach ($media as $file) {
            if (! is_file(public_path($file->getUrl())) || ! is_writable(public_path($file->getUrl()))) {
                throw new FileNotAccessibleException();
            }
        }
        $asset->delete();
    }

    /**
     * Removes all assets completely.
     *
     * @param $ids
     */
    public function deleteAll(HasAsset $model): void
    {
        $model->assetRelation->each->delete();

Accessing assetRelation on the interface Thinktomorrow\AssetLibrary\HasAsset suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}