Thinktomorrow\AssetLibrary\AssetHelper

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getBaseName()	0	3	1
A	getExtension()	0	3	1
A	isImage()	0	4	1
A	getHumanReadableSize()	0	5	1

<?php

namespace Thinktomorrow\AssetLibrary;

use Illuminate\Support\Str;

class AssetHelper
{
    public static function isImage(string $mimeType): bool
    {
        return Str::endsWith($mimeType, [
            'png', 'jpg', 'jpeg', 'gif', 'svg', 'webp'
        ]);
    }

    public static function getExtension(string $path): string
    {
        return pathinfo($path, PATHINFO_EXTENSION);

The expression return pathinfo($path, Thinktomorrow\AssetLibrary\PATHINFO_EXTENSION) could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public static function getHumanReadableSize(int $sizeInBytes): string
    {
        [$size, $unit] = explode(' ',  \Spatie\MediaLibrary\Support\File::getHumanReadableSize($sizeInBytes));

        return round($size) . ' ' . $unit;

$size of type string is incompatible with the type double|integer expected by parameter $num of round().

    }

    public static function getBaseName(string $path): string
    {
        return basename($path, '.'.static::getExtension($path));
    }
}