Thinktomorrow\AssetLibrary\Application\DeleteAsset

Complexity

Total Complexity

11

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

95.45%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteAll()	0	3	1
A	delete()	0	11	4
A	remove()	0	23	6

<?php

namespace Thinktomorrow\AssetLibrary\Application;

use Thinktomorrow\AssetLibrary\Asset;
use Spatie\MediaLibrary\MediaCollections\Models\Media;
use Thinktomorrow\AssetLibrary\Exceptions\FileNotAccessibleException;
use Thinktomorrow\AssetLibrary\HasAsset;

class DeleteAsset
{
    /**
     * Removes an asset completely.
     *
     * @param $ids
     */
    public function delete($ids): void
    {
        if (is_array($ids)) {
            foreach ($ids as $id) {
                self::remove($id);

The method Thinktomorrow\AssetLibrary\Application\DeleteAsset::remove() is not static, but was called statically.

            }
        } else {
            if (! $ids) {
                return;
            }
            self::remove($ids);
        }
    }

    public function remove($id)
    {
        if (! $id) {
            return false;
        }

        if (! $asset = Asset::find($id)) {
            return false;
        }

        $media = $asset->media;

        /** @var Media $file */
        foreach ($media as $file) {

            $file_path = $file->getPath();

            if (! is_file($file_path) || ! is_writable($file_path)) {
                throw new FileNotAccessibleException();
            }
        }

        $asset->delete();
    }

    /**
     * Removes all assets completely.
     *
     * @param $ids
     */
    public function deleteAll(HasAsset $model): void
    {
        $model->assetRelation->each->delete();

Accessing assetRelation on the interface Thinktomorrow\AssetLibrary\HasAsset suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}