thinkstudeo / laravel-rakshak

src/Traits/HasRakshak.php

<?php

namespace Thinkstudeo\Rakshak\Traits;

trait HasRakshak
{
    use HasRoles;

    /**
     * Route notifications for the Mail channel.
     *
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return string
     */
    public function routeNotificationForMail($notification)

The parameter $notification is not used and could be removed.

    {
        return $this->email;
    }

    /**
     * Route notifications for the Nexmo channel.
     *
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return string
     */
    public function routeNotificationForNexmo($notification)

The parameter $notification is not used and could be removed.

    {
        return $this->mobile;
    }

    /**
     * Route notifications for the Textlocal channel.
     *
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return string
     */
    public function routeNotificationForTextlocal($notification)

The parameter $notification is not used and could be removed.

    {
        return $this->mobile;
    }

    /**
     * Path to the User resource.
     *
     * @return string
     */
    public function path()
    {
        return '/'.config('rakshak.route_prefix')."/users/{$this->{$this->getRouteKeyName()}}";

It seems like getRouteKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}