Thinkstudeo\Rakshak\Http\Controllers\RolesController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	8	2
A	edit()	0	5	1
A	store()	0	21	4
A	create()	0	6	1
A	index()	0	5	1
A	update()	0	24	4
A	destroy()	0	11	2

<?php

namespace Thinkstudeo\Rakshak\Http\Controllers;

use Illuminate\Http\Request;
use Thinkstudeo\Rakshak\Ability;
use Thinkstudeo\Rakshak\Role;

class RolesController extends Controller
{
    /**
     * Validation rules.
     *
     * @param \Illuminate\Http\Request $request
     * @return mixed
     */
    protected function rules($role)
    {
        return [
            'name'        => ['required', 'unique:roles,name,'.$role->id ?: null, 'string', 'min:3', 'max:255'],
            'label'       => ['required', 'string'],
            'description' => ['required', 'string', 'max:255'],
            'active'      => ['nullable', 'boolean'],
            'abilities'   => ['nullable', 'array'],
        ];
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $roles = Role::all();

        return view('rakshak::roles.index', compact('roles'));

The expression return view('rakshak::roles.index', compact('roles')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $abilities = Ability::whereActive(1)->get();
        $role = new Role();

        return view('rakshak::roles.create', compact('abilities', 'role'));

The expression return view('rakshak::roles.create', compact('abilities', 'role')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $this->authorize('create', Role::class);

        $validated = $request->validate($this->rules($request));

        $role = Role::create(array_except($validated, ['abilities']));

The function array_except() has been deprecated: Arr::except() should be used directly instead. Will be removed in Laravel 6.0.

        if ($request->filled('abilities')) {
            foreach ($request->abilities as $ability) {
                $role->addAbility($ability['name']);
            }
        }

        if ($request->expectsJson()) {
            return response()->json(['message' => "New role {$role->name} has been created.", 'record' => $role], 201);

The expression return response()->json(array('message' => 'New role '.$role->name.' has been created.', 'record' => $role), 201) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect(route('rakshak.roles.index'))

The expression return redirect(route('rakshak.roles.index'))->with('status', 'success')->with('message', 'Role '.$role->name.' has been created.') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->with('status', 'success')
            ->with('message', "Role {$role->name} has been created.");
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  Thinkstudeo\Rakshak\Role $role

The type Thinkstudeo\Rakshak\Http\Controllers\Thinkstudeo\Rakshak\Role was not found. Did you mean Thinkstudeo\Rakshak\Role? If so, make sure to prefix the type with \.

     * @return \Illuminate\Http\Response
     */
    public function edit(Role $role)
    {
        $abilities = Ability::whereActive(true)->get();

        return view('rakshak::roles.edit', compact('role', 'abilities'));

The expression return view('rakshak::roles.edit', compact('role', 'abilities')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Thinkstudeo\Rakshak\Role $role
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Role $role)
    {
        $this->authorize('update', $role);

        $validated = $request->validate($this->rules($role));

        $role = tap($role)->update(array_except($validated, ['abilities']));

The function array_except() has been deprecated: Arr::except() should be used directly instead. Will be removed in Laravel 6.0.

        if ($request->filled('abilities')) {
            $abilityIds = [];
            foreach ($request->abilities as $ability) {
                $abilityIds[] = $ability['id'];
            }
            $role->abilities()->sync($abilityIds);
        }

        if ($request->expectsJson()) {
            return response()->json(['message' => "The role {$role->name} has been updated.", 'record' => $role], 200);

The expression return response()->json(array('message' => 'The role '.$role->name.' has been updated.', 'record' => $role), 200) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect()

The expression return redirect()->back()->with('status', 'success')->with('message', 'Role '.$role->name.' updated successfully.') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->back()
            ->with('status', 'success')
            ->with('message', "Role {$role->name} updated successfully.");
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \Thinkstudeo\Rakshak\Role $role
     * @return \Illuminate\Http\Response
     */
    public function destroy(Role $role)
    {
        $role->delete();

        if (request()->expectsJson()) {
            return response()->json(['message' => "The role {$role->name} has been deleted."], 200);

The expression return response()->json(array('message' => 'The role '.$role->name.' has been deleted.'), 200) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect(route('rakshak.roles.index'))

The expression return redirect(route('rakshak.roles.index'))->with('status', 'success')->with('message', 'Role '.$role->name.' has been deleted.') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->with('status', 'success')
            ->with('message', "Role {$role->name} has been deleted.");
    }
}