Thinkstudeo\Rakshak\Http\Controllers\RakshakSettingsController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	6	1
A	updateCache()	0	5	1
A	update()	0	22	2

<?php

namespace Thinkstudeo\Rakshak\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Cache;
use Thinkstudeo\Rakshak\RakshakSetting;

class RakshakSettingsController extends Controller
{
    /**
     * Show the form for editing the specified resource.
     *
     * @param  User $user

The type Thinkstudeo\Rakshak\Http\Controllers\User was not found. Maybe you did not declare it correctly or list all dependencies?

     * @return \Illuminate\Http\Response
     */
    public function edit()
    {
        $setting = RakshakSetting::first();
        $this->authorize('update', $setting);

        return view('rakshak::settings.edit', compact('setting'));

The expression return view('rakshak::settings.edit', compact('setting')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request)
    {
        $setting = RakshakSetting::first();
        $this->authorize('update', $setting);

        $validated = $request->validate([
            'enable_2fa' => ['required', 'boolean'],
            'channel_2fa' => ['required', 'in:email,sms'],
            'control_level_2fa' => ['required', 'in:admin,user'],
        ]);

        $setting = tap($setting)->update($validated);
        $this->updateCache($setting);

        if ($request->expectsJson()) {
            return response(['message' => 'Rakshak settings updated successfully!', 'record' => $setting], 200);
        }

        return redirect()

The expression return redirect()->back()->with('status', 'success')->with('message', 'Rakshak settings updated successfully.') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->back()
            ->with('status', 'success')
            ->with('message', 'Rakshak settings updated successfully.');
    }

    /**
     * Update the values for the cache keys.
     *
     * @param RakshakSetting $setting
     * @return void
     */
    protected function updateCache($setting)
    {
        Cache::forever('rakshak.enable_2fa', $setting->enable_2fa);
        Cache::forever('rakshak.channel_2fa', $setting->channel_2fa);
        Cache::forever('rakshak.control_level_2fa', $setting->control_level_2fa);
    }
}