Issues in AccountCharge.java (master) - Issues in master - theresasogunle/Rave-Java-Library - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

java/com/github/theresasogunle/AccountCharge.java (15 issues)

Labels

Severity

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package com.github.theresasogunle;




import static com.github.theresasogunle.Encryption.encryptData;
import org.json.JSONException;

import org.json.JSONObject;




/**
 *
 * @author Theresa
 */
public class AccountCharge {
 
    Encryption e=new Encryption();
    
    private String accountnumber,accountbank,currency,country,

               amount,email,phonenumber,firstname,lastname,IP,

               txRef,passcode,device_fingerprint;

    
    private String transaction_reference;//to be called
    private String otp;//to be called
 
    public JSONObject setJSON() {
        JSONObject json=new JSONObject();
        try{
        json.put("PBFPubKey",RaveConstant.PUBLIC_KEY);
        json.put("accountnumber",this.getAccountnumber());//expected result'
        json.put("accountbank",this.getAccountbank());
        json.put("currency", this.getCurrency());
        json.put("country", this.getCountry());
        json.put("amount", this.getAmount());
        json.put("firstname", this.getFirstname());
        json.put("lastname", this.getLastname());
        json.put("passcode", this.getPasscode());
        json.put("email", this.getEmail());
        json.put("IP", this.getIP());
        json.put("payment_type", "account");
        json.put("txRef", this.getTxRef());
        json.put("device_fingerprint", this.getDevice_fingerprint());

        }catch( JSONException ex){ex.getMessage();}
throw new Exception("Exception Message", originalException);
        return json;
   }
     

    /**
    *

    * @return json
    */ 
    
    public JSONObject chargeAccount() {
       
        JSONObject json=setJSON();
        
        
        String message= json.toString();
        
        String encrypt_secret_key=Encryption.getKey(RaveConstant.SECRET_KEY);
        String client= encryptData(message,encrypt_secret_key);

        Charge ch=new Charge();
        
        return ch.charge(client);

    }
     public JSONObject chargeAccount(boolean polling) {

       
        JSONObject json=setJSON();
        
        Polling p=new Polling();
        
        return p.handleTimeoutCharge(json);

    }
     

     public JSONObject validateAccountCharge(){
      Charge vcharge= new Charge();
     return vcharge.validateAccountCharge(this.getTransaction_reference(), this.getOtp());
    }

    
      public JSONObject validateAccountCharge(boolean polling){

      Polling p=new Polling();
      return p.validateAccountChargeTimeout(this.getTransaction_reference(),this.getOtp());
    }

    /**
     * @return the accountnumber
     */
    public String getAccountnumber() {
        return accountnumber;
    }

    /**
     * @param accountnumber the accountnumber to set
     * @return AccountCharge
     */
    public AccountCharge setAccountnumber(String accountnumber) {
        this.accountnumber = accountnumber;
        return this;
    }

    /**
     * @return the accountbank
     */
    public String getAccountbank() {
        return accountbank;
    }

    /**
     * @param accountbank the accountbank to set
     * @return AccountCharge
     */
    public AccountCharge setAccountbank(String accountbank) {
        this.accountbank = accountbank;
         return this;
    }

    /**
     * @return the currency
     */
    public String getCurrency() {
        return currency;
    }

    /**
     * @param currency the currency to set
     * @return AccountCharge
     */
    public AccountCharge setCurrency(String currency) {
        this.currency = currency;
         return this;
    }

    /**
     * @return the country
     */
    public String getCountry() {
        return country;
    }

    /**
     * @param country the country to set
     * @return AccountCharge
     */
    public AccountCharge setCountry(String country) {
        this.country = country;
         return this;
    }

    /**
     * @return the amount
     */
    public String getAmount() {
        return amount;
    }

    /**
     * @param amount the amount to set
     * @return AccountCharge
     */
    public AccountCharge setAmount(String amount) {
        this.amount = amount;
         return this;
    }

    /**
     * @return the email
     */
    public String getEmail() {
        return email;
    }

    /**
     * @param email the email to set
     * @return AccountCharge
     */
    public AccountCharge setEmail(String email) {
        this.email = email;
         return this;
    }

    /**
     * @return the phonenumber
     */
    public String getPhonenumber() {
        return phonenumber;
    }

    /**
     * @param phonenumber the phonenumber to set
     * @return AccountCharge
     */
    public AccountCharge setPhonenumber(String phonenumber) {
        this.phonenumber = phonenumber;
         return this;
    }

    /**
     * @return the firstname
     * 
     */
    public String getFirstname() {
        return firstname;
    }

    /**
     * @param firstname the firstname to set
     * @return AccountCharge
     */
    public AccountCharge setFirstname(String firstname) {
        this.firstname = firstname;
         return this;
    }

    /**
     * @return the lastname
     */
    public String getLastname() {
        return lastname;
    }

    /**
     * @param lastname the lastname to set
     * @return AccountCharge
     */
    public AccountCharge setLastname(String lastname) {
        this.lastname = lastname;
         return this;
    }

    /**
     * @return the IP
     */
    public String getIP() {
        return IP;
    }

    /**
     * @param IP the IP to set
     * @return AccountCharge
     */
    public AccountCharge setIP(String IP) {
        this.IP = IP;
         return this;
    }

    /**
     * @return the txRef
     */
    public String getTxRef() {
        return txRef;
    }

    /**
     * @param txRef the txRef to set
     * @return AccountCharge
     */
    public AccountCharge setTxRef(String txRef) {
        this.txRef = txRef;
         return this;
    }

    /**
     * @return the passcode
     */
    public String getPasscode() {
        return passcode;
    }

    /**
     * @param passcode the passcode to set
     * @return AccountCharge
     */
    public AccountCharge setPasscode(String passcode) {
        this.passcode = passcode;
         return this;
    }

    /**
     * @return the device_fingerprint
     */
    public String getDevice_fingerprint() {
        return device_fingerprint;
    }

    /**
     * @param device_fingerprint the device_fingerprint to set
     * @return AccountCharge
     */
    public AccountCharge setDevice_fingerprint(String device_fingerprint) {
        this.device_fingerprint = device_fingerprint;
         return this;
    }

    /**
     * @return the transaction_reference
     */
    public String getTransaction_reference() {
        return transaction_reference;
    }

    /**
     * @param transaction_reference the transaction_reference to set
     * @return AccountCharge
     */
    public AccountCharge setTransaction_reference(String transaction_reference) {
        this.transaction_reference = transaction_reference;
         return this;
    }

    /**
     * @return the otp
     */
    public String getOtp() {
        return otp;
    }

    /**
     * @param otp the otp to set
     * @return AccountCharge
     */
    public AccountCharge setOtp(String otp) {
        this.otp = otp;
         return this;
    }
    

    
   
    
}


1			/*
2			* To change this license header, choose License Headers in Project Properties.
3			* To change this template file, choose Tools \| Templates
4			* and open the template in the editor.
5			*/
6			package com.github.theresasogunle;
7
8
9
10
11			import static com.github.theresasogunle.Encryption.encryptData;
12			import org.json.JSONException;
13
14			import org.json.JSONObject;
15
16
17
18
19			/**
20			*
21			* @author Theresa
22			*/
23			public class AccountCharge {
24
25			Encryption e=new Encryption();
26
27			private String accountnumber,accountbank,currency,country,
			0 ignored issues – show Coding Style introduced 2018-03-14 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `currency` on a separate line. Loading history... Coding Style introduced 2018-03-14 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `country` on a separate line. Loading history... Coding Style introduced 2018-03-14 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `accountbank` on a separate line. Loading history...
28			amount,email,phonenumber,firstname,lastname,IP,
			0 ignored issues – show Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `lastname` on a separate line. Loading history... Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `IP` on a separate line. Loading history... Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `firstname` on a separate line. Loading history... Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `amount` on a separate line. Loading history... Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `email` on a separate line. Loading history... Coding Style introduced 2018-04-08 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `phonenumber` on a separate line. Loading history...
29			txRef,passcode,device_fingerprint;
			0 ignored issues – show Coding Style introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `txRef` on a separate line. Loading history... Coding Style introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `passcode` on a separate line. Loading history... Coding Style introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Declaring several variables on the same line makes your code hard to read. Consider delaring `device_fingerprint` on a separate line. Loading history...
30
31			private String transaction_reference;//to be called
32			private String otp;//to be called
33
34			public JSONObject setJSON() {
35			JSONObject json=new JSONObject();
36			try{
37			json.put("PBFPubKey",RaveConstant.PUBLIC_KEY);
38			json.put("accountnumber",this.getAccountnumber());//expected result'
39			json.put("accountbank",this.getAccountbank());
40			json.put("currency", this.getCurrency());
41			json.put("country", this.getCountry());
42			json.put("amount", this.getAmount());
43			json.put("firstname", this.getFirstname());
44			json.put("lastname", this.getLastname());
45			json.put("passcode", this.getPasscode());
46			json.put("email", this.getEmail());
47			json.put("IP", this.getIP());
48			json.put("payment_type", "account");
49			json.put("txRef", this.getTxRef());
50			json.put("device_fingerprint", this.getDevice_fingerprint());
51
52			}catch( JSONException ex){ex.getMessage();}
			0 ignored issues – show Best Practice introduced 2018-04-25 17:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Ignoring an Exception may lead to hard to find bugs. Consider logging or rethrowing the original exception. If you want to throw a different exception, you can set the original exception as its cause to preserve the stacktrace. When instantiating a new Exception, you can set another Exception as its cause. See the Oracle documentation on Throwables. Usage example throw new Exception("Exception Message", originalException); Complete Example: class ReThrowException { public static void throwsException() { try { throw new Exception("I am the original exception"); } catch (final Exception e) { throw new RuntimeException("I am the new exception", e); } } public static void main(String[] args) { try { throwsException(); } catch (final RuntimeException e) { System.out.println(e.getMessage()); System.out.println("and my cause is: " + e.getCause().getMessage()); e.printStackTrace(); } } } Loading history...
53			return json;
54			}
55
56
57			/**
58			*
59
60			* @return json
61			*/
62
63			public JSONObject chargeAccount() {
64
65			JSONObject json=setJSON();
66
67
68			String message= json.toString();
69
70			String encrypt_secret_key=Encryption.getKey(RaveConstant.SECRET_KEY);
71			String client= encryptData(message,encrypt_secret_key);
72
73			Charge ch=new Charge();
74
75			return ch.charge(client);
76
77			}
78			public JSONObject chargeAccount(boolean polling) {
			0 ignored issues – show Unused Code introduced 2018-04-25 17:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Your method has more parameters than it evaluates. Consider removing `polling`. Loading history...
79
80			JSONObject json=setJSON();
81
82			Polling p=new Polling();
83
84			return p.handleTimeoutCharge(json);
85
86			}
87
88
89			public JSONObject validateAccountCharge(){
90			Charge vcharge= new Charge();
91			return vcharge.validateAccountCharge(this.getTransaction_reference(), this.getOtp());
92			}
93
94
95			public JSONObject validateAccountCharge(boolean polling){
			0 ignored issues – show Unused Code introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Your method has more parameters than it evaluates. Consider removing `polling`. Loading history...
96			Polling p=new Polling();
97			return p.validateAccountChargeTimeout(this.getTransaction_reference(),this.getOtp());
98			}
99
100			/**
101			* @return the accountnumber
102			*/
103			public String getAccountnumber() {
104			return accountnumber;
105			}
106
107			/**
108			* @param accountnumber the accountnumber to set
109			* @return AccountCharge
110			*/
111			public AccountCharge setAccountnumber(String accountnumber) {
112			this.accountnumber = accountnumber;
113			return this;
114			}
115
116			/**
117			* @return the accountbank
118			*/
119			public String getAccountbank() {
120			return accountbank;
121			}
122
123			/**
124			* @param accountbank the accountbank to set
125			* @return AccountCharge
126			*/
127			public AccountCharge setAccountbank(String accountbank) {
128			this.accountbank = accountbank;
129			return this;
130			}
131
132			/**
133			* @return the currency
134			*/
135			public String getCurrency() {
136			return currency;
137			}
138
139			/**
140			* @param currency the currency to set
141			* @return AccountCharge
142			*/
143			public AccountCharge setCurrency(String currency) {
144			this.currency = currency;
145			return this;
146			}
147
148			/**
149			* @return the country
150			*/
151			public String getCountry() {
152			return country;
153			}
154
155			/**
156			* @param country the country to set
157			* @return AccountCharge
158			*/
159			public AccountCharge setCountry(String country) {
160			this.country = country;
161			return this;
162			}
163
164			/**
165			* @return the amount
166			*/
167			public String getAmount() {
168			return amount;
169			}
170
171			/**
172			* @param amount the amount to set
173			* @return AccountCharge
174			*/
175			public AccountCharge setAmount(String amount) {
176			this.amount = amount;
177			return this;
178			}
179
180			/**
181			* @return the email
182			*/
183			public String getEmail() {
184			return email;
185			}
186
187			/**
188			* @param email the email to set
189			* @return AccountCharge
190			*/
191			public AccountCharge setEmail(String email) {
192			this.email = email;
193			return this;
194			}
195
196			/**
197			* @return the phonenumber
198			*/
199			public String getPhonenumber() {
200			return phonenumber;
201			}
202
203			/**
204			* @param phonenumber the phonenumber to set
205			* @return AccountCharge
206			*/
207			public AccountCharge setPhonenumber(String phonenumber) {
208			this.phonenumber = phonenumber;
209			return this;
210			}
211
212			/**
213			* @return the firstname
214			*
215			*/
216			public String getFirstname() {
217			return firstname;
218			}
219
220			/**
221			* @param firstname the firstname to set
222			* @return AccountCharge
223			*/
224			public AccountCharge setFirstname(String firstname) {
225			this.firstname = firstname;
226			return this;
227			}
228
229			/**
230			* @return the lastname
231			*/
232			public String getLastname() {
233			return lastname;
234			}
235
236			/**
237			* @param lastname the lastname to set
238			* @return AccountCharge
239			*/
240			public AccountCharge setLastname(String lastname) {
241			this.lastname = lastname;
242			return this;
243			}
244
245			/**
246			* @return the IP
247			*/
248			public String getIP() {
249			return IP;
250			}
251
252			/**
253			* @param IP the IP to set
254			* @return AccountCharge
255			*/
256			public AccountCharge setIP(String IP) {
257			this.IP = IP;
258			return this;
259			}
260
261			/**
262			* @return the txRef
263			*/
264			public String getTxRef() {
265			return txRef;
266			}
267
268			/**
269			* @param txRef the txRef to set
270			* @return AccountCharge
271			*/
272			public AccountCharge setTxRef(String txRef) {
273			this.txRef = txRef;
274			return this;
275			}
276
277			/**
278			* @return the passcode
279			*/
280			public String getPasscode() {
281			return passcode;
282			}
283
284			/**
285			* @param passcode the passcode to set
286			* @return AccountCharge
287			*/
288			public AccountCharge setPasscode(String passcode) {
289			this.passcode = passcode;
290			return this;
291			}
292
293			/**
294			* @return the device_fingerprint
295			*/
296			public String getDevice_fingerprint() {
297			return device_fingerprint;
298			}
299
300			/**
301			* @param device_fingerprint the device_fingerprint to set
302			* @return AccountCharge
303			*/
304			public AccountCharge setDevice_fingerprint(String device_fingerprint) {
305			this.device_fingerprint = device_fingerprint;
306			return this;
307			}
308
309			/**
310			* @return the transaction_reference
311			*/
312			public String getTransaction_reference() {
313			return transaction_reference;
314			}
315
316			/**
317			* @param transaction_reference the transaction_reference to set
318			* @return AccountCharge
319			*/
320			public AccountCharge setTransaction_reference(String transaction_reference) {
321			this.transaction_reference = transaction_reference;
322			return this;
323			}
324
325			/**
326			* @return the otp
327			*/
328			public String getOtp() {
329			return otp;
330			}
331
332			/**
333			* @param otp the otp to set
334			* @return AccountCharge
335			*/
336			public AccountCharge setOtp(String otp) {
337			this.otp = otp;
338			return this;
339			}
340
341
342
343
344
345			}
346

theresasogunle / Rave-Java-Library

Issues (164)

java/com/github/theresasogunle/AccountCharge.java (15 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like