Issues in Encryption.java (master) - Issues in master - theresasogunle/Rave-Java-Library - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

java/com/github/theresasogunle/Encryption.java (14 issues)

Labels

Severity

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package com.github.theresasogunle;

import java.io.UnsupportedEncodingException;
import java.security.InvalidKeyException;
import java.security.MessageDigest;
import java.util.Arrays;
import java.security.NoSuchAlgorithmException;
import java.util.Base64;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.crypto.BadPaddingException;
import javax.crypto.Cipher;
import javax.crypto.IllegalBlockSizeException;
import javax.crypto.NoSuchPaddingException;
import javax.crypto.SecretKey;
import javax.crypto.spec.SecretKeySpec;
import org.json.JSONObject;
/**
 *
 * @author Theresa
 */


public class Encryption {
   
   
    RaveConstant keys= new RaveConstant();
   
        
    // Method to turn bytes in hex
    public static String toHexStr(byte[] bytes){

        StringBuilder builder = new StringBuilder();

        for(int i = 0; i < bytes.length; i++ ){
            builder.append(String.format("%02x", bytes[i]));
        }

        return builder.toString();
    }

    // this is the getKey function that generates an encryption Key for you by passing your Secret Key as a parameter.
    public static String getKey(String seedKey) {
        try {
            MessageDigest md = MessageDigest.getInstance("md5");
            byte[] hashedString = md.digest(seedKey.getBytes("utf-8"));
            byte[] subHashString = toHexStr(Arrays.copyOfRange(hashedString, hashedString.length - 12, hashedString.length)).getBytes("utf-8");

            String subSeedKey = seedKey.replace("FLWSECK-", "");
            subSeedKey = subSeedKey.substring(0, 12);

            byte[] combineArray = new byte[24];

            System.arraycopy(subSeedKey.getBytes(), 0, combineArray, 0, 12);

            System.arraycopy(subHashString, subHashString.length - 12, combineArray, 12, 12);

            return new String(combineArray);

        } catch (NoSuchAlgorithmException | UnsupportedEncodingException ex) {
            Logger.getGlobal().log(Level.SEVERE, null, ex);
        }
        return null;
    }

    // This is the encryption function that encrypts your payload by passing the stringified format and your encryption Key.
    public static String encryptData(String message, String _encryptionKey)  {
        try {
            final byte[] digestOfPassword = _encryptionKey.getBytes("utf-8");
            final byte[] keyBytes = Arrays.copyOf(digestOfPassword, 24);


            final SecretKey key = new SecretKeySpec( keyBytes , "DESede");
            final Cipher cipher = Cipher.getInstance("DESede/ECB/PKCS5Padding");

            cipher.init(Cipher.ENCRYPT_MODE, key);
            final byte[] plainTextBytes = message.getBytes("utf-8");
            final byte[] cipherText = cipher.doFinal(plainTextBytes);
            return Base64.getEncoder().encodeToString(cipherText);

        } catch (UnsupportedEncodingException | NoSuchAlgorithmException | NoSuchPaddingException | InvalidKeyException | IllegalBlockSizeException | BadPaddingException e) {
throw new Exception("Exception Message", originalException);

          
            return "";
        }
        
    }

    /**
    *
    * @param api(JSON object)
    * @return String
    */
    
    public String encryptParameters(JSONObject api) {
           
        try{
            api.put("PBFPubKey",RaveConstant.PUBLIC_KEY);
        }catch(Exception ex){}
throw new Exception("Exception Message", originalException);
        
      
        
        String message= api.toString();
        
        String encrypt_secret_key=getKey(RaveConstant.SECRET_KEY);
        String encrypted_message= encryptData(message,encrypt_secret_key);


        return encrypted_message;

    }
 /**
    *
    * 
    * @return String
    * @param api 
    * 
    */
    

    public String encryptParametersPreAuth(JSONObject api){
           
        try{
            api.put("PBFPubKey","FLWPUBK-8cd258c49f38e05292e5472b2b15906e-X");
        }catch(Exception ex){}
throw new Exception("Exception Message", originalException);
        
        String message= api.toString();
        
        
        
        String encrypt_secret_key=getKey("FLWSECK-c51891678d48c39eff3701ff686bdb69-X");
        String encrypted_message= encryptData(message,encrypt_secret_key);

      
        return encrypted_message;

    }
        
       
    
}


1			/*
2			* To change this license header, choose License Headers in Project Properties.
3			* To change this template file, choose Tools \| Templates
4			* and open the template in the editor.
5			*/
6			package com.github.theresasogunle;
7
8			import java.io.UnsupportedEncodingException;
9			import java.security.InvalidKeyException;
10			import java.security.MessageDigest;
11			import java.util.Arrays;
12			import java.security.NoSuchAlgorithmException;
13			import java.util.Base64;
14			import java.util.logging.Level;
15			import java.util.logging.Logger;
16			import javax.crypto.BadPaddingException;
17			import javax.crypto.Cipher;
18			import javax.crypto.IllegalBlockSizeException;
19			import javax.crypto.NoSuchPaddingException;
20			import javax.crypto.SecretKey;
21			import javax.crypto.spec.SecretKeySpec;
22			import org.json.JSONObject;
23			/**
24			*
25			* @author Theresa
26			*/
27
28
29			public class Encryption {
30
31
32			RaveConstant keys= new RaveConstant();
33
34
35			// Method to turn bytes in hex
36			public static String toHexStr(byte[] bytes){
37
38			StringBuilder builder = new StringBuilder();
39
40			for(int i = 0; i < bytes.length; i++ ){
41			builder.append(String.format("%02x", bytes[i]));
42			}
43
44			return builder.toString();
45			}
46
47			// this is the getKey function that generates an encryption Key for you by passing your Secret Key as a parameter.
48			public static String getKey(String seedKey) {
49			try {
50			MessageDigest md = MessageDigest.getInstance("md5");
51			byte[] hashedString = md.digest(seedKey.getBytes("utf-8"));
52			byte[] subHashString = toHexStr(Arrays.copyOfRange(hashedString, hashedString.length - 12, hashedString.length)).getBytes("utf-8");
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 12 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
53			String subSeedKey = seedKey.replace("FLWSECK-", "");
54			subSeedKey = subSeedKey.substring(0, 12);
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 12 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
55			byte[] combineArray = new byte[24];
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 24 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
56			System.arraycopy(subSeedKey.getBytes(), 0, combineArray, 0, 12);
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 12 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history... Bug introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Remove this use of "getBytes" Loading history...
57			System.arraycopy(subHashString, subHashString.length - 12, combineArray, 12, 12);
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 12 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
58			return new String(combineArray);
			0 ignored issues – show Bug introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Classes and methods like String(byte[]) that rely on the default system encoding should not be used. Loading history...
59			} catch (NoSuchAlgorithmException \| UnsupportedEncodingException ex) {
60			Logger.getGlobal().log(Level.SEVERE, null, ex);
61			}
62			return null;
63			}
64
65			// This is the encryption function that encrypts your payload by passing the stringified format and your encryption Key.
66			public static String encryptData(String message, String _encryptionKey) {
67			try {
68			final byte[] digestOfPassword = _encryptionKey.getBytes("utf-8");
69			final byte[] keyBytes = Arrays.copyOf(digestOfPassword, 24);
			0 ignored issues – show Comprehensibility introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider assigning this magic number 24 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
70
71			final SecretKey key = new SecretKeySpec( keyBytes , "DESede");
72			final Cipher cipher = Cipher.getInstance("DESede/ECB/PKCS5Padding");
			0 ignored issues – show Security introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The DES and DESede (3DES) are no longer considered secure, because they can be brute-forced with modern computers. Consider using a more secure method like AES. Loading history...
73			cipher.init(Cipher.ENCRYPT_MODE, key);
74			final byte[] plainTextBytes = message.getBytes("utf-8");
75			final byte[] cipherText = cipher.doFinal(plainTextBytes);
76			return Base64.getEncoder().encodeToString(cipherText);
77
78			} catch (UnsupportedEncodingException \| NoSuchAlgorithmException \| NoSuchPaddingException \| InvalidKeyException \| IllegalBlockSizeException \| BadPaddingException e) {
			0 ignored issues – show Best Practice introduced 2018-03-14 16:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Ignoring an Exception may lead to hard to find bugs. Consider logging or rethrowing the original exception. If you want to throw a different exception, you can set the original exception as its cause to preserve the stacktrace. When instantiating a new Exception, you can set another Exception as its cause. See the Oracle documentation on Throwables. Usage example throw new Exception("Exception Message", originalException); Complete Example: class ReThrowException { public static void throwsException() { try { throw new Exception("I am the original exception"); } catch (final Exception e) { throw new RuntimeException("I am the new exception", e); } } public static void main(String[] args) { try { throwsException(); } catch (final RuntimeException e) { System.out.println(e.getMessage()); System.out.println("and my cause is: " + e.getCause().getMessage()); e.printStackTrace(); } } } Loading history...
79
80
81			return "";
82			}
83
84			}
85
86			/**
87			*
88			* @param api(JSON object)
89			* @return String
90			*/
91
92			public String encryptParameters(JSONObject api) {
93
94			try{
95			api.put("PBFPubKey",RaveConstant.PUBLIC_KEY);
96			}catch(Exception ex){}
			0 ignored issues – show Bug introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider removing the empty block or filling it with code. You can also add a comment to explain the empty block. Loading history... Best Practice introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Ignoring an Exception may lead to hard to find bugs. Consider logging or rethrowing the original exception. If you want to throw a different exception, you can set the original exception as its cause to preserve the stacktrace. When instantiating a new Exception, you can set another Exception as its cause. See the Oracle documentation on Throwables. Usage example throw new Exception("Exception Message", originalException); Complete Example: class ReThrowException { public static void throwsException() { try { throw new Exception("I am the original exception"); } catch (final Exception e) { throw new RuntimeException("I am the new exception", e); } } public static void main(String[] args) { try { throwsException(); } catch (final RuntimeException e) { System.out.println(e.getMessage()); System.out.println("and my cause is: " + e.getCause().getMessage()); e.printStackTrace(); } } } Loading history...
97
98
99
100			String message= api.toString();
101
102			String encrypt_secret_key=getKey(RaveConstant.SECRET_KEY);
103			String encrypted_message= encryptData(message,encrypt_secret_key);
104
105
106			return encrypted_message;
107
108			}
109			/**
110			*
111			*
112			* @return String
113			* @param api
114			*
115			*/
116
117
118			public String encryptParametersPreAuth(JSONObject api){
119
120			try{
121			api.put("PBFPubKey","FLWPUBK-8cd258c49f38e05292e5472b2b15906e-X");
122			}catch(Exception ex){}
			0 ignored issues – show Best Practice introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Ignoring an Exception may lead to hard to find bugs. Consider logging or rethrowing the original exception. If you want to throw a different exception, you can set the original exception as its cause to preserve the stacktrace. When instantiating a new Exception, you can set another Exception as its cause. See the Oracle documentation on Throwables. Usage example throw new Exception("Exception Message", originalException); Complete Example: class ReThrowException { public static void throwsException() { try { throw new Exception("I am the original exception"); } catch (final Exception e) { throw new RuntimeException("I am the new exception", e); } } public static void main(String[] args) { try { throwsException(); } catch (final RuntimeException e) { System.out.println(e.getMessage()); System.out.println("and my cause is: " + e.getCause().getMessage()); e.printStackTrace(); } } } Loading history... Bug introduced 2018-03-14 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider removing the empty block or filling it with code. You can also add a comment to explain the empty block. Loading history...
123
124			String message= api.toString();
125
126
127
128			String encrypt_secret_key=getKey("FLWSECK-c51891678d48c39eff3701ff686bdb69-X");
129			String encrypted_message= encryptData(message,encrypt_secret_key);
130
131
132			return encrypted_message;
133
134			}
135
136
137
138			}
139

theresasogunle / Rave-Java-Library

Issues (164)

java/com/github/theresasogunle/Encryption.java (14 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like