TransactionMiddleware::rollbackTransaction() - Code Metrics - Inspection of "Extract entity manager close from TransactionMiddl..." - thephpleague/tactician-doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

unknown

created 2018-03-26 18:40 UTC

TransactionMiddleware::rollbackTransaction() A

↳ Parent: Project

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	3
eloc	5
nc	2
nop	0

<?php
namespace League\Tactician\Doctrine\ORM;

use Doctrine\ORM\EntityManagerInterface;
use League\Tactician\Middleware;
use Exception;
use Throwable;

/**
 * Wraps command execution inside a Doctrine ORM transaction
 */
class TransactionMiddleware implements Middleware

{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;

    /**
     * @param EntityManagerInterface $entityManager
     */
    public function __construct(EntityManagerInterface $entityManager)
    {
        $this->entityManager = $entityManager;
    }

    /**
     * Executes the given command and optionally returns a value
     *
     * @param object $command
     * @param callable $next
     * @return mixed
     * @throws Throwable
     * @throws Exception
     */
    public function execute($command, callable $next)
    {
        $this->entityManager->beginTransaction();

        try {
            $returnValue = $next($command);

            $this->entityManager->flush();
            $this->entityManager->commit();
        } catch (Exception $e) {
            $this->entityManager->rollback();

            throw $e;
        } catch (Throwable $e) {

            $this->entityManager->rollback();

            throw $e;
        }

        return $returnValue;
    }
}


1		<?php
2		namespace League\Tactician\Doctrine\ORM;
3
4		use Doctrine\ORM\EntityManagerInterface;
5		use League\Tactician\Middleware;
6		use Exception;
7		use Throwable;
8
9		/**
10		* Wraps command execution inside a Doctrine ORM transaction
11		*/
12	View Code Duplication	class TransactionMiddleware implements Middleware
		0 ignored issues – show Duplication introduced 2018-01-12 16:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* @var EntityManagerInterface
16		*/
17		private $entityManager;
18
19		/**
20		* @param EntityManagerInterface $entityManager
21		*/
22		public function __construct(EntityManagerInterface $entityManager)
23		{
24		$this->entityManager = $entityManager;
25		}
26
27		/**
28		* Executes the given command and optionally returns a value
29		*
30		* @param object $command
31		* @param callable $next
32		* @return mixed
33		* @throws Throwable
34		* @throws Exception
35		*/
36		public function execute($command, callable $next)
37		{
38		$this->entityManager->beginTransaction();
39
40		try {
41		$returnValue = $next($command);
42
43		$this->entityManager->flush();
44		$this->entityManager->commit();
45		} catch (Exception $e) {
46		$this->entityManager->rollback();
47
48		throw $e;
49		} catch (Throwable $e) {
		0 ignored issues – show Bug introduced 2016-02-20 11:32 UTC by Report Bug Copy Issue Report The class `Throwable` does not exist. Is this class maybe located in a folder that is not analyzed, or in a newer version of your dependencies than listed in your composer.lock/composer.json? Loading history...
50		$this->entityManager->rollback();
51
52		throw $e;
53		}
54
55		return $returnValue;
56		}
57		}
58

thephpleague / tactician-doctrine

Pull Request — master (#20)

TransactionMiddleware::rollbackTransaction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like