SecurityMiddlewareTest::testAccessIsGranted() - Code Metrics - thephpleague/tactician-bundle - Measure and Improve Code Quality continuously with Scrutinizer

SecurityMiddlewareTest::testAccessIsGranted() A
last analyzed 2021-02-10 14:38 UTC

↳ Parent: SecurityMiddlewareTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace League\Tactician\Bundle\Tests\Middleware;

use League\Tactician\Bundle\Middleware\SecurityMiddleware;
use League\Tactician\Bundle\Tests\Fake\FakeCommand;
use Mockery;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * Unit test for the security middleware.
 *
 * @author Ron Rademaker
 */
class SecurityMiddlewareTest extends TestCase
{
    /**
     * Authorization checker mock.
     */
    private $authorizationChecker;

    /**
     * Set up.
     */
    public function setUp(): void
    {
        $this->authorizationChecker = Mockery::mock(AuthorizationCheckerInterface::class);
    }

    /**
     * Tests the command is handled if access is granted.
     */
    public function testAccessIsGranted()
    {
        $this->authorizationChecker->shouldReceive('isGranted')->andReturn(true);
        $middleware = new SecurityMiddleware($this->authorizationChecker);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $handled = false;
        $middleware->execute(new FakeCommand(), function () use(&$handled) {
            $handled = true;
        });

        $this->assertTrue($handled);
    }

    /**
     * Tests the command is not handled if access is denied and an AccessDenied exception is thrown.
     */
    public function testAccessIsNotGranted()
    {
        $this->expectException(AccessDeniedException::class);
        $this->authorizationChecker->shouldReceive('isGranted')->andReturn(false);
        $middleware = new SecurityMiddleware($this->authorizationChecker);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $handled = false;
        $middleware->execute(new FakeCommand(), function () use(&$handled) {
            $handled = true;
        });

        $this->assertFalse($handled);
    }
}


1			<?php
2
3			namespace League\Tactician\Bundle\Tests\Middleware;
4
5			use League\Tactician\Bundle\Middleware\SecurityMiddleware;
6			use League\Tactician\Bundle\Tests\Fake\FakeCommand;
7			use Mockery;
8			use PHPUnit\Framework\TestCase;
9			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
10			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
11
12			/**
13			* Unit test for the security middleware.
14			*
15			* @author Ron Rademaker
16			*/
17			class SecurityMiddlewareTest extends TestCase
18			{
19			/**
20			* Authorization checker mock.
21			*/
22			private $authorizationChecker;
23
24			/**
25			* Set up.
26			*/
27			public function setUp(): void
28			{
29			$this->authorizationChecker = Mockery::mock(AuthorizationCheckerInterface::class);
30			}
31
32			/**
33			* Tests the command is handled if access is granted.
34			*/
35			public function testAccessIsGranted()
36			{
37			$this->authorizationChecker->shouldReceive('isGranted')->andReturn(true);
38			$middleware = new SecurityMiddleware($this->authorizationChecker);
			0 ignored issues – show Documentation introduced 2019-10-07 12:55 UTC by Report Bug Copy Issue Report `$this->authorizationChecker` is of type `object<Mockery\LegacyMockInterface>`, but the function expects a `object<Symfony\Component...zationCheckerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			$handled = false;
40			$middleware->execute(new FakeCommand(), function () use(&$handled) {
41			$handled = true;
42			});
43
44			$this->assertTrue($handled);
45			}
46
47			/**
48			* Tests the command is not handled if access is denied and an AccessDenied exception is thrown.
49			*/
50			public function testAccessIsNotGranted()
51			{
52			$this->expectException(AccessDeniedException::class);
53			$this->authorizationChecker->shouldReceive('isGranted')->andReturn(false);
54			$middleware = new SecurityMiddleware($this->authorizationChecker);
			0 ignored issues – show Documentation introduced 2019-10-07 12:55 UTC by Report Bug Copy Issue Report `$this->authorizationChecker` is of type `object<Mockery\LegacyMockInterface>`, but the function expects a `object<Symfony\Component...zationCheckerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			$handled = false;
56			$middleware->execute(new FakeCommand(), function () use(&$handled) {
57			$handled = true;
58			});
59
60			$this->assertFalse($handled);
61			}
62			}
63

thephpleague / tactician-bundle

SecurityMiddlewareTest::testAccessIsGranted() A last analyzed 2021-02-10 14:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SecurityMiddlewareTest::testAccessIsGranted() A
last analyzed 2021-02-10 14:38 UTC