League\Route\Strategy\RequestResponseJsonStrategy::dispatch()

Complexity

Conditions	6
Paths	1

Size

Total Lines	32
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function dispatch(callable $controller, array $vars, Route $route = null)
    {
        $middleware = function (
            ServerRequestInterface $request, ResponseInterface $response, callable $next
        ) use (
            $controller, $vars
        ) {
            try {
                $result = call_user_func_array($controller, [$request, $response, $vars]);

                if (is_array($result) || $result instanceof ArrayObject) {
                    $body     = json_encode($result);
                    $response = $this->getResponse();

                    if ($response->getBody()->isWritable()) {
                        $response->getBody()->write($body);
                    }
                }

                if ($response instanceof ResponseInterface) {
                    $response = $response->withAddedHeader('content-type', 'application/json');
                    return $next($request, $response);
                }
            } catch (HttpException $e) {
                return $e->buildJsonResponse($this->getResponse());
            }

            throw new RuntimeException('Unable to build a json response from controller return value.');
        };

        return $route->getMiddlewareRunner()->run($middleware, $this->getRequest(), $this->getResponse());

It seems like $route is not always an object, but can also be of type null. Maybe add an additional type check?

    }
}