MiddlewareAwareTrait::shiftMiddleware() - Code Metrics - Inspection of "Hotfix/209" - thephpleague/route - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#246)

by Derek Stephen

created 2019-06-23 15:30 UTC

MiddlewareAwareTrait::shiftMiddleware() A

↳ Parent: MiddlewareAwareTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	4
cts	5
cp	0.8
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2.032

<?php declare(strict_types=1);

namespace League\Route\Middleware;

use OutOfBoundsException;
use Psr\Http\Server\MiddlewareInterface;

trait MiddlewareAwareTrait
{
    /**
     * @var \Psr\Http\Server\MiddlewareInterface[]
     */
    protected $middleware = [];

    /**
     * {@inheritdoc}
     */
    public function middleware(MiddlewareInterface $middleware) : MiddlewareAwareInterface
    {
        $this->middleware[] = $middleware;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function middlewares(array $middlewares) : MiddlewareAwareInterface
    {
        foreach ($middlewares as $middleware) {
            $this->middleware($middleware);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function prependMiddleware(MiddlewareInterface $middleware) : MiddlewareAwareInterface
    {
        array_unshift($this->middleware, $middleware);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function shiftMiddleware() : MiddlewareInterface
    {
        $middleware =  array_shift($this->middleware);

        if (is_null($middleware)) {
            throw new OutOfBoundsException('Reached end of middleware stack. Does your controller return a response?');
        }

        return $middleware;
    }

    /**
     * {@inheritdoc}
     */
    public function getMiddlewareStack() : iterable
    {
        return $this->middleware;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace League\Route\Middleware;
4
5		use OutOfBoundsException;
6		use Psr\Http\Server\MiddlewareInterface;
7
8		trait MiddlewareAwareTrait
9		{
10		/**
11		* @var \Psr\Http\Server\MiddlewareInterface[]
12		*/
13		protected $middleware = [];
14
15		/**
16		* {@inheritdoc}
17		*/
18	16	public function middleware(MiddlewareInterface $middleware) : MiddlewareAwareInterface
19		{
20	16	$this->middleware[] = $middleware;
21
22	16	return $this;
23		}
24
25		/**
26		* {@inheritdoc}
27		*/
28	32	public function middlewares(array $middlewares) : MiddlewareAwareInterface
29		{
30	32	foreach ($middlewares as $middleware) {
31	4	$this->middleware($middleware);
32		}
33
34	32	return $this;
35		}
36
37		/**
38		* {@inheritdoc}
39		*/
40	30	public function prependMiddleware(MiddlewareInterface $middleware) : MiddlewareAwareInterface
41		{
42	30	array_unshift($this->middleware, $middleware);
43
44	30	return $this;
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	30	public function shiftMiddleware() : MiddlewareInterface
51		{
52	30	$middleware = array_shift($this->middleware);
53
54	30	if (is_null($middleware)) {
55		throw new OutOfBoundsException('Reached end of middleware stack. Does your controller return a response?');
56		}
57
58	30	return $middleware;
59		}
60
61		/**
62		* {@inheritdoc}
63		*/
64	32	public function getMiddlewareStack() : iterable
65		{
66	32	return $this->middleware;
67		}
68		}
69

thephpleague / route

Pull Request — master (#246)

MiddlewareAwareTrait::shiftMiddleware() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like