folders.php ➔ stripFoldersNormalizeName() - Code Metrics - Inspection of "Normalize Name" - thephpleague/plates - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — normalize-name ( b03306 )

unknown

created 2018-01-10 07:18 UTC

folders.php ➔ stripFoldersNormalizeName() A

↳ Parent: Project

Complexity

Conditions	4
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	1
nop	2
dl	0
loc	13
rs	9.2
c	0
b	0
f	0

<?php

namespace League\Plates\Extension\Folders;

use League\Plates;
use League\Plates\Extension\Path\ResolvePathArgs;

function foldersResolvePath(array $folders, $sep = '::', $file_exists = 'file_exists') {
    return function(ResolvePathArgs $args, $next) use ($folders, $sep, $file_exists) {
        if (strpos($args->path, $sep) === false) {
            return $next($args);
        }

        list($folder, $name) = explode($sep, $args->path);
        if (!isset($folders[$folder])) {
            return $next($args);
        }
        $folder_struct = $folders[$folder];

        foreach ($folder_struct['prefixes'] as $prefix) {
            $path = $next($args->withPath(
                Plates\Util\joinPath([$prefix, $name])
            ));

            // no need to check if file exists if we only have prefix
            if (count($folder_struct['prefixes']) == 1 || $file_exists($path)) {
                return $path;
            }
        }

        // none of the paths matched, just return what we have.
        return $path;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    };
}

function stripFoldersNormalizeName(array $folders, $sep = '::') {
    return function($name) use ($folders, $sep) {
        foreach ($folders as $folder) {
            foreach (array_filter($folder['prefixes']) as $prefix) {
                if (strpos($name, $prefix) === 0) {
                    return $folder['folder'] . $sep . substr($name, strlen($prefix) + 1);
                }
            }
        }

        return $name;
    };
}


1			<?php
2
3			namespace League\Plates\Extension\Folders;
4
5			use League\Plates;
6			use League\Plates\Extension\Path\ResolvePathArgs;
7
8			function foldersResolvePath(array $folders, $sep = '::', $file_exists = 'file_exists') {
9			return function(ResolvePathArgs $args, $next) use ($folders, $sep, $file_exists) {
10			if (strpos($args->path, $sep) === false) {
11			return $next($args);
12			}
13
14			list($folder, $name) = explode($sep, $args->path);
15			if (!isset($folders[$folder])) {
16			return $next($args);
17			}
18			$folder_struct = $folders[$folder];
19
20			foreach ($folder_struct['prefixes'] as $prefix) {
21			$path = $next($args->withPath(
22			Plates\Util\joinPath([$prefix, $name])
23			));
24
25			// no need to check if file exists if we only have prefix
26			if (count($folder_struct['prefixes']) == 1 \|\| $file_exists($path)) {
27			return $path;
28			}
29			}
30
31			// none of the paths matched, just return what we have.
32			return $path;
			0 ignored issues – show Bug introduced 2018-01-08 21:54 UTC by Report Bug Copy Issue Report The variable `$path` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
33			};
34			}
35
36			function stripFoldersNormalizeName(array $folders, $sep = '::') {
37			return function($name) use ($folders, $sep) {
38			foreach ($folders as $folder) {
39			foreach (array_filter($folder['prefixes']) as $prefix) {
40			if (strpos($name, $prefix) === 0) {
41			return $folder['folder'] . $sep . substr($name, strlen($prefix) + 1);
42			}
43			}
44			}
45
46			return $name;
47			};
48			}
49

thephpleague / plates

Push — normalize-name ( b03306 )

folders.php ➔ stripFoldersNormalizeName() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like