Complex classes like Period often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Period, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
33 | final class Period implements JsonSerializable |
||
34 | { |
||
35 | private const ISO8601_FORMAT = 'Y-m-d\TH:i:s.u\Z'; |
||
36 | |||
37 | /** |
||
38 | * The starting included datepoint. |
||
39 | * |
||
40 | * @var DateTimeImmutable |
||
41 | */ |
||
42 | private $startDate; |
||
43 | |||
44 | /** |
||
45 | * The ending excluded datepoint. |
||
46 | * |
||
47 | * @var DateTimeImmutable |
||
48 | */ |
||
49 | private $endDate; |
||
50 | |||
51 | 3 | /** |
|
52 | * @inheritdoc |
||
53 | 3 | */ |
|
54 | public static function __set_state(array $interval) |
||
58 | |||
59 | /** |
||
60 | * Creates a new instance. |
||
61 | * |
||
62 | * @param mixed $startDate the starting included datepoint |
||
63 | * @param mixed $endDate the ending excluded datepoint |
||
64 | 255 | * |
|
65 | * @throws Exception If $startDate is greater than $endDate |
||
66 | 255 | */ |
|
67 | 255 | public function __construct($startDate, $endDate) |
|
77 | |||
78 | /** |
||
79 | * Returns the starting included datepoint. |
||
80 | */ |
||
81 | public function getStartDate(): DateTimeImmutable |
||
85 | 246 | ||
86 | /** |
||
87 | * Returns the ending excluded datepoint. |
||
88 | 222 | */ |
|
89 | 78 | public function getEndDate(): DateTimeImmutable |
|
93 | |||
94 | /** |
||
95 | * Returns the instance duration as expressed in seconds. |
||
96 | */ |
||
97 | public function getTimestampInterval(): float |
||
101 | |||
102 | /** |
||
103 | * Returns the instance duration as a DateInterval object. |
||
104 | 6 | */ |
|
105 | public function getDateInterval(): DateInterval |
||
109 | |||
110 | 3 | /** |
|
111 | * Allows iteration over a set of dates and times, |
||
112 | * recurring at regular intervals, over the instance. |
||
113 | * |
||
114 | * @see http://php.net/manual/en/dateperiod.construct.php |
||
115 | */ |
||
116 | public function getDatePeriod($duration, int $option = 0): DatePeriod |
||
120 | |||
121 | /** |
||
122 | * Allows iteration over a set of dates and times, |
||
123 | * recurring at regular intervals, over the instance backwards starting from |
||
124 | * the instance ending datepoint. |
||
125 | */ |
||
126 | public function getDatePeriodBackwards($duration, int $option = 0): iterable |
||
139 | |||
140 | /** |
||
141 | * Returns the string representation as a ISO8601 interval format. |
||
142 | * |
||
143 | * @see https://en.wikipedia.org/wiki/ISO_8601#Time_intervals |
||
144 | * |
||
145 | * @return string |
||
146 | */ |
||
147 | public function __toString() |
||
153 | |||
154 | /** |
||
155 | 165 | * Returns the JSON representation of an instance. |
|
156 | 30 | * |
|
157 | * Based on the JSON representation of dates as |
||
158 | * returned by Javascript Date.toJSON() method. |
||
159 | 153 | * |
|
160 | * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toJSON |
||
161 | * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString |
||
162 | * |
||
163 | * @return array<string> |
||
164 | */ |
||
165 | public function jsonSerialize() |
||
174 | |||
175 | /** |
||
176 | * Returns the mathematical representation of an instance as a left close, right open interval. |
||
177 | 24 | * |
|
178 | * @see https://en.wikipedia.org/wiki/Interval_(mathematics)#Notations_for_intervals |
||
179 | 24 | * @see https://php.net/manual/en/function.date.php |
|
180 | * @see https://www.postgresql.org/docs/9.3/static/rangetypes.html |
||
181 | 24 | * |
|
182 | * @param string $format the format of the outputted date string |
||
183 | */ |
||
184 | public function format(string $format): string |
||
188 | |||
189 | /** |
||
190 | * Compares two instances according to their duration. |
||
191 | 18 | * |
|
192 | * Returns: |
||
193 | 18 | * <ul> |
|
194 | 15 | * <li> -1 if the current Interval is lesser than the submitted Interval object</li> |
|
195 | * <li> 1 if the current Interval is greater than the submitted Interval object</li> |
||
196 | 15 | * <li> 0 if both Interval objects have the same duration</li> |
|
197 | * </ul> |
||
198 | */ |
||
199 | 6 | public function durationCompare(self $interval): int |
|
203 | |||
204 | /** |
||
205 | * Tells whether the current instance duration is equal to the submitted one. |
||
206 | */ |
||
207 | public function durationEquals(self $interval): bool |
||
211 | |||
212 | /** |
||
213 | 21 | * Tells whether the current instance duration is greater than the submitted one. |
|
214 | */ |
||
215 | 21 | public function durationGreaterThan(self $interval): bool |
|
219 | |||
220 | /** |
||
221 | * Tells whether the current instance duration is less than the submitted one. |
||
222 | */ |
||
223 | public function durationLessThan(self $interval): bool |
||
227 | |||
228 | 12 | /** |
|
229 | 3 | * Tells whether two intervals share the same datepoints. |
|
230 | 3 | * |
|
231 | 3 | * [--------------------) |
|
232 | * [--------------------) |
||
233 | 3 | */ |
|
234 | public function equals(self $interval): bool |
||
239 | 6 | ||
240 | /** |
||
241 | * Tells whether two intervals abuts. |
||
242 | * |
||
243 | * [--------------------) |
||
244 | * [--------------------) |
||
245 | * or |
||
246 | * [--------------------) |
||
247 | * [--------------------) |
||
248 | */ |
||
249 | public function abuts(self $interval): bool |
||
254 | |||
255 | 75 | /** |
|
256 | 75 | * Tells whether two intervals overlaps. |
|
257 | 51 | * |
|
258 | * [--------------------) |
||
259 | * [--------------------) |
||
260 | 24 | */ |
|
261 | public function overlaps(self $interval): bool |
||
266 | |||
267 | /** |
||
268 | * Tells whether an interval is entirely after the specified index. |
||
269 | * The index can be a DateTimeInterface object or another Period object. |
||
270 | * |
||
271 | 12 | * [--------------------) |
|
272 | * [--------------------) |
||
273 | 12 | */ |
|
274 | 3 | public function isAfter($index): bool |
|
282 | 6 | ||
283 | /** |
||
284 | 6 | * Tells whether an instance is entirely before the specified index. |
|
285 | * |
||
286 | * The index can be a DateTimeInterface object or another Period object. |
||
287 | * |
||
288 | * [--------------------) |
||
289 | * [--------------------) |
||
290 | */ |
||
291 | public function isBefore($index): bool |
||
299 | |||
300 | 6 | /** |
|
301 | * Tells whether an instance fully contains the specified index. |
||
302 | * |
||
303 | 36 | * The index can be a DateTimeInterface object or another Period object. |
|
304 | * |
||
305 | 30 | */ |
|
306 | public function contains($index): bool |
||
314 | |||
315 | /** |
||
316 | 24 | * Tells whether an instance fully contains another instance. |
|
317 | * |
||
318 | 24 | * [--------------------) |
|
319 | 3 | * [----------) |
|
320 | 3 | */ |
|
321 | 3 | private function containsInterval(self $interval): bool |
|
326 | |||
327 | /** |
||
328 | 24 | * Tells whether an instance contains a datepoint. |
|
329 | 24 | * |
|
330 | 18 | * [------|------------) |
|
331 | */ |
||
332 | private function containsDatePoint(DateTimeInterface $datepoint): bool |
||
336 | |||
337 | /** |
||
338 | * Allows splitting an instance in smaller Period objects according to a given interval. |
||
339 | * |
||
340 | * The returned iterable Interval set is ordered so that: |
||
341 | * <ul> |
||
342 | * <li>The first returned object MUST share the starting datepoint of the parent object.</li> |
||
343 | * <li>The last returned object MUST share the ending datepoint of the parent object.</li> |
||
344 | * <li>The last returned object MUST have a duration equal or lesser than the submitted interval.</li> |
||
345 | * <li>All returned objects except for the first one MUST start immediately after the previously returned object</li> |
||
346 | 3 | * </ul> |
|
347 | * |
||
348 | 3 | * @return iterable<Period> |
|
|
|||
349 | */ |
||
350 | 3 | public function split($duration): iterable |
|
364 | |||
365 | 3 | /** |
|
366 | * Allows splitting an instance in smaller Period objects according to a given interval. |
||
367 | 3 | * |
|
368 | * The returned iterable Period set is ordered so that: |
||
369 | * <ul> |
||
370 | * <li>The first returned object MUST share the ending datepoint of the parent object.</li> |
||
371 | * <li>The last returned object MUST share the starting datepoint of the parent object.</li> |
||
372 | * <li>The last returned object MUST have a duration equal or lesser than the submitted interval.</li> |
||
373 | * <li>All returned objects except for the first one MUST end immediately before the previously returned object</li> |
||
374 | * </ul> |
||
375 | * |
||
376 | * @return iterable<Period> |
||
377 | */ |
||
378 | public function splitBackwards($duration): iterable |
||
392 | |||
393 | /** |
||
394 | * Returns the computed intersection between two instances as a new instance. |
||
395 | * |
||
396 | * [--------------------) |
||
397 | 3 | * ∩ |
|
398 | * [----------) |
||
399 | 3 | * = |
|
400 | * [----) |
||
401 | 3 | * |
|
402 | * @throws Exception If both objects do not overlaps |
||
403 | */ |
||
404 | public function intersect(self $interval): self |
||
415 | |||
416 | /** |
||
417 | * Returns the computed difference between two overlapping instances as |
||
418 | * an array containing Period objects or the null value. |
||
419 | * |
||
420 | * The array will always contains 2 elements: |
||
421 | * |
||
422 | * <ul> |
||
423 | * <li>an NULL filled array if both objects have the same datepoints</li> |
||
424 | * <li>one Period object and NULL if both objects share one datepoint</li> |
||
425 | 162 | * <li>two Period objects if both objects share no datepoint</li> |
|
426 | * </ul> |
||
427 | 162 | * |
|
428 | * [--------------------) |
||
429 | * - |
||
430 | * [-----------) |
||
431 | * = |
||
432 | * [--------------) + [-----) |
||
433 | * |
||
434 | * @return array<null|Period> |
||
435 | 18 | */ |
|
436 | public function diff(self $interval): array |
||
457 | |||
458 | /** |
||
459 | * Returns the computed gap between two instances as a new instance. |
||
460 | * |
||
461 | * [--------------------) |
||
462 | * + |
||
463 | * [----------) |
||
464 | * = |
||
465 | * [---) |
||
466 | * |
||
467 | * @throws Exception If both instance overlaps |
||
468 | */ |
||
469 | 24 | public function gap(self $interval): self |
|
481 | |||
482 | /** |
||
483 | * Returns the difference between two instances expressed in seconds. |
||
484 | */ |
||
485 | public function timestampIntervalDiff(self $interval): float |
||
489 | |||
490 | /** |
||
491 | * Returns the difference between two instances expressed with a DateInterval object. |
||
492 | */ |
||
493 | public function dateIntervalDiff(self $interval): DateInterval |
||
497 | 12 | ||
498 | /** |
||
499 | 12 | * Returns an instance with the specified starting datepoint. |
|
500 | 12 | * |
|
501 | * This method MUST retain the state of the current instance, and return |
||
502 | 12 | * an instance that contains the specified starting datepoint. |
|
503 | 12 | */ |
|
504 | 6 | public function startingOn($datepoint): self |
|
513 | |||
514 | /** |
||
515 | * Returns an instance with the specified ending datepoint. |
||
516 | * |
||
517 | * This method MUST retain the state of the current instance, and return |
||
518 | * an instance that contains the specified ending datepoint. |
||
519 | */ |
||
520 | public function endingOn($datepoint): self |
||
529 | |||
530 | /** |
||
531 | * Returns a new instance with a new ending datepoint. |
||
532 | * |
||
533 | * This method MUST retain the state of the current instance, and return |
||
534 | * an instance that contains the specified ending datepoint. |
||
535 | 6 | */ |
|
536 | public function withDurationAfterStart($duration): self |
||
540 | 6 | ||
541 | 6 | /** |
|
542 | 3 | * Returns a new instance with a new starting datepoint. |
|
543 | * |
||
544 | 6 | * This method MUST retain the state of the current instance, and return |
|
545 | * an instance that contains the specified starting datepoint. |
||
546 | 6 | */ |
|
547 | 6 | public function withDurationBeforeEnd($duration): self |
|
551 | |||
552 | /** |
||
553 | * Returns a new instance with a new starting datepoint |
||
554 | * moved forward or backward by the given interval. |
||
555 | * |
||
556 | * This method MUST retain the state of the current instance, and return |
||
557 | * an instance that contains the specified starting datepoint. |
||
558 | 3 | */ |
|
559 | public function moveStartDate($duration): self |
||
563 | |||
564 | /** |
||
565 | * Returns a new instance with a new ending datepoint |
||
566 | * moved forward or backward by the given interval. |
||
567 | * |
||
568 | * This method MUST retain the state of the current instance, and return |
||
569 | * an instance that contains the specified ending datepoint. |
||
570 | */ |
||
571 | public function moveEndDate($duration): self |
||
575 | 6 | ||
576 | 6 | /** |
|
577 | 6 | * Returns a new instance where the datepoints |
|
578 | * are moved forwards or backward simultaneously by the given DateInterval. |
||
579 | * |
||
580 | 6 | * This method MUST retain the state of the current instance, and return |
|
581 | 6 | * an instance that contains the specified new datepoints. |
|
582 | */ |
||
583 | public function move($duration): self |
||
593 | |||
594 | /** |
||
595 | * Returns an instance where the given DateInterval is simultaneously |
||
596 | * substracted from the starting datepoint and added to the ending datepoint. |
||
597 | * |
||
598 | * Depending on the duration value, the resulting instance duration will be expanded or shrinked. |
||
599 | 21 | * |
|
600 | * This method MUST retain the state of the current instance, and return |
||
601 | 21 | * an instance that contains the specified new datepoints. |
|
602 | */ |
||
603 | public function expand($duration): self |
||
613 | |||
614 | 9 | /** |
|
615 | * Merges one or more instances to return a new instance. |
||
616 | * The resulting instance represents the largest duration possible. |
||
617 | * |
||
618 | * This method MUST retain the state of the current instance, and return |
||
619 | * an instance that contains the specified new datepoints. |
||
620 | * |
||
621 | * @param Period ...$intervals |
||
622 | */ |
||
623 | public function merge(self $interval, self ...$intervals): self |
||
639 | } |
||
640 |
This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.