Trello::buildAuthorizationQueryParameters() - Code Metrics - thephpleague/oauth1-trello - Measure and Improve Code Quality continuously with Scrutinizer

Trello::buildAuthorizationQueryParameters() A
last analyzed 2015-12-28 18:58 UTC

↳ Parent: Trello

Complexity

Conditions	4
Paths	8

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	11
ccs	7
cts	7
cp	1
rs	9.2
cc	4
eloc	7
nc	8
nop	1
crap	4

<?php

namespace League\OAuth1\Client\Server;

use League\OAuth1\Client\Credentials\TokenCredentials;
use Psr\Http\Message\ResponseInterface;

class Trello extends AbstractServer
{
    /**
     * Requested token expiration
     *
     * @var string
     */
    protected $expiration;

    /**
     * Application name displayed to authenticating user
     *
     * @var string
     */
    protected $name;

    /**
     * Requested token scope
     *
     * @var string
     */
    protected $scope;

    /**
     * Build authorization query parameters.
     *
     * @param  array $options
     *
     * @return string
     */
    protected function buildAuthorizationQueryParameters(array $options = array())
    {
        $params = array(
            'response_type' => 'fragment',
            'scope' => isset($options['scope']) ? $options['scope'] : $this->scope,
            'expiration' => isset($options['expiration']) ? $options['expiration'] : $this->expiration,
            'name' => isset($options['name']) ? $options['name'] : $this->name,
        );

        return http_build_query(array_filter($params));
    }

    /**
     * Checks a provider response for errors.
     *
     * @param  ResponseInterface $response
     * @param  array|string $data Parsed response data
     *
     * @return void
     * @throws IdentityProviderException
     */
    protected function checkResponse(ResponseInterface $response, $data)
    {
        //
    }

    /**
     * Generates a resource owner object from a successful resource owner
     * details request.
     *
     * @param  array $response
     * @param  TokenCredentials $tokenCredentials
     *
     * @return ResourceOwnerInterface
     */
    protected function createResourceOwner(array $response, TokenCredentials $tokenCredentials)
    {
        return new TrelloResourceOwner($response);
    }

    /**
     * Creates an authenticated query string and merges with a given query string,
     * if provided.
     *
     * @param  TokenCredentials  $tokenCredentials
     * @param  string            $query
     *
     * @return string
     */
    protected function getAuthenticatedQueryString(TokenCredentials $tokenCredentials, $query = '')
    {
        $query = parse_str($query);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $query['key'] = (string) $this->clientCredentials;
        $query['token'] = (string) $tokenCredentials;

        return http_build_query($query);
    }

    /**
     * Creates a new authenticated request.
     *
     * @param  string            $method
     * @param  string            $url
     * @param  TokenCredentials  $tokenCredentials
     *
     * @return \GuzzleHttp\Psr7\Request
     */
    public function getAuthenticatedRequest($method, $url, TokenCredentials $tokenCredentials)
    {
        $request = parent::getAuthenticatedRequest($method, $url, $tokenCredentials);

        $uri = $request->getUri()->withQuery(
            $this->getAuthenticatedQueryString(
                $tokenCredentials,
                $request->getUri()->getQuery()
            )
        );

        return $request->withUri($uri);
    }

    /**
     * Gets the URL for redirecting the resource owner to authorize the client.
     *
     * @return string
     */
    protected function getBaseAuthorizationUrl(array $options = array())
    {
        return 'https://trello.com/1/OAuthAuthorizeToken?'.
            $this->buildAuthorizationQueryParameters($options);
    }

    /**
     * Gets the URL for retrieving temporary credentials.
     *
     * @return string
     */
    protected function getBaseTemporaryCredentialsUrl()
    {
        return 'https://trello.com/1/OAuthGetRequestToken';
    }

    /**
     * Gets the URL retrieving token credentials.
     *
     * @return string
     */
    protected function getBaseTokenCredentialsUrl()
    {
        return 'https://trello.com/1/OAuthGetAccessToken';
    }

    /**
     * Gets the URL for retrieving user details.
     *
     * @return string
     */
    protected function getResourceOwnerDetailsUrl(TokenCredentials $tokenCredentials)
    {
        return 'https://api.trello.com/1/members/me?'.$this->getAuthenticatedQueryString($tokenCredentials);
    }
}


1		<?php
2
3		namespace League\OAuth1\Client\Server;
4
5		use League\OAuth1\Client\Credentials\TokenCredentials;
6		use Psr\Http\Message\ResponseInterface;
7
8		class Trello extends AbstractServer
9		{
10		/**
11		* Requested token expiration
12		*
13		* @var string
14		*/
15		protected $expiration;
16
17		/**
18		* Application name displayed to authenticating user
19		*
20		* @var string
21		*/
22		protected $name;
23
24		/**
25		* Requested token scope
26		*
27		* @var string
28		*/
29		protected $scope;
30
31		/**
32		* Build authorization query parameters.
33		*
34		* @param array $options
35		*
36		* @return string
37		*/
38	4	protected function buildAuthorizationQueryParameters(array $options = array())
39		{
40		$params = array(
41	4	'response_type' => 'fragment',
42	4	'scope' => isset($options['scope']) ? $options['scope'] : $this->scope,
43	4	'expiration' => isset($options['expiration']) ? $options['expiration'] : $this->expiration,
44	4	'name' => isset($options['name']) ? $options['name'] : $this->name,
45	4	);
46
47	4	return http_build_query(array_filter($params));
48		}
49
50		/**
51		* Checks a provider response for errors.
52		*
53		* @param ResponseInterface $response
54		* @param array\|string $data Parsed response data
55		*
56		* @return void
57		* @throws IdentityProviderException
58		*/
59	2	protected function checkResponse(ResponseInterface $response, $data)
60		{
61		//
62	2	}
63
64		/**
65		* Generates a resource owner object from a successful resource owner
66		* details request.
67		*
68		* @param array $response
69		* @param TokenCredentials $tokenCredentials
70		*
71		* @return ResourceOwnerInterface
72		*/
73	2	protected function createResourceOwner(array $response, TokenCredentials $tokenCredentials)
74		{
75	2	return new TrelloResourceOwner($response);
76		}
77
78		/**
79		* Creates an authenticated query string and merges with a given query string,
80		* if provided.
81		*
82		* @param TokenCredentials $tokenCredentials
83		* @param string $query
84		*
85		* @return string
86		*/
87	4	protected function getAuthenticatedQueryString(TokenCredentials $tokenCredentials, $query = '')
88		{
89	4	$query = parse_str($query);
		0 ignored issues – show Bug introduced 2015-12-07 23:13 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$query` is correct as `parse_str($query)` (which targets `parse_str()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
90	4	$query['key'] = (string) $this->clientCredentials;
91	4	$query['token'] = (string) $tokenCredentials;
92
93	4	return http_build_query($query);
94		}
95
96		/**
97		* Creates a new authenticated request.
98		*
99		* @param string $method
100		* @param string $url
101		* @param TokenCredentials $tokenCredentials
102		*
103		* @return \GuzzleHttp\Psr7\Request
104		*/
105	2	public function getAuthenticatedRequest($method, $url, TokenCredentials $tokenCredentials)
106		{
107	2	$request = parent::getAuthenticatedRequest($method, $url, $tokenCredentials);
108
109	2	$uri = $request->getUri()->withQuery(
110	2	$this->getAuthenticatedQueryString(
111	2	$tokenCredentials,
112	2	$request->getUri()->getQuery()
113	2	)
114	2	);
115
116	2	return $request->withUri($uri);
117		}
118
119		/**
120		* Gets the URL for redirecting the resource owner to authorize the client.
121		*
122		* @return string
123		*/
124	4	protected function getBaseAuthorizationUrl(array $options = array())
125		{
126		return 'https://trello.com/1/OAuthAuthorizeToken?'.
127	4	$this->buildAuthorizationQueryParameters($options);
128		}
129
130		/**
131		* Gets the URL for retrieving temporary credentials.
132		*
133		* @return string
134		*/
135	2	protected function getBaseTemporaryCredentialsUrl()
136		{
137	2	return 'https://trello.com/1/OAuthGetRequestToken';
138		}
139
140		/**
141		* Gets the URL retrieving token credentials.
142		*
143		* @return string
144		*/
145	2	protected function getBaseTokenCredentialsUrl()
146		{
147	2	return 'https://trello.com/1/OAuthGetAccessToken';
148		}
149
150		/**
151		* Gets the URL for retrieving user details.
152		*
153		* @return string
154		*/
155	2	protected function getResourceOwnerDetailsUrl(TokenCredentials $tokenCredentials)
156		{
157	2	return 'https://api.trello.com/1/members/me?'.$this->getAuthenticatedQueryString($tokenCredentials);
158		}
159		}
160

thephpleague / oauth1-trello

Trello::buildAuthorizationQueryParameters() A last analyzed 2015-12-28 18:58 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Trello::buildAuthorizationQueryParameters() A
last analyzed 2015-12-28 18:58 UTC