RuleSetTrait::get() - Code Metrics - Inspection of "[WIP] 1.0" - thephpleague/json-guard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#108)

by Matt

created 2017-04-18 21:53 UTC

RuleSetTrait::get() A

↳ Parent: RuleSetTrait

Complexity

Conditions	4
Paths	5

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4.3731

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	5
nop	1
dl	0
loc	14
ccs	5
cts	7
cp	0.7143
crap	4.3731
rs	9.2
c	0
b	0
f	0

<?php

namespace League\JsonGuard\RuleSets;

use League\JsonGuard\Exceptions\ConstraintException;
use League\JsonGuard\Exceptions\ConstraintNotFoundException;

trait RuleSetTrait
{
    /**
     * @return array
     */
    abstract protected function rules();

    /**
     * @param string          $id
     * @param string|\Closure $constraint
     *
     * @return void
     */
    abstract protected function setRule($id, $constraint);

    /**
     * @param string          $id
     * @param string|\Closure $constraint
     */
    public function set($id, $constraint)
    {
        if (!is_string($constraint) && !$constraint instanceof \Closure) {
            throw new \InvalidArgumentException(sprintf('Expected a string or Closure, got %s', gettype($constraint)));
        }
        $this->setRule($id, $constraint);
    }

    /**
     * {@inheritdoc}
     */
    public function has($id)
    {
        return array_key_exists($id, $this->rules());
    }

    /**
     * {@inheritdoc}
     */
    public function get($id)
    {
        if (!$this->has($id)) {
            throw ConstraintNotFoundException::forRule($id);
        }

        $concrete = $this->rules()[$id];

        try {
            return is_string($concrete) ? new $concrete() : $concrete();
        } catch (\Exception $e) {
            throw ConstraintException::forRule($id, $e);
        }
    }
}


1		<?php
2
3		namespace League\JsonGuard\RuleSets;
4
5		use League\JsonGuard\Exceptions\ConstraintException;
6		use League\JsonGuard\Exceptions\ConstraintNotFoundException;
7
8		trait RuleSetTrait
9		{
10		/**
11		* @return array
12		*/
13		abstract protected function rules();
14
15		/**
16		* @param string $id
17		* @param string\|\Closure $constraint
18		*
19		* @return void
20		*/
21		abstract protected function setRule($id, $constraint);
22
23		/**
24		* @param string $id
25		* @param string\|\Closure $constraint
26		*/
27	2	public function set($id, $constraint)
28		{
29	2	if (!is_string($constraint) && !$constraint instanceof \Closure) {
30		throw new \InvalidArgumentException(sprintf('Expected a string or Closure, got %s', gettype($constraint)));
31		}
32	2	$this->setRule($id, $constraint);
33	2	}
34
35		/**
36		* {@inheritdoc}
37		*/
38	156	public function has($id)
39		{
40	156	return array_key_exists($id, $this->rules());
41		}
42
43		/**
44		* {@inheritdoc}
45		*/
46	152	public function get($id)
47		{
48	152	if (!$this->has($id)) {
49	2	throw ConstraintNotFoundException::forRule($id);
50		}
51
52	150	$concrete = $this->rules()[$id];
53
54		try {
55	150	return is_string($concrete) ? new $concrete() : $concrete();
56		} catch (\Exception $e) {
57		throw ConstraintException::forRule($id, $e);
58		}
59		}
60		}
61

thephpleague / json-guard

Pull Request — master (#108)

RuleSetTrait::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like