Items::getSchema() - Code Metrics - Inspection of "1.0" - thephpleague/json-guard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#108)

by Matt

created 2017-04-23 19:45 UTC

Items::getSchema() A

↳ Parent: Items

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	6
nc	3
nop	2
dl	0
loc	12
rs	9.2
c	0
b	0
f	0

<?php

namespace League\JsonGuard\Constraints\DraftFour;

use League\JsonGuard\Assert;
use League\JsonGuard\Constraint;
use League\JsonGuard\Validator;
use function League\JsonReference\pointer_push;

class Items implements Constraint
{
    const KEYWORD = 'items';

    /**
     * {@inheritdoc}
     */
    public function validate($value, $parameter, Validator $validator)
    {
        Assert::type($parameter, ['array', 'object'], self::KEYWORD, $validator->getSchemaPath());

        if (!is_array($value)) {
            return null;
        }

        $errors = [];
        foreach ($value as $key => $itemValue) {

            $schema = self::getSchema($parameter, $key);

            // Additional items are allowed by default,
            // so there might not be a schema for this.
            if (is_null($schema)) {
                continue;
            }

            $subValidator = $validator->makeSubSchemaValidator(
                $itemValue,
                $schema,
                pointer_push($validator->getDataPath(), $key),
                pointer_push($validator->getSchemaPath(), $key)
            );
            $errors = array_merge($errors, $subValidator->errors());
        }

        return $errors ?: null;
    }

    /**
     * @param $parameter
     * @param $key
     *
     * @return mixed
     */
    private static function getSchema($parameter, $key)
    {
        if (is_object($parameter)) {
            // list validation
            return $parameter;
        } elseif (is_array($parameter) && array_key_exists($key, $parameter)) {
            // tuple validation
            return $parameter[$key];
        }

        return null;
    }
}


1		<?php
2
3		namespace League\JsonGuard\Constraints\DraftFour;
4
5		use League\JsonGuard\Assert;
6		use League\JsonGuard\Constraint;
7		use League\JsonGuard\Validator;
8		use function League\JsonReference\pointer_push;
9
10		class Items implements Constraint
11		{
12		const KEYWORD = 'items';
13
14		/**
15		* {@inheritdoc}
16		*/
17		public function validate($value, $parameter, Validator $validator)
18		{
19		Assert::type($parameter, ['array', 'object'], self::KEYWORD, $validator->getSchemaPath());
20
21		if (!is_array($value)) {
22		return null;
23		}
24
25		$errors = [];
26	View Code Duplication	foreach ($value as $key => $itemValue) {
		0 ignored issues – show Duplication introduced 2017-04-23 20:04 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		$schema = self::getSchema($parameter, $key);
28
29		// Additional items are allowed by default,
30		// so there might not be a schema for this.
31		if (is_null($schema)) {
32		continue;
33		}
34
35		$subValidator = $validator->makeSubSchemaValidator(
36		$itemValue,
37		$schema,
38		pointer_push($validator->getDataPath(), $key),
39		pointer_push($validator->getSchemaPath(), $key)
40		);
41		$errors = array_merge($errors, $subValidator->errors());
42		}
43
44		return $errors ?: null;
45		}
46
47		/**
48		* @param $parameter
49		* @param $key
50		*
51		* @return mixed
52		*/
53		private static function getSchema($parameter, $key)
54		{
55		if (is_object($parameter)) {
56		// list validation
57		return $parameter;
58		} elseif (is_array($parameter) && array_key_exists($key, $parameter)) {
59		// tuple validation
60		return $parameter[$key];
61		}
62
63		return null;
64		}
65		}
66

thephpleague / json-guard

Pull Request — master (#108)

Items::getSchema() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like