Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | final class Items implements ConstraintInterface |
||
11 | { |
||
12 | const KEYWORD = 'items'; |
||
13 | |||
14 | /** |
||
15 | * {@inheritdoc} |
||
16 | */ |
||
17 | 14 | public function validate($value, $parameter, Validator $validator) |
|
18 | { |
||
19 | 14 | Assert::type($parameter, ['array', 'object'], self::KEYWORD, $validator->getSchemaPath()); |
|
20 | |||
21 | 12 | if (!is_array($value)) { |
|
22 | 4 | return null; |
|
23 | } |
||
24 | |||
25 | 10 | $errors = []; |
|
26 | 10 | View Code Duplication | foreach ($value as $key => $itemValue) { |
|
|||
27 | 10 | $schema = self::getSchema($parameter, $key); |
|
28 | |||
29 | // Additional items are allowed by default, |
||
30 | // so there might not be a schema for this. |
||
31 | 10 | if (is_null($schema)) { |
|
32 | 2 | continue; |
|
33 | } |
||
34 | |||
35 | 10 | $subValidator = $validator->makeSubSchemaValidator( |
|
36 | 10 | $itemValue, |
|
37 | 10 | $schema, |
|
38 | 10 | pointer_push($validator->getDataPath(), $key), |
|
39 | 10 | pointer_push($validator->getSchemaPath(), $key) |
|
40 | ); |
||
41 | 10 | $errors = array_merge($errors, $subValidator->errors()); |
|
42 | } |
||
43 | |||
44 | 10 | return $errors ?: null; |
|
45 | } |
||
46 | |||
47 | /** |
||
48 | * @param $parameter |
||
49 | * @param $key |
||
50 | * |
||
51 | * @return mixed |
||
52 | */ |
||
53 | 10 | private static function getSchema($parameter, $key) |
|
65 | } |
||
66 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.