Complex classes like Server often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Server, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class Server |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * Source file system. |
||
| 17 | * @var FilesystemInterface |
||
| 18 | */ |
||
| 19 | protected $source; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Source path prefix. |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $sourcePathPrefix; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Cache file system. |
||
| 29 | * @var FilesystemInterface |
||
| 30 | */ |
||
| 31 | protected $cache; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Cache path prefix. |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | protected $cachePathPrefix; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * Image manipulation API. |
||
| 41 | * @var ApiInterface |
||
| 42 | */ |
||
| 43 | protected $api; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Response factory. |
||
| 47 | * @var ResponseFactoryInterface|null |
||
| 48 | */ |
||
| 49 | protected $responseFactory; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Base URL. |
||
| 53 | * @var string |
||
| 54 | */ |
||
| 55 | protected $baseUrl; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * Default image manipulations. |
||
| 59 | * @var array |
||
| 60 | */ |
||
| 61 | protected $defaults = []; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Preset image manipulations. |
||
| 65 | * @var array |
||
| 66 | */ |
||
| 67 | protected $presets = []; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Create Server instance. |
||
| 71 | * @param FilesystemInterface $source Source file system. |
||
| 72 | * @param FilesystemInterface $cache Cache file system. |
||
| 73 | * @param ApiInterface $api Image manipulation API. |
||
| 74 | */ |
||
| 75 | 132 | public function __construct(FilesystemInterface $source, FilesystemInterface $cache, ApiInterface $api) |
|
| 81 | |||
| 82 | /** |
||
| 83 | * Set source file system. |
||
| 84 | * @param FilesystemInterface $source Source file system. |
||
| 85 | */ |
||
| 86 | 132 | public function setSource(FilesystemInterface $source) |
|
| 90 | |||
| 91 | /** |
||
| 92 | * Get source file system. |
||
| 93 | * @return FilesystemInterface Source file system. |
||
| 94 | */ |
||
| 95 | 6 | public function getSource() |
|
| 99 | |||
| 100 | /** |
||
| 101 | * Set source path prefix. |
||
| 102 | * @param string $sourcePathPrefix Source path prefix. |
||
| 103 | */ |
||
| 104 | 15 | public function setSourcePathPrefix($sourcePathPrefix) |
|
| 108 | |||
| 109 | /** |
||
| 110 | * Get source path prefix. |
||
| 111 | * @return string Source path prefix. |
||
| 112 | */ |
||
| 113 | 6 | public function getSourcePathPrefix() |
|
| 117 | |||
| 118 | /** |
||
| 119 | * Get source path. |
||
| 120 | * @param string $path Image path. |
||
| 121 | * @return string The source path. |
||
| 122 | * @throws FileNotFoundException |
||
| 123 | */ |
||
| 124 | 63 | public function getSourcePath($path) |
|
| 142 | |||
| 143 | /** |
||
| 144 | * Check if a source file exists. |
||
| 145 | * @param string $path Image path. |
||
| 146 | * @return bool Whether the source file exists. |
||
| 147 | */ |
||
| 148 | 18 | public function sourceFileExists($path) |
|
| 152 | |||
| 153 | /** |
||
| 154 | * Set base URL. |
||
| 155 | * @param string $baseUrl Base URL. |
||
| 156 | */ |
||
| 157 | 12 | public function setBaseUrl($baseUrl) |
|
| 161 | |||
| 162 | /** |
||
| 163 | * Get base URL. |
||
| 164 | * @return string Base URL. |
||
| 165 | */ |
||
| 166 | 6 | public function getBaseUrl() |
|
| 170 | |||
| 171 | /** |
||
| 172 | * Set cache file system. |
||
| 173 | * @param FilesystemInterface $cache Cache file system. |
||
| 174 | */ |
||
| 175 | 132 | public function setCache(FilesystemInterface $cache) |
|
| 179 | |||
| 180 | /** |
||
| 181 | * Get cache file system. |
||
| 182 | * @return FilesystemInterface Cache file system. |
||
| 183 | */ |
||
| 184 | 6 | public function getCache() |
|
| 188 | |||
| 189 | /** |
||
| 190 | * Set cache path prefix. |
||
| 191 | * @param string $cachePathPrefix Cache path prefix. |
||
| 192 | */ |
||
| 193 | 12 | public function setCachePathPrefix($cachePathPrefix) |
|
| 197 | |||
| 198 | /** |
||
| 199 | * Get cache path prefix. |
||
| 200 | * @return string Cache path prefix. |
||
| 201 | */ |
||
| 202 | 6 | public function getCachePathPrefix() |
|
| 206 | |||
| 207 | /** |
||
| 208 | * Get cache path. |
||
| 209 | * @param string $path Image path. |
||
| 210 | * @param array $params Image manipulation params. |
||
| 211 | * @return string Cache path. |
||
| 212 | */ |
||
| 213 | 45 | public function getCachePath($path, array $params = []) |
|
| 214 | { |
||
| 215 | 45 | $sourcePath = $this->getSourcePath($path); |
|
| 216 | |||
| 217 | 45 | if ($this->sourcePathPrefix) { |
|
| 218 | 3 | $sourcePath = substr($sourcePath, strlen($this->sourcePathPrefix) + 1); |
|
| 219 | 3 | } |
|
| 220 | |||
| 221 | 45 | $params = $this->getAllParams($params); |
|
| 222 | 45 | unset($params['s'], $params['p']); |
|
| 223 | 45 | ksort($params); |
|
| 224 | |||
| 225 | 45 | $md5 = md5($sourcePath.'?'.http_build_query($params)); |
|
| 226 | |||
| 227 | 45 | $path = $sourcePath.'/'.$md5; |
|
| 228 | |||
| 229 | 45 | if ($this->cachePathPrefix) { |
|
| 230 | 3 | $path = $this->cachePathPrefix.'/'.$path; |
|
| 231 | 3 | } |
|
| 232 | |||
| 233 | 45 | return $path; |
|
| 234 | } |
||
| 235 | |||
| 236 | /** |
||
| 237 | * Check if a cache file exists. |
||
| 238 | * @param string $path Image path. |
||
| 239 | * @param array $params Image manipulation params. |
||
| 240 | * @return bool Whether the cache file exists. |
||
| 241 | */ |
||
| 242 | 33 | public function cacheFileExists($path, array $params) |
|
| 248 | |||
| 249 | /** |
||
| 250 | * Delete cached manipulations for an image. |
||
| 251 | * @param string $path Image path. |
||
| 252 | * @return bool Whether the delete succeeded. |
||
| 253 | */ |
||
| 254 | 3 | public function deleteCache($path) |
|
| 260 | |||
| 261 | /** |
||
| 262 | * Set image manipulation API. |
||
| 263 | * @param ApiInterface $api Image manipulation API. |
||
| 264 | */ |
||
| 265 | 132 | public function setApi(ApiInterface $api) |
|
| 269 | |||
| 270 | /** |
||
| 271 | * Get image manipulation API. |
||
| 272 | * @return ApiInterface Image manipulation API. |
||
| 273 | */ |
||
| 274 | 6 | public function getApi() |
|
| 278 | |||
| 279 | /** |
||
| 280 | * Set default image manipulations. |
||
| 281 | * @param array $defaults Default image manipulations. |
||
| 282 | */ |
||
| 283 | 15 | public function setDefaults(array $defaults) |
|
| 287 | |||
| 288 | /** |
||
| 289 | * Get default image manipulations. |
||
| 290 | * @return array Default image manipulations. |
||
| 291 | */ |
||
| 292 | 6 | public function getDefaults() |
|
| 296 | |||
| 297 | /** |
||
| 298 | * Set preset image manipulations. |
||
| 299 | * @param array $presets Preset image manipulations. |
||
| 300 | */ |
||
| 301 | 15 | public function setPresets(array $presets) |
|
| 305 | |||
| 306 | /** |
||
| 307 | * Get preset image manipulations. |
||
| 308 | * @return array Preset image manipulations. |
||
| 309 | */ |
||
| 310 | 6 | public function getPresets() |
|
| 314 | |||
| 315 | /** |
||
| 316 | * Get all image manipulations params, including defaults and presets. |
||
| 317 | * @param array $params Image manipulation params. |
||
| 318 | * @return array All image manipulation params. |
||
| 319 | */ |
||
| 320 | 48 | public function getAllParams(array $params) |
|
| 334 | |||
| 335 | /** |
||
| 336 | * Set response factory. |
||
| 337 | * @param ResponseFactoryInterface|null $responseFactory Response factory. |
||
| 338 | */ |
||
| 339 | 15 | public function setResponseFactory(ResponseFactoryInterface $responseFactory = null) |
|
| 343 | |||
| 344 | /** |
||
| 345 | * Get response factory. |
||
| 346 | * @return ResponseFactoryInterface Response factory. |
||
| 347 | */ |
||
| 348 | 6 | public function getResponseFactory() |
|
| 352 | |||
| 353 | /** |
||
| 354 | * Generate and return image response. |
||
| 355 | * @param string $path Image path. |
||
| 356 | * @param array $params Image manipulation params. |
||
| 357 | * @return mixed Image response. |
||
| 358 | * @throws InvalidArgumentException |
||
| 359 | */ |
||
| 360 | 6 | public function getImageResponse($path, array $params) |
|
| 361 | { |
||
| 362 | 6 | if (is_null($this->responseFactory)) { |
|
| 363 | 3 | throw new InvalidArgumentException( |
|
| 364 | 'Unable to get image response, no response factory defined.' |
||
| 365 | 3 | ); |
|
| 366 | } |
||
| 367 | |||
| 368 | 3 | $path = $this->makeImage($path, $params); |
|
| 369 | |||
| 370 | 3 | return $this->responseFactory->create($this->cache, $path); |
|
| 371 | } |
||
| 372 | |||
| 373 | /** |
||
| 374 | * Generate and return Base64 encoded image. |
||
| 375 | * @param string $path Image path. |
||
| 376 | * @param array $params Image manipulation params. |
||
| 377 | * @return string Base64 encoded image. |
||
| 378 | * @throws FilesystemException |
||
| 379 | */ |
||
| 380 | 6 | public function getImageAsBase64($path, array $params) |
|
| 381 | { |
||
| 382 | 6 | $path = $this->makeImage($path, $params); |
|
| 383 | |||
| 384 | 6 | $source = $this->cache->read($path); |
|
| 385 | |||
| 386 | 6 | if ($source === false) { |
|
| 387 | 3 | throw new FilesystemException( |
|
| 388 | 3 | 'Could not read the image `'.$path.'`.' |
|
| 389 | 3 | ); |
|
| 390 | } |
||
| 391 | |||
| 392 | 3 | return 'data:'.$this->cache->getMimetype($path).';base64,'.base64_encode($source); |
|
| 393 | } |
||
| 394 | |||
| 395 | /** |
||
| 396 | * Generate and output image. |
||
| 397 | * @param string $path Image path. |
||
| 398 | * @param array $params Image manipulation params. |
||
| 399 | * @throws InvalidArgumentException |
||
| 400 | */ |
||
| 401 | 3 | public function outputImage($path, array $params) |
|
| 416 | |||
| 417 | /** |
||
| 418 | * Generate manipulated image. |
||
| 419 | * @param string $path Image path. |
||
| 420 | * @param array $params Image manipulation params. |
||
| 421 | * @return string Cache path. |
||
| 422 | * @throws FileNotFoundException |
||
| 423 | * @throws FilesystemException |
||
| 424 | */ |
||
| 425 | 30 | public function makeImage($path, array $params) |
|
| 482 | } |
||
| 483 |