Flip - Code Metrics - Inspection of "Flip manipulator" - thephpleague/glide - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#221)

by James

created 2018-02-12 17:50 UTC

Flip A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

43.75%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	5
c	2
b	0
f	0
lcom	0
cbo	2
dl	0
loc	31
ccs	7
cts	16
cp	0.4375
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	12	3
A	getFlip()	0	6	2

<?php

namespace League\Glide\Manipulators;

use Intervention\Image\Image;

/**
 * @property string $or
 */
class Flip extends BaseManipulator
{
    /**
     * Perform flip image manipulation.
     * @param  Image $image The source image.
     * @return Image The manipulated image.
     */
    public function run(Image $image)
    {
        if ($flip = $this->getFlip()) {
            if ($flip === 'all') {
                return $image->flip('h')->flip('v');
            }

            return $image->flip($flip);
        }

        return $image;
    }

    /**
     * Resolve flip.
     * @return string The resolved flip.
     */
    public function getFlip()
    {
        if (in_array($this->flip, ['h', 'v', 'all'], true)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->flip;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
}


1		<?php
2
3		namespace League\Glide\Manipulators;
4
5		use Intervention\Image\Image;
6
7		/**
8		* @property string $or
9		*/
10		class Flip extends BaseManipulator
11		{
12		/**
13		* Perform flip image manipulation.
14		* @param Image $image The source image.
15		* @return Image The manipulated image.
16		*/
17	1	public function run(Image $image)
18		{
19	1	if ($flip = $this->getFlip()) {
20	1	if ($flip === 'all') {
21		return $image->flip('h')->flip('v');
22		}
23
24	1	return $image->flip($flip);
25		}
26
27		return $image;
28		}
29
30		/**
31		* Resolve flip.
32		* @return string The resolved flip.
33		*/
34	2	public function getFlip()
35		{
36	2	if (in_array($this->flip, ['h', 'v', 'all'], true)) {
		0 ignored issues – show Documentation introduced 2018-02-12 17:53 UTC by Report Bug Copy Issue Report The property `flip` does not exist on `object<League\Glide\Manipulators\Flip>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37	2	return $this->flip;
		0 ignored issues – show Documentation introduced 2018-02-12 17:53 UTC by Report Bug Copy Issue Report The property `flip` does not exist on `object<League\Glide\Manipulators\Flip>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38		}
39		}
40		}
41

thephpleague / glide

Pull Request — master (#221)

Flip A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like