Complex classes like Server often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Server, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class Server |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * Source file system. |
||
| 17 | * @var FilesystemInterface |
||
| 18 | */ |
||
| 19 | protected $source; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Source path prefix. |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $sourcePathPrefix; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Cache file system. |
||
| 29 | * @var FilesystemInterface |
||
| 30 | */ |
||
| 31 | protected $cache; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Cache path prefix. |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | protected $cachePathPrefix; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * Whether to group cache in folders. |
||
| 41 | * @var bool |
||
| 42 | */ |
||
| 43 | protected $groupCacheInFolders = true; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Whether to cache with file extensions. |
||
| 47 | * @var bool |
||
| 48 | */ |
||
| 49 | protected $cacheWithFileExtensions = false; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Image manipulation API. |
||
| 53 | * @var ApiInterface |
||
| 54 | */ |
||
| 55 | protected $api; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * Response factory. |
||
| 59 | * @var ResponseFactoryInterface|null |
||
| 60 | */ |
||
| 61 | protected $responseFactory; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Base URL. |
||
| 65 | * @var string |
||
| 66 | */ |
||
| 67 | protected $baseUrl; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Default image manipulations. |
||
| 71 | * @var array |
||
| 72 | */ |
||
| 73 | protected $defaults = []; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * Preset image manipulations. |
||
| 77 | * @var array |
||
| 78 | */ |
||
| 79 | protected $presets = []; |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Create Server instance. |
||
| 83 | * @param FilesystemInterface $source Source file system. |
||
| 84 | * @param FilesystemInterface $cache Cache file system. |
||
| 85 | * @param ApiInterface $api Image manipulation API. |
||
| 86 | */ |
||
| 87 | 108 | public function __construct(FilesystemInterface $source, FilesystemInterface $cache, ApiInterface $api) |
|
| 93 | |||
| 94 | /** |
||
| 95 | * Set source file system. |
||
| 96 | * @param FilesystemInterface $source Source file system. |
||
| 97 | */ |
||
| 98 | 108 | public function setSource(FilesystemInterface $source) |
|
| 102 | |||
| 103 | /** |
||
| 104 | * Get source file system. |
||
| 105 | * @return FilesystemInterface Source file system. |
||
| 106 | */ |
||
| 107 | 4 | public function getSource() |
|
| 111 | |||
| 112 | /** |
||
| 113 | * Set source path prefix. |
||
| 114 | * @param string $sourcePathPrefix Source path prefix. |
||
| 115 | */ |
||
| 116 | 10 | public function setSourcePathPrefix($sourcePathPrefix) |
|
| 120 | |||
| 121 | /** |
||
| 122 | * Get source path prefix. |
||
| 123 | * @return string Source path prefix. |
||
| 124 | */ |
||
| 125 | 4 | public function getSourcePathPrefix() |
|
| 129 | |||
| 130 | /** |
||
| 131 | * Get source path. |
||
| 132 | * @param string $path Image path. |
||
| 133 | * @return string The source path. |
||
| 134 | * @throws FileNotFoundException |
||
| 135 | */ |
||
| 136 | 52 | public function getSourcePath($path) |
|
| 156 | |||
| 157 | /** |
||
| 158 | * Check if a source file exists. |
||
| 159 | * @param string $path Image path. |
||
| 160 | * @return bool Whether the source file exists. |
||
| 161 | */ |
||
| 162 | 12 | public function sourceFileExists($path) |
|
| 166 | |||
| 167 | /** |
||
| 168 | * Set base URL. |
||
| 169 | * @param string $baseUrl Base URL. |
||
| 170 | */ |
||
| 171 | 8 | public function setBaseUrl($baseUrl) |
|
| 175 | |||
| 176 | /** |
||
| 177 | * Get base URL. |
||
| 178 | * @return string Base URL. |
||
| 179 | */ |
||
| 180 | 4 | public function getBaseUrl() |
|
| 184 | |||
| 185 | /** |
||
| 186 | * Set cache file system. |
||
| 187 | * @param FilesystemInterface $cache Cache file system. |
||
| 188 | */ |
||
| 189 | 108 | public function setCache(FilesystemInterface $cache) |
|
| 193 | |||
| 194 | /** |
||
| 195 | * Get cache file system. |
||
| 196 | * @return FilesystemInterface Cache file system. |
||
| 197 | */ |
||
| 198 | 4 | public function getCache() |
|
| 202 | |||
| 203 | /** |
||
| 204 | * Set cache path prefix. |
||
| 205 | * @param string $cachePathPrefix Cache path prefix. |
||
| 206 | */ |
||
| 207 | 8 | public function setCachePathPrefix($cachePathPrefix) |
|
| 211 | |||
| 212 | /** |
||
| 213 | * Get cache path prefix. |
||
| 214 | * @return string Cache path prefix. |
||
| 215 | */ |
||
| 216 | 4 | public function getCachePathPrefix() |
|
| 220 | |||
| 221 | /** |
||
| 222 | * Set the group cache in folders setting. |
||
| 223 | * @param bool $groupCacheInFolders Whether to group cache in folders. |
||
| 224 | */ |
||
| 225 | 10 | public function setGroupCacheInFolders($groupCacheInFolders) |
|
| 229 | |||
| 230 | /** |
||
| 231 | * Get the group cache in folders setting. |
||
| 232 | * @return bool Whether to group cache in folders. |
||
| 233 | */ |
||
| 234 | 4 | public function getGroupCacheInFolders() |
|
| 238 | |||
| 239 | /** |
||
| 240 | * Set the cache with file extensions setting. |
||
| 241 | * @param bool $cacheWithFileExtensions Whether to cache with file extensions. |
||
| 242 | */ |
||
| 243 | 14 | public function setCacheWithFileExtensions($cacheWithFileExtensions) |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Get the cache with file extensions setting. |
||
| 250 | * @return bool Whether to cache with file extensions. |
||
| 251 | */ |
||
| 252 | 4 | public function getCacheWithFileExtensions() |
|
| 256 | |||
| 257 | /** |
||
| 258 | * Get cache path. |
||
| 259 | * @param string $path Image path. |
||
| 260 | * @param array $params Image manipulation params. |
||
| 261 | * @return string Cache path. |
||
| 262 | */ |
||
| 263 | 40 | public function getCachePath($path, array $params = []) |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Check if a cache file exists. |
||
| 292 | * @param string $path Image path. |
||
| 293 | * @param array $params Image manipulation params. |
||
| 294 | * @return bool Whether the cache file exists. |
||
| 295 | */ |
||
| 296 | 22 | public function cacheFileExists($path, array $params) |
|
| 302 | |||
| 303 | /** |
||
| 304 | * Delete cached manipulations for an image. |
||
| 305 | * @param string $path Image path. |
||
| 306 | * @return bool Whether the delete succeeded. |
||
| 307 | */ |
||
| 308 | 4 | public function deleteCache($path) |
|
| 320 | |||
| 321 | /** |
||
| 322 | * Set image manipulation API. |
||
| 323 | * @param ApiInterface $api Image manipulation API. |
||
| 324 | */ |
||
| 325 | 108 | public function setApi(ApiInterface $api) |
|
| 329 | |||
| 330 | /** |
||
| 331 | * Get image manipulation API. |
||
| 332 | * @return ApiInterface Image manipulation API. |
||
| 333 | */ |
||
| 334 | 4 | public function getApi() |
|
| 338 | |||
| 339 | /** |
||
| 340 | * Set default image manipulations. |
||
| 341 | * @param array $defaults Default image manipulations. |
||
| 342 | */ |
||
| 343 | 12 | public function setDefaults(array $defaults) |
|
| 347 | |||
| 348 | /** |
||
| 349 | * Get default image manipulations. |
||
| 350 | * @return array Default image manipulations. |
||
| 351 | */ |
||
| 352 | 4 | public function getDefaults() |
|
| 356 | |||
| 357 | /** |
||
| 358 | * Set preset image manipulations. |
||
| 359 | * @param array $presets Preset image manipulations. |
||
| 360 | */ |
||
| 361 | 12 | public function setPresets(array $presets) |
|
| 365 | |||
| 366 | /** |
||
| 367 | * Get preset image manipulations. |
||
| 368 | * @return array Preset image manipulations. |
||
| 369 | */ |
||
| 370 | 4 | public function getPresets() |
|
| 374 | |||
| 375 | /** |
||
| 376 | * Get all image manipulations params, including defaults and presets. |
||
| 377 | * @param array $params Image manipulation params. |
||
| 378 | * @return array All image manipulation params. |
||
| 379 | */ |
||
| 380 | 42 | public function getAllParams(array $params) |
|
| 394 | |||
| 395 | /** |
||
| 396 | * Set response factory. |
||
| 397 | * @param ResponseFactoryInterface|null $responseFactory Response factory. |
||
| 398 | */ |
||
| 399 | 10 | public function setResponseFactory(ResponseFactoryInterface $responseFactory = null) |
|
| 403 | |||
| 404 | /** |
||
| 405 | * Get response factory. |
||
| 406 | * @return ResponseFactoryInterface Response factory. |
||
| 407 | */ |
||
| 408 | 4 | public function getResponseFactory() |
|
| 412 | |||
| 413 | /** |
||
| 414 | * Generate and return image response. |
||
| 415 | * @param string $path Image path. |
||
| 416 | * @param array $params Image manipulation params. |
||
| 417 | * @return mixed Image response. |
||
| 418 | * @throws InvalidArgumentException |
||
| 419 | */ |
||
| 420 | 4 | public function getImageResponse($path, array $params) |
|
| 432 | |||
| 433 | /** |
||
| 434 | * Generate and return Base64 encoded image. |
||
| 435 | * @param string $path Image path. |
||
| 436 | * @param array $params Image manipulation params. |
||
| 437 | * @return string Base64 encoded image. |
||
| 438 | * @throws FilesystemException |
||
| 439 | */ |
||
| 440 | 4 | public function getImageAsBase64($path, array $params) |
|
| 454 | |||
| 455 | /** |
||
| 456 | * Generate and output image. |
||
| 457 | * @param string $path Image path. |
||
| 458 | * @param array $params Image manipulation params. |
||
| 459 | * @throws InvalidArgumentException |
||
| 460 | */ |
||
| 461 | 2 | public function outputImage($path, array $params) |
|
| 478 | |||
| 479 | /** |
||
| 480 | * Generate manipulated image. |
||
| 481 | * @param string $path Image path. |
||
| 482 | * @param array $params Image manipulation params. |
||
| 483 | * @return string Cache path. |
||
| 484 | * @throws FileNotFoundException |
||
| 485 | * @throws FilesystemException |
||
| 486 | */ |
||
| 487 | 20 | public function makeImage($path, array $params) |
|
| 544 | } |
||
| 545 |