Issues in PhalconFrameworkPaginatorAdapterTest.php - Fixed Issues - Inspection of "clean up php code sniffer violations and update co..." - thephpleague/fractal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ebc071...9dcd83 )

by Tobias

created 2022-03-07 19:53 UTC

PhalconFrameworkPaginatorAdapterTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Nikolaos Dimopoulos 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace League\Fractal\Test\Pagination;

use League\Fractal\Pagination\PhalconFrameworkPaginatorAdapter;
use PHPUnit\Framework\TestCase;

class PhalconFrameworkPaginatorAdapterTest extends TestCase
{
    public function testPaginationAdapter()
    {
        $resultset = new \stdClass();
        $resultset->items       = array_fill(1, 10, 'fractal');
        $resultset->current     = 3;
        $resultset->first       = 1;
        $resultset->last        = 5;
        $resultset->next        = 4;
        $resultset->previous    = 2;
        $resultset->total_items = 50;
        $resultset->total_pages = 10;

        $adapter = new PhalconFrameworkPaginatorAdapter($resultset);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf('League\Fractal\Pagination\PaginatorInterface', $adapter);
        $this->assertSame(3, $adapter->getCurrentPage());
        $this->assertSame(10, $adapter->getCount());
        $this->assertSame(50, $adapter->getTotal());
        $this->assertSame(10, $adapter->getPerPage());
        $this->assertSame(5, $adapter->getLastPage());
        $this->assertSame(4, $adapter->getNext());
    }
}


1			<?php
2
3			namespace League\Fractal\Test\Pagination;
4
5			use League\Fractal\Pagination\PhalconFrameworkPaginatorAdapter;
6			use PHPUnit\Framework\TestCase;
7
8			class PhalconFrameworkPaginatorAdapterTest extends TestCase
9			{
10			public function testPaginationAdapter()
11			{
12			$resultset = new \stdClass();
13			$resultset->items = array_fill(1, 10, 'fractal');
14			$resultset->current = 3;
15			$resultset->first = 1;
16			$resultset->last = 5;
17			$resultset->next = 4;
18			$resultset->previous = 2;
19			$resultset->total_items = 50;
20			$resultset->total_pages = 10;
21
22			$adapter = new PhalconFrameworkPaginatorAdapter($resultset);
			0 ignored issues – show Documentation introduced 2019-06-29 17:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$resultset` is of type `object<stdClass>`, but the function expects a `object<League\Fractal\Pagination\stdClass>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			$this->assertInstanceOf('League\Fractal\Pagination\PaginatorInterface', $adapter);
24			$this->assertSame(3, $adapter->getCurrentPage());
25			$this->assertSame(10, $adapter->getCount());
26			$this->assertSame(50, $adapter->getTotal());
27			$this->assertSame(10, $adapter->getPerPage());
28			$this->assertSame(5, $adapter->getLastPage());
29			$this->assertSame(4, $adapter->getNext());
30			}
31			}
32

thephpleague / fractal

Push — master ( ebc071...9dcd83 )

PhalconFrameworkPaginatorAdapterTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like