Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | View Code Duplication | class PagerfantaPaginatorAdapter implements PaginatorInterface |
|
22 | { |
||
23 | /** |
||
24 | * The paginator instance. |
||
25 | * |
||
26 | * @var \Pagerfanta\Pagerfanta |
||
27 | */ |
||
28 | protected $paginator; |
||
29 | |||
30 | /** |
||
31 | * The route generator. |
||
32 | * |
||
33 | * @var callable |
||
34 | */ |
||
35 | protected $routeGenerator; |
||
36 | |||
37 | /** |
||
38 | * Create a new pagerfanta pagination adapter. |
||
39 | * |
||
40 | * @param \Pagerfanta\Pagerfanta $paginator |
||
41 | * @param callable $routeGenerator |
||
42 | * |
||
43 | * @return void |
||
44 | */ |
||
45 | 1 | public function __construct(Pagerfanta $paginator, $routeGenerator) |
|
46 | { |
||
47 | 1 | $this->paginator = $paginator; |
|
48 | 1 | $this->routeGenerator = $routeGenerator; |
|
49 | 1 | } |
|
50 | |||
51 | /** |
||
52 | * Get the current page. |
||
53 | * |
||
54 | * @return int |
||
55 | */ |
||
56 | 1 | public function getCurrentPage() |
|
60 | |||
61 | /** |
||
62 | * Get the last page. |
||
63 | * |
||
64 | * @return int |
||
65 | */ |
||
66 | 1 | public function getLastPage() |
|
70 | |||
71 | /** |
||
72 | * Get the total. |
||
73 | * |
||
74 | * @return int |
||
75 | */ |
||
76 | 1 | public function getTotal() |
|
80 | |||
81 | /** |
||
82 | * Get the count. |
||
83 | * |
||
84 | * @return int |
||
85 | */ |
||
86 | 1 | public function getCount() |
|
90 | |||
91 | /** |
||
92 | * Get the number per page. |
||
93 | * |
||
94 | * @return int |
||
95 | */ |
||
96 | 1 | public function getPerPage() |
|
100 | |||
101 | /** |
||
102 | * Get the url for the given page. |
||
103 | * |
||
104 | * @param int $page |
||
105 | * |
||
106 | * @return string |
||
107 | */ |
||
108 | 1 | public function getUrl($page) |
|
112 | |||
113 | /** |
||
114 | * Get the paginator instance. |
||
115 | * |
||
116 | * @return \Pagerfanta\Pagerfanta |
||
117 | */ |
||
118 | public function getPaginator() |
||
122 | |||
123 | /** |
||
124 | * Get the the route generator. |
||
125 | * |
||
126 | * @return callable |
||
127 | */ |
||
128 | public function getRouteGenerator() |
||
132 | } |
||
133 |