DataArraySerializerTest::testSerializingCollectionResource() - Code Metrics - Inspection of "Introduce Scope Factory" - thephpleague/fractal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#306)

by Benoît

created 2016-05-18 12:20 UTC

testSerializingCollectionResource() B

↳ Parent: DataArraySerializerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	95
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	2	Features	0

Metric	Value
c	2
b	2
f	0
dl	0
loc	95
rs	8.4117
cc	1
eloc	50
nc	1
nop	0

How to fix Long Method

<?php

use League\Fractal\Manager;
use League\Fractal\Resource\Collection;
use League\Fractal\Resource\Item;
use League\Fractal\Resource\NullResource;
use League\Fractal\Scope;
use League\Fractal\Serializer\DataArraySerializer;
use League\Fractal\Test\Stub\Transformer\GenericBookTransformer;

class DataArraySerializerTest extends PHPUnit_Framework_TestCase
{
    public function testSerializingItemResource()
    {
        $manager = new Manager();
        $manager->parseIncludes('author');
        $manager->setSerializer(new DataArraySerializer());

        $bookData = [
            'title' => 'Foo',
            'year' => '1991',
            '_author' => [
                'name' => 'Dave',
            ],
        ];

        // Try without metadata
        $resource = new Item($bookData, new GenericBookTransformer(), 'book');
        $scope = new Scope($manager, $resource);

        $expected = [
            'data' => [
                'title' => 'Foo',
                'year' => 1991,
                'author' => [
                    'data' => [
                        'name' => 'Dave',
                    ],
                ],
            ],
        ];

        $this->assertSame($expected, $scope->toArray());

        // Same again with metadata
        $resource = new Item($bookData, new GenericBookTransformer(), 'book');
        $resource->setMetaValue('foo', 'bar');

        $scope = new Scope($manager, $resource);


        $expected = [
            'data' => [
                'title' => 'Foo',
                'year' => 1991,
                'author' => [
                    'data' => [
                        'name' => 'Dave',

                    ],
                ],
            ],
            'meta' => [
                'foo' => 'bar',
            ],
        ];

        $this->assertSame($expected, $scope->toArray());
    }

    public function testSerializingCollectionResource()
    {
        $manager = new Manager();
        $manager->parseIncludes('author');
        $manager->setSerializer(new DataArraySerializer());

        $booksData = [
            [
                'title' => 'Foo',
                'year' => '1991',
                '_author' => [
                    'name' => 'Dave',
                ],
            ],
            [
                'title' => 'Bar',
                'year' => '1997',
                '_author' => [
                    'name' => 'Bob',
                ],
            ],
        ];

        // Try without metadata
        $resource = new Collection($booksData, new GenericBookTransformer(), 'book');

        $scope = new Scope($manager, $resource);

        $expected = [
            'data' => [
                [
                    'title' => 'Foo',
                    'year' => 1991,
                    'author' => [
                        'data' => [
                            'name' => 'Dave',
                        ],
                    ],
                ],
                [
                    'title' => 'Bar',
                    'year' => 1997,
                    'author' => [
                        'data' => [
                            'name' => 'Bob',
                        ],
                    ],
                ],
            ],
        ];

        $this->assertSame($expected, $scope->toArray());

        $expectedJson = '{"data":[{"title":"Foo","year":1991,"author":{"data":{"name":"Dave"}}},{"title":"Bar","year":1997,"author":{"data":{"name":"Bob"}}}]}';
        $this->assertSame($expectedJson, $scope->toJson());

        // Same again with meta
        $resource = new Collection($booksData, new GenericBookTransformer(), 'book');
        $resource->setMetaValue('foo', 'bar');

        $scope = new Scope($manager, $resource);


        $expected = [
            'data' => [
                [
                    'title' => 'Foo',
                    'year' => 1991,
                    'author' => [
                        'data' => [
                            'name' => 'Dave',
                        ],
                    ],
                ],
                [
                    'title' => 'Bar',
                    'year' => 1997,
                    'author' => [
                        'data' => [
                            'name' => 'Bob',

                        ],
                    ],
                ],
            ],
            'meta' => [
                'foo' => 'bar',
            ],
        ];

        $this->assertSame($expected, $scope->toArray());

        $expectedJson = '{"data":[{"title":"Foo","year":1991,"author":{"data":{"name":"Dave"}}},{"title":"Bar","year":1997,"author":{"data":{"name":"Bob"}}}],"meta":{"foo":"bar"}}';
        $this->assertSame($expectedJson, $scope->toJson());
    }

    public function testSerializingNullResource()
    {
        $manager = new Manager();
        $manager->parseIncludes('author');
        $manager->setSerializer(new DataArraySerializer());

        $bookData = [
            'title' => 'Foo',
            'year' => '1991',
            '_author' => [
                'name' => 'Dave',
            ],
        ];

        // Try without metadata
        $resource = new NullResource($bookData, new GenericBookTransformer(), 'book');
        $scope = new Scope($manager, $resource);

        $expected = [
            'data' => [],
        ];
        $this->assertSame($expected, $scope->toArray());

        // Same again with metadata
        $resource = new NullResource($bookData, new GenericBookTransformer(), 'book');
        $resource->setMetaValue('foo', 'bar');

        $scope = new Scope($manager, $resource);

        $expected = [
            'data' => [],
            'meta' => [
                'foo' => 'bar',
            ],
        ];
        $this->assertSame($expected, $scope->toArray());
    }

    public function tearDown()
    {
        Mockery::close();
    }
}


1			<?php
2
3			use League\Fractal\Manager;
4			use League\Fractal\Resource\Collection;
5			use League\Fractal\Resource\Item;
6			use League\Fractal\Resource\NullResource;
7			use League\Fractal\Scope;
8			use League\Fractal\Serializer\DataArraySerializer;
9			use League\Fractal\Test\Stub\Transformer\GenericBookTransformer;
10
11			class DataArraySerializerTest extends PHPUnit_Framework_TestCase
12			{
13			public function testSerializingItemResource()
14			{
15			$manager = new Manager();
16			$manager->parseIncludes('author');
17			$manager->setSerializer(new DataArraySerializer());
18
19			$bookData = [
20			'title' => 'Foo',
21			'year' => '1991',
22			'_author' => [
23			'name' => 'Dave',
24			],
25			];
26
27			// Try without metadata
28			$resource = new Item($bookData, new GenericBookTransformer(), 'book');
29			$scope = new Scope($manager, $resource);
30
31			$expected = [
32			'data' => [
33			'title' => 'Foo',
34			'year' => 1991,
35			'author' => [
36			'data' => [
37			'name' => 'Dave',
38			],
39			],
40			],
41			];
42
43			$this->assertSame($expected, $scope->toArray());
44
45			// Same again with metadata
46			$resource = new Item($bookData, new GenericBookTransformer(), 'book');
47			$resource->setMetaValue('foo', 'bar');
48
49			$scope = new Scope($manager, $resource);
50
51
52			$expected = [
53			'data' => [
54			'title' => 'Foo',
55			'year' => 1991,
56			'author' => [
57			'data' => [
58			'name' => 'Dave',
59
60			],
61			],
62			],
63			'meta' => [
64			'foo' => 'bar',
65			],
66			];
67
68			$this->assertSame($expected, $scope->toArray());
69			}
70
71			public function testSerializingCollectionResource()
72			{
73			$manager = new Manager();
74			$manager->parseIncludes('author');
75			$manager->setSerializer(new DataArraySerializer());
76
77			$booksData = [
78			[
79			'title' => 'Foo',
80			'year' => '1991',
81			'_author' => [
82			'name' => 'Dave',
83			],
84			],
85			[
86			'title' => 'Bar',
87			'year' => '1997',
88			'_author' => [
89			'name' => 'Bob',
90			],
91			],
92			];
93
94			// Try without metadata
95			$resource = new Collection($booksData, new GenericBookTransformer(), 'book');
96
97			$scope = new Scope($manager, $resource);
98
99			$expected = [
100			'data' => [
101			[
102			'title' => 'Foo',
103			'year' => 1991,
104			'author' => [
105			'data' => [
106			'name' => 'Dave',
107			],
108			],
109			],
110			[
111			'title' => 'Bar',
112			'year' => 1997,
113			'author' => [
114			'data' => [
115			'name' => 'Bob',
116			],
117			],
118			],
119			],
120			];
121
122			$this->assertSame($expected, $scope->toArray());
123
124			$expectedJson = '{"data":[{"title":"Foo","year":1991,"author":{"data":{"name":"Dave"}}},{"title":"Bar","year":1997,"author":{"data":{"name":"Bob"}}}]}';
125			$this->assertSame($expectedJson, $scope->toJson());
126
127			// Same again with meta
128			$resource = new Collection($booksData, new GenericBookTransformer(), 'book');
129			$resource->setMetaValue('foo', 'bar');
130
131			$scope = new Scope($manager, $resource);
132
133
134			$expected = [
135			'data' => [
136			[
137			'title' => 'Foo',
138			'year' => 1991,
139			'author' => [
140			'data' => [
141			'name' => 'Dave',
142			],
143			],
144			],
145			[
146			'title' => 'Bar',
147			'year' => 1997,
148			'author' => [
149			'data' => [
150			'name' => 'Bob',
151
152			],
153			],
154			],
155			],
156			'meta' => [
157			'foo' => 'bar',
158			],
159			];
160
161			$this->assertSame($expected, $scope->toArray());
162
163			$expectedJson = '{"data":[{"title":"Foo","year":1991,"author":{"data":{"name":"Dave"}}},{"title":"Bar","year":1997,"author":{"data":{"name":"Bob"}}}],"meta":{"foo":"bar"}}';
164			$this->assertSame($expectedJson, $scope->toJson());
165			}
166
167			public function testSerializingNullResource()
168			{
169			$manager = new Manager();
170			$manager->parseIncludes('author');
171			$manager->setSerializer(new DataArraySerializer());
172
173			$bookData = [
174			'title' => 'Foo',
175			'year' => '1991',
176			'_author' => [
177			'name' => 'Dave',
178			],
179			];
180
181			// Try without metadata
182			$resource = new NullResource($bookData, new GenericBookTransformer(), 'book');
183			$scope = new Scope($manager, $resource);
184
185			$expected = [
186			'data' => [],
187			];
188			$this->assertSame($expected, $scope->toArray());
189
190			// Same again with metadata
191			$resource = new NullResource($bookData, new GenericBookTransformer(), 'book');
192			$resource->setMetaValue('foo', 'bar');
193
194			$scope = new Scope($manager, $resource);
195
196			$expected = [
197			'data' => [],
198			'meta' => [
199			'foo' => 'bar',
200			],
201			];
202			$this->assertSame($expected, $scope->toArray());
203			}
204
205			public function tearDown()
206			{
207			Mockery::close();
208			}
209			}
210

thephpleague / fractal

Pull Request — master (#306)

testSerializingCollectionResource() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like