TestCase::expectException() - Code Metrics - thephpleague/fractal-paginator-illuminate - Measure and Improve Code Quality continuously with Scrutinizer

TestCase::expectException() A
last analyzed 2020-05-12 16:37 UTC

↳ Parent: TestCase

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	3

<?php

namespace League\Fractal\Test;

use Mockery;
use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
use PHPUnit\Framework\TestCase as PHPUnitTestCase;

class TestCase extends PHPUnitTestCase
{
    use MockeryPHPUnitIntegration;

    /**
     * Simple Mockery accessor
     *
     * @param mixed ...$args
     *
     * @return \Mockery\MockInterface
     */
    protected function getMock(...$args): Mockery\MockInterface
    {
        return Mockery::mock(...$args);
    }

    /**
     * Combined and simplified expectedException method
     *
     * @param string $exception
     * @param string|null $message
     * @param bool $regex
     */
    public function expectException(string $exception, string $message = null, bool $regex = false): void
    {
        parent::expectException($exception);

        if ($message) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if ($regex) {
                $this->expectExceptionMessageRegExp($message);
            } else {
                $this->expectExceptionMessage($message);
            }
        }
    }
}


1			<?php
2
3			namespace League\Fractal\Test;
4
5			use Mockery;
6			use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
7			use PHPUnit\Framework\TestCase as PHPUnitTestCase;
8
9			class TestCase extends PHPUnitTestCase
10			{
11			use MockeryPHPUnitIntegration;
12
13			/**
14			* Simple Mockery accessor
15			*
16			* @param mixed ...$args
17			*
18			* @return \Mockery\MockInterface
19			*/
20			protected function getMock(...$args): Mockery\MockInterface
21			{
22			return Mockery::mock(...$args);
23			}
24
25			/**
26			* Combined and simplified expectedException method
27			*
28			* @param string $exception
29			* @param string\|null $message
30			* @param bool $regex
31			*/
32			public function expectException(string $exception, string $message = null, bool $regex = false): void
33			{
34			parent::expectException($exception);
35
36			if ($message) {
			0 ignored issues – show Bug Best Practice introduced 2019-06-29 21:21 UTC by Report Bug Copy Issue Report The expression `$message` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37			if ($regex) {
38			$this->expectExceptionMessageRegExp($message);
39			} else {
40			$this->expectExceptionMessage($message);
41			}
42			}
43			}
44			}
45

thephpleague / fractal-paginator-illuminate

TestCase::expectException() A last analyzed 2020-05-12 16:37 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TestCase::expectException() A
last analyzed 2020-05-12 16:37 UTC