AzureAdapter - Code Metrics - Inspection of "Add get client and get container functionality" - thephpleague/flysystem-azure - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

unknown

created 2017-11-09 11:48 UTC

AzureAdapter B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	404
Duplicated Lines	5.2 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes

Metric	Value
wmc	38
lcom	1
cbo	15
dl	21
loc	404
rs	7.7
c	0
b	0
f	0

26 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getClient()	0	4	1
A	getContainer()	0	4	1
A	write()	0	4	1
A	writeStream()	0	4	1
A	update()	0	4	1
A	updateStream()	0	4	1
A	rename()	0	6	1
A	copy()	0	9	1
A	delete()	0	8	1
A	deleteDir()	0	17	2
A	createDir()	0	6	1
A	has()	0	16	3
A	read()	11	11	1
A	readStream()	10	10	1
B	listContents()	0	35	5
A	getMetadata()	0	9	1
A	getSize()	0	4	1
A	getMimetype()	0	4	1
A	getTimestamp()	0	4	1
A	normalize()	0	15	2
A	normalizeBlobProperties()	0	17	2
A	normalizeBlobPrefix()	0	4	1
A	streamContentsToString()	0	4	1
A	upload()	0	14	1
A	getOptionsFromConfig()	0	18	4

How to fix Duplicated Code

<?php

namespace League\Flysystem\Azure;

use League\Flysystem\Adapter\AbstractAdapter;
use League\Flysystem\Adapter\Polyfill\NotSupportingVisibilityTrait;
use League\Flysystem\Config;
use League\Flysystem\Util;
use MicrosoftAzure\Storage\Blob\Internal\IBlob;
use MicrosoftAzure\Storage\Blob\Models\BlobPrefix;
use MicrosoftAzure\Storage\Blob\Models\BlobProperties;
use MicrosoftAzure\Storage\Blob\Models\CopyBlobResult;
use MicrosoftAzure\Storage\Blob\Models\CreateBlobOptions;
use MicrosoftAzure\Storage\Blob\Models\ListBlobsOptions;
use MicrosoftAzure\Storage\Blob\Models\ListBlobsResult;
use MicrosoftAzure\Storage\Common\ServiceException;

class AzureAdapter extends AbstractAdapter
{
    use NotSupportingVisibilityTrait;

    /**
     * @var string
     */
    protected $container;

    /**
     * @var IBlob
     */
    protected $client;

    /**
     * @var string[]
     */
    protected static $metaOptions = [
        'CacheControl',
        'ContentType',
        'Metadata',
        'ContentLanguage',
        'ContentEncoding',
    ];

    /**
     * Constructor.
     *
     * @param IBlob  $azureClient
     * @param string $container
     * @param string $prefix
     */
    public function __construct(IBlob $azureClient, $container, $prefix = null)
    {
        $this->client = $azureClient;
        $this->container = $container;
        $this->setPathPrefix($prefix);
    }

    /**
     * Get the Azure client instance.
     *
     * @return IBlob
     */
    public function getClient()
    {
        return $this->client;
    }

    /**
     * Get the Azure container.
     *
     * @return string
     */
    public function getContainer()
    {
        return $this->container;
    }

    /**
     * {@inheritdoc}
     */
    public function write($path, $contents, Config $config)
    {
        return $this->upload($path, $contents, $config);
    }

    /**
     * {@inheritdoc}
     */
    public function writeStream($path, $resource, Config $config)
    {
        return $this->upload($path, $resource, $config);
    }

    /**
     * {@inheritdoc}
     */
    public function update($path, $contents, Config $config)
    {
        return $this->upload($path, $contents, $config);
    }

    /**
     * {@inheritdoc}
     */
    public function updateStream($path, $resource, Config $config)
    {
        return $this->upload($path, $resource, $config);
    }

    /**
     * {@inheritdoc}
     */
    public function rename($path, $newpath)
    {
        $this->copy($path, $newpath);

        return $this->delete($path);
    }

    public function copy($path, $newpath)
    {
        $path = $this->applyPathPrefix($path);
        $newpath = $this->applyPathPrefix($newpath);

        $this->client->copyBlob($this->container, $newpath, $this->container, $path);

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function delete($path)
    {
        $path = $this->applyPathPrefix($path);

        $this->client->deleteBlob($this->container, $path);

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function deleteDir($dirname)
    {
        $dirname = $this->applyPathPrefix($dirname);

        $options = new ListBlobsOptions();
        $options->setPrefix($dirname . '/');

        /** @var ListBlobsResult $listResults */
        $listResults = $this->client->listBlobs($this->container, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        foreach ($listResults->getBlobs() as $blob) {
            /** @var \MicrosoftAzure\Storage\Blob\Models\Blob $blob */
            $this->client->deleteBlob($this->container, $blob->getName());
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function createDir($dirname, Config $config)
    {
        $this->write(rtrim($dirname, '/') . '/', ' ', $config);

        return ['path' => $dirname, 'type' => 'dir'];
    }

    /**
     * {@inheritdoc}
     */
    public function has($path)
    {
        $path = $this->applyPathPrefix($path);

        try {
            $this->client->getBlobMetadata($this->container, $path);
        } catch (ServiceException $e) {
            if ($e->getCode() !== 404) {
                throw $e;
            }

            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function read($path)

    {
        $path = $this->applyPathPrefix($path);

        /** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobResult $blobResult */
        $blobResult = $this->client->getBlob($this->container, $path);
        $properties = $blobResult->getProperties();
        $content = $this->streamContentsToString($blobResult->getContentStream());

        return $this->normalizeBlobProperties($path, $properties) + ['contents' => $content];
    }

    /**
     * {@inheritdoc}
     */
    public function readStream($path)

    {
        $path = $this->applyPathPrefix($path);

        /** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobResult $blobResult */
        $blobResult = $this->client->getBlob($this->container, $path);
        $properties = $blobResult->getProperties();

        return $this->normalizeBlobProperties($path, $properties) + ['stream' => $blobResult->getContentStream()];
    }

    /**
     * {@inheritdoc}
     */
    public function listContents($directory = '', $recursive = false)
    {
        $directory = $this->applyPathPrefix($directory);

        // Append trailing slash only for directory other than root (which after normalization is an empty string).
        // Listing for / doesn't work properly otherwise.
        if (strlen($directory)) {
            $directory = rtrim($directory, '/') . '/';
        }

        $options = new ListBlobsOptions();
        $options->setPrefix($directory);

        if ( ! $recursive) {
            $options->setDelimiter('/');
        }

        /** @var ListBlobsResult $listResults */
        $listResults = $this->client->listBlobs($this->container, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $contents = [];

        foreach ($listResults->getBlobs() as $blob) {
            $contents[] = $this->normalizeBlobProperties($blob->getName(), $blob->getProperties());
        }

        if ( ! $recursive) {
            $contents = array_merge(
                $contents,
                array_map([$this, 'normalizeBlobPrefix'], $listResults->getBlobPrefixes())
            );
        }

        return Util::emulateDirectories($contents);
    }

    /**
     * {@inheritdoc}
     */
    public function getMetadata($path)
    {
        $path = $this->applyPathPrefix($path);

        /** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobPropertiesResult $result */
        $result = $this->client->getBlobProperties($this->container, $path);

        return $this->normalizeBlobProperties($path, $result->getProperties());
    }

    /**
     * {@inheritdoc}
     */
    public function getSize($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * {@inheritdoc}
     */
    public function getMimetype($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * {@inheritdoc}
     */
    public function getTimestamp($path)
    {
        return $this->getMetadata($path);
    }

    /**
     * Builds the normalized output array.
     *
     * @param string $path
     * @param int    $timestamp
     * @param mixed  $content
     *
     * @return array
     */
    protected function normalize($path, $timestamp, $content = null)
    {
        $data = [
            'path' => $path,
            'timestamp' => (int) $timestamp,
            'dirname' => Util::dirname($path),
            'type' => 'file',
        ];

        if (is_string($content)) {
            $data['contents'] = $content;
        }

        return $data;
    }

    /**
     * Builds the normalized output array from a Blob object.
     *
     * @param string         $path
     * @param BlobProperties $properties
     *
     * @return array
     */
    protected function normalizeBlobProperties($path, BlobProperties $properties)
    {
        if (substr($path, -1) === '/') {
            return ['type' => 'dir', 'path' => $this->removePathPrefix(rtrim($path, '/'))];
        }

        $path = $this->removePathPrefix($path);

        return [
            'path' => $path,
            'timestamp' => (int) $properties->getLastModified()->format('U'),
            'dirname' => Util::dirname($path),
            'mimetype' => $properties->getContentType(),
            'size' => $properties->getContentLength(),
            'type' => 'file',
        ];
    }

    /**
     * Builds the normalized output array from a BlobPrefix object.
     *
     * @param BlobPrefix $blobPrefix
     *
     * @return array
     */
    protected function normalizeBlobPrefix(BlobPrefix $blobPrefix)
    {
        return ['type' => 'dir', 'path' => $this->removePathPrefix(rtrim($blobPrefix->getName(), '/'))];
    }

    /**
     * Retrieves content streamed by Azure into a string.
     *
     * @param resource $resource
     *
     * @return string
     */
    protected function streamContentsToString($resource)
    {
        return stream_get_contents($resource);
    }

    /**
     * Upload a file.
     *
     * @param string          $path     Path
     * @param string|resource $contents Either a string or a stream.
     * @param Config          $config   Config
     *
     * @return array
     */
    protected function upload($path, $contents, Config $config)
    {
        $path = $this->applyPathPrefix($path);

        /** @var CopyBlobResult $result */
        $result = $this->client->createBlockBlob(
            $this->container,
            $path,
            $contents,

            $this->getOptionsFromConfig($config)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        return $this->normalize($path, $result->getLastModified()->format('U'), $contents);
    }

    /**
     * Retrieve options from a Config instance.
     *
     * @param Config $config
     *
     * @return CreateBlobOptions
     */
    protected function getOptionsFromConfig(Config $config)
    {
        $options = new CreateBlobOptions();

        foreach (static::$metaOptions as $option) {
            if ( ! $config->has($option)) {
                continue;
            }

            call_user_func([$options, "set$option"], $config->get($option));
        }

        if ($mimetype = $config->get('mimetype')) {
            $options->setContentType($mimetype);
        }

        return $options;
    }
}


1		<?php
2
3		namespace League\Flysystem\Azure;
4
5		use League\Flysystem\Adapter\AbstractAdapter;
6		use League\Flysystem\Adapter\Polyfill\NotSupportingVisibilityTrait;
7		use League\Flysystem\Config;
8		use League\Flysystem\Util;
9		use MicrosoftAzure\Storage\Blob\Internal\IBlob;
10		use MicrosoftAzure\Storage\Blob\Models\BlobPrefix;
11		use MicrosoftAzure\Storage\Blob\Models\BlobProperties;
12		use MicrosoftAzure\Storage\Blob\Models\CopyBlobResult;
13		use MicrosoftAzure\Storage\Blob\Models\CreateBlobOptions;
14		use MicrosoftAzure\Storage\Blob\Models\ListBlobsOptions;
15		use MicrosoftAzure\Storage\Blob\Models\ListBlobsResult;
16		use MicrosoftAzure\Storage\Common\ServiceException;
17
18		class AzureAdapter extends AbstractAdapter
19		{
20		use NotSupportingVisibilityTrait;
21
22		/**
23		* @var string
24		*/
25		protected $container;
26
27		/**
28		* @var IBlob
29		*/
30		protected $client;
31
32		/**
33		* @var string[]
34		*/
35		protected static $metaOptions = [
36		'CacheControl',
37		'ContentType',
38		'Metadata',
39		'ContentLanguage',
40		'ContentEncoding',
41		];
42
43		/**
44		* Constructor.
45		*
46		* @param IBlob $azureClient
47		* @param string $container
48		* @param string $prefix
49		*/
50		public function __construct(IBlob $azureClient, $container, $prefix = null)
51		{
52		$this->client = $azureClient;
53		$this->container = $container;
54		$this->setPathPrefix($prefix);
55		}
56
57		/**
58		* Get the Azure client instance.
59		*
60		* @return IBlob
61		*/
62		public function getClient()
63		{
64		return $this->client;
65		}
66
67		/**
68		* Get the Azure container.
69		*
70		* @return string
71		*/
72		public function getContainer()
73		{
74		return $this->container;
75		}
76
77		/**
78		* {@inheritdoc}
79		*/
80		public function write($path, $contents, Config $config)
81		{
82		return $this->upload($path, $contents, $config);
83		}
84
85		/**
86		* {@inheritdoc}
87		*/
88		public function writeStream($path, $resource, Config $config)
89		{
90		return $this->upload($path, $resource, $config);
91		}
92
93		/**
94		* {@inheritdoc}
95		*/
96		public function update($path, $contents, Config $config)
97		{
98		return $this->upload($path, $contents, $config);
99		}
100
101		/**
102		* {@inheritdoc}
103		*/
104		public function updateStream($path, $resource, Config $config)
105		{
106		return $this->upload($path, $resource, $config);
107		}
108
109		/**
110		* {@inheritdoc}
111		*/
112		public function rename($path, $newpath)
113		{
114		$this->copy($path, $newpath);
115
116		return $this->delete($path);
117		}
118
119		public function copy($path, $newpath)
120		{
121		$path = $this->applyPathPrefix($path);
122		$newpath = $this->applyPathPrefix($newpath);
123
124		$this->client->copyBlob($this->container, $newpath, $this->container, $path);
125
126		return true;
127		}
128
129		/**
130		* {@inheritdoc}
131		*/
132		public function delete($path)
133		{
134		$path = $this->applyPathPrefix($path);
135
136		$this->client->deleteBlob($this->container, $path);
137
138		return true;
139		}
140
141		/**
142		* {@inheritdoc}
143		*/
144		public function deleteDir($dirname)
145		{
146		$dirname = $this->applyPathPrefix($dirname);
147
148		$options = new ListBlobsOptions();
149		$options->setPrefix($dirname . '/');
150
151		/** @var ListBlobsResult $listResults */
152		$listResults = $this->client->listBlobs($this->container, $options);
		0 ignored issues – show Documentation introduced 2016-12-07 09:55 UTC by Report Bug Copy Issue Report `$options` is of type `object<MicrosoftAzure\St...odels\ListBlobsOptions>`, but the function expects a `object<MicrosoftAzure\St...\ListBlobsOptions>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
153
154		foreach ($listResults->getBlobs() as $blob) {
155		/** @var \MicrosoftAzure\Storage\Blob\Models\Blob $blob */
156		$this->client->deleteBlob($this->container, $blob->getName());
157		}
158
159		return true;
160		}
161
162		/**
163		* {@inheritdoc}
164		*/
165		public function createDir($dirname, Config $config)
166		{
167		$this->write(rtrim($dirname, '/') . '/', ' ', $config);
168
169		return ['path' => $dirname, 'type' => 'dir'];
170		}
171
172		/**
173		* {@inheritdoc}
174		*/
175		public function has($path)
176		{
177		$path = $this->applyPathPrefix($path);
178
179		try {
180		$this->client->getBlobMetadata($this->container, $path);
181		} catch (ServiceException $e) {
182		if ($e->getCode() !== 404) {
183		throw $e;
184		}
185
186		return false;
187		}
188
189		return true;
190		}
191
192		/**
193		* {@inheritdoc}
194		*/
195	View Code Duplication	public function read($path)
		0 ignored issues – show Duplication introduced 2017-08-16 08:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
196		{
197		$path = $this->applyPathPrefix($path);
198
199		/** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobResult $blobResult */
200		$blobResult = $this->client->getBlob($this->container, $path);
201		$properties = $blobResult->getProperties();
202		$content = $this->streamContentsToString($blobResult->getContentStream());
203
204		return $this->normalizeBlobProperties($path, $properties) + ['contents' => $content];
205		}
206
207		/**
208		* {@inheritdoc}
209		*/
210	View Code Duplication	public function readStream($path)
		0 ignored issues – show Duplication introduced 2017-08-16 08:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
211		{
212		$path = $this->applyPathPrefix($path);
213
214		/** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobResult $blobResult */
215		$blobResult = $this->client->getBlob($this->container, $path);
216		$properties = $blobResult->getProperties();
217
218		return $this->normalizeBlobProperties($path, $properties) + ['stream' => $blobResult->getContentStream()];
219		}
220
221		/**
222		* {@inheritdoc}
223		*/
224		public function listContents($directory = '', $recursive = false)
225		{
226		$directory = $this->applyPathPrefix($directory);
227
228		// Append trailing slash only for directory other than root (which after normalization is an empty string).
229		// Listing for / doesn't work properly otherwise.
230		if (strlen($directory)) {
231		$directory = rtrim($directory, '/') . '/';
232		}
233
234		$options = new ListBlobsOptions();
235		$options->setPrefix($directory);
236
237		if ( ! $recursive) {
238		$options->setDelimiter('/');
239		}
240
241		/** @var ListBlobsResult $listResults */
242		$listResults = $this->client->listBlobs($this->container, $options);
		0 ignored issues – show Documentation introduced 2016-12-07 09:55 UTC by Report Bug Copy Issue Report `$options` is of type `object<MicrosoftAzure\St...odels\ListBlobsOptions>`, but the function expects a `object<MicrosoftAzure\St...\ListBlobsOptions>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
243
244		$contents = [];
245
246		foreach ($listResults->getBlobs() as $blob) {
247		$contents[] = $this->normalizeBlobProperties($blob->getName(), $blob->getProperties());
248		}
249
250		if ( ! $recursive) {
251		$contents = array_merge(
252		$contents,
253		array_map([$this, 'normalizeBlobPrefix'], $listResults->getBlobPrefixes())
254		);
255		}
256
257		return Util::emulateDirectories($contents);
258		}
259
260		/**
261		* {@inheritdoc}
262		*/
263		public function getMetadata($path)
264		{
265		$path = $this->applyPathPrefix($path);
266
267		/** @var \MicrosoftAzure\Storage\Blob\Models\GetBlobPropertiesResult $result */
268		$result = $this->client->getBlobProperties($this->container, $path);
269
270		return $this->normalizeBlobProperties($path, $result->getProperties());
271		}
272
273		/**
274		* {@inheritdoc}
275		*/
276		public function getSize($path)
277		{
278		return $this->getMetadata($path);
279		}
280
281		/**
282		* {@inheritdoc}
283		*/
284		public function getMimetype($path)
285		{
286		return $this->getMetadata($path);
287		}
288
289		/**
290		* {@inheritdoc}
291		*/
292		public function getTimestamp($path)
293		{
294		return $this->getMetadata($path);
295		}
296
297		/**
298		* Builds the normalized output array.
299		*
300		* @param string $path
301		* @param int $timestamp
302		* @param mixed $content
303		*
304		* @return array
305		*/
306		protected function normalize($path, $timestamp, $content = null)
307		{
308		$data = [
309		'path' => $path,
310		'timestamp' => (int) $timestamp,
311		'dirname' => Util::dirname($path),
312		'type' => 'file',
313		];
314
315		if (is_string($content)) {
316		$data['contents'] = $content;
317		}
318
319		return $data;
320		}
321
322		/**
323		* Builds the normalized output array from a Blob object.
324		*
325		* @param string $path
326		* @param BlobProperties $properties
327		*
328		* @return array
329		*/
330		protected function normalizeBlobProperties($path, BlobProperties $properties)
331		{
332		if (substr($path, -1) === '/') {
333		return ['type' => 'dir', 'path' => $this->removePathPrefix(rtrim($path, '/'))];
334		}
335
336		$path = $this->removePathPrefix($path);
337
338		return [
339		'path' => $path,
340		'timestamp' => (int) $properties->getLastModified()->format('U'),
341		'dirname' => Util::dirname($path),
342		'mimetype' => $properties->getContentType(),
343		'size' => $properties->getContentLength(),
344		'type' => 'file',
345		];
346		}
347
348		/**
349		* Builds the normalized output array from a BlobPrefix object.
350		*
351		* @param BlobPrefix $blobPrefix
352		*
353		* @return array
354		*/
355		protected function normalizeBlobPrefix(BlobPrefix $blobPrefix)
356		{
357		return ['type' => 'dir', 'path' => $this->removePathPrefix(rtrim($blobPrefix->getName(), '/'))];
358		}
359
360		/**
361		* Retrieves content streamed by Azure into a string.
362		*
363		* @param resource $resource
364		*
365		* @return string
366		*/
367		protected function streamContentsToString($resource)
368		{
369		return stream_get_contents($resource);
370		}
371
372		/**
373		* Upload a file.
374		*
375		* @param string $path Path
376		* @param string\|resource $contents Either a string or a stream.
377		* @param Config $config Config
378		*
379		* @return array
380		*/
381		protected function upload($path, $contents, Config $config)
382		{
383		$path = $this->applyPathPrefix($path);
384
385		/** @var CopyBlobResult $result */
386		$result = $this->client->createBlockBlob(
387		$this->container,
388		$path,
389		$contents,
		0 ignored issues – show Bug introduced 2016-12-07 09:55 UTC by Report Bug Copy Issue Report It seems like `$contents` defined by parameter `$contents` on line 381 can also be of type `resource`; however, `MicrosoftAzure\Storage\B...Blob::createBlockBlob()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
390		$this->getOptionsFromConfig($config)
		0 ignored issues – show Documentation introduced 2016-12-07 09:55 UTC by Report Bug Copy Issue Report `$this->getOptionsFromConfig($config)` is of type `object<MicrosoftAzure\St...dels\CreateBlobOptions>`, but the function expects a `object<MicrosoftAzure\St...CreateBlobOptions>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
391		);
392
393		return $this->normalize($path, $result->getLastModified()->format('U'), $contents);
394		}
395
396		/**
397		* Retrieve options from a Config instance.
398		*
399		* @param Config $config
400		*
401		* @return CreateBlobOptions
402		*/
403		protected function getOptionsFromConfig(Config $config)
404		{
405		$options = new CreateBlobOptions();
406
407		foreach (static::$metaOptions as $option) {
408		if ( ! $config->has($option)) {
409		continue;
410		}
411
412		call_user_func([$options, "set$option"], $config->get($option));
413		}
414
415		if ($mimetype = $config->get('mimetype')) {
416		$options->setContentType($mimetype);
417		}
418
419		return $options;
420		}
421		}
422

thephpleague / flysystem-azure

Pull Request — master (#27)

AzureAdapter B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

26 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like