Complex classes like AwsS3Adapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AwsS3Adapter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class AwsS3Adapter extends AbstractAdapter implements CanOverwriteFiles |
||
17 | { |
||
18 | const PUBLIC_GRANT_URI = 'http://acs.amazonaws.com/groups/global/AllUsers'; |
||
19 | |||
20 | /** |
||
21 | * @var array |
||
22 | */ |
||
23 | protected static $resultMap = [ |
||
24 | 'Body' => 'contents', |
||
25 | 'ContentLength' => 'size', |
||
26 | 'ContentType' => 'mimetype', |
||
27 | 'Size' => 'size', |
||
28 | 'Metadata' => 'metadata', |
||
29 | 'StorageClass' => 'storageclass', |
||
30 | 'ETag' => 'etag', |
||
31 | 'VersionId' => 'versionid' |
||
32 | ]; |
||
33 | |||
34 | /** |
||
35 | * @var array |
||
36 | */ |
||
37 | protected static $metaOptions = [ |
||
38 | 'ACL', |
||
39 | 'CacheControl', |
||
40 | 'ContentDisposition', |
||
41 | 'ContentEncoding', |
||
42 | 'ContentLength', |
||
43 | 'ContentType', |
||
44 | 'Expires', |
||
45 | 'GrantFullControl', |
||
46 | 'GrantRead', |
||
47 | 'GrantReadACP', |
||
48 | 'GrantWriteACP', |
||
49 | 'Metadata', |
||
50 | 'RequestPayer', |
||
51 | 'SSECustomerAlgorithm', |
||
52 | 'SSECustomerKey', |
||
53 | 'SSECustomerKeyMD5', |
||
54 | 'SSEKMSKeyId', |
||
55 | 'ServerSideEncryption', |
||
56 | 'StorageClass', |
||
57 | 'Tagging', |
||
58 | 'WebsiteRedirectLocation', |
||
59 | ]; |
||
60 | |||
61 | /** |
||
62 | * @var S3Client |
||
63 | */ |
||
64 | protected $s3Client; |
||
65 | |||
66 | /** |
||
67 | * @var string |
||
68 | */ |
||
69 | protected $bucket; |
||
70 | |||
71 | /** |
||
72 | * @var array |
||
73 | */ |
||
74 | protected $options = []; |
||
75 | |||
76 | /** |
||
77 | * Constructor. |
||
78 | * |
||
79 | * @param S3Client $client |
||
80 | * @param string $bucket |
||
81 | * @param string $prefix |
||
82 | * @param array $options |
||
83 | */ |
||
84 | 76 | public function __construct(S3Client $client, $bucket, $prefix = '', array $options = []) |
|
91 | |||
92 | /** |
||
93 | * Get the S3Client bucket. |
||
94 | * |
||
95 | * @return string |
||
96 | */ |
||
97 | 4 | public function getBucket() |
|
101 | |||
102 | /** |
||
103 | * Set the S3Client bucket. |
||
104 | * |
||
105 | * @return string |
||
106 | */ |
||
107 | 2 | public function setBucket($bucket) |
|
111 | |||
112 | /** |
||
113 | * Get the S3Client instance. |
||
114 | * |
||
115 | * @return S3Client |
||
116 | */ |
||
117 | 2 | public function getClient() |
|
121 | |||
122 | /** |
||
123 | * Write a new file. |
||
124 | * |
||
125 | * @param string $path |
||
126 | * @param string $contents |
||
127 | * @param Config $config Config object |
||
128 | * |
||
129 | * @return false|array false on failure file meta data on success |
||
130 | */ |
||
131 | 6 | public function write($path, $contents, Config $config) |
|
135 | |||
136 | /** |
||
137 | * Update a file. |
||
138 | * |
||
139 | * @param string $path |
||
140 | * @param string $contents |
||
141 | * @param Config $config Config object |
||
142 | * |
||
143 | * @return false|array false on failure file meta data on success |
||
144 | */ |
||
145 | 4 | public function update($path, $contents, Config $config) |
|
149 | |||
150 | /** |
||
151 | * Rename a file. |
||
152 | * |
||
153 | * @param string $path |
||
154 | * @param string $newpath |
||
155 | * |
||
156 | * @return bool |
||
157 | */ |
||
158 | 4 | public function rename($path, $newpath) |
|
166 | |||
167 | /** |
||
168 | * Delete a file. |
||
169 | * |
||
170 | * @param string $path |
||
171 | * |
||
172 | * @return bool |
||
173 | */ |
||
174 | 4 | public function delete($path) |
|
190 | |||
191 | /** |
||
192 | * Delete a directory. |
||
193 | * |
||
194 | * @param string $dirname |
||
195 | * |
||
196 | * @return bool |
||
197 | */ |
||
198 | 4 | public function deleteDir($dirname) |
|
209 | |||
210 | /** |
||
211 | * Create a directory. |
||
212 | * |
||
213 | * @param string $dirname directory name |
||
214 | * @param Config $config |
||
215 | * |
||
216 | * @return bool|array |
||
217 | */ |
||
218 | 4 | public function createDir($dirname, Config $config) |
|
222 | |||
223 | /** |
||
224 | * Check whether a file exists. |
||
225 | * |
||
226 | * @param string $path |
||
227 | * |
||
228 | * @return bool |
||
229 | */ |
||
230 | 12 | public function has($path) |
|
240 | |||
241 | /** |
||
242 | * Read a file. |
||
243 | * |
||
244 | * @param string $path |
||
245 | * |
||
246 | * @return false|array |
||
247 | */ |
||
248 | 6 | public function read($path) |
|
258 | |||
259 | /** |
||
260 | * List contents of a directory. |
||
261 | * |
||
262 | * @param string $directory |
||
263 | * @param bool $recursive |
||
264 | * |
||
265 | * @return array |
||
266 | */ |
||
267 | 4 | public function listContents($directory = '', $recursive = false) |
|
282 | |||
283 | /** |
||
284 | * @param array $options |
||
285 | * |
||
286 | * @return array |
||
287 | */ |
||
288 | 4 | protected function retrievePaginatedListing(array $options) |
|
299 | |||
300 | /** |
||
301 | * Get all the meta data of a file or directory. |
||
302 | * |
||
303 | * @param string $path |
||
304 | * |
||
305 | * @return false|array |
||
306 | */ |
||
307 | 14 | public function getMetadata($path) |
|
308 | { |
||
309 | 14 | $command = $this->s3Client->getCommand( |
|
310 | 14 | 'headObject', |
|
311 | [ |
||
312 | 14 | 'Bucket' => $this->bucket, |
|
313 | 14 | 'Key' => $this->applyPathPrefix($path), |
|
314 | 14 | ] + $this->options |
|
315 | 7 | ); |
|
316 | |||
317 | /* @var Result $result */ |
||
318 | try { |
||
319 | 14 | $result = $this->s3Client->execute($command); |
|
320 | 9 | } catch (S3Exception $exception) { |
|
321 | 4 | if ($this->is404Exception($exception)) { |
|
322 | 2 | return false; |
|
323 | } |
||
324 | |||
325 | 2 | throw $exception; |
|
326 | } |
||
327 | |||
328 | 10 | return $this->normalizeResponse($result->toArray(), $path); |
|
329 | } |
||
330 | |||
331 | /** |
||
332 | * @return bool |
||
333 | */ |
||
334 | 4 | private function is404Exception(S3Exception $exception) |
|
344 | |||
345 | /** |
||
346 | * Get all the meta data of a file or directory. |
||
347 | * |
||
348 | * @param string $path |
||
349 | * |
||
350 | * @return false|array |
||
351 | */ |
||
352 | 2 | public function getSize($path) |
|
356 | |||
357 | /** |
||
358 | * Get the mimetype of a file. |
||
359 | * |
||
360 | * @param string $path |
||
361 | * |
||
362 | * @return false|array |
||
363 | */ |
||
364 | 2 | public function getMimetype($path) |
|
368 | |||
369 | /** |
||
370 | * Get the timestamp of a file. |
||
371 | * |
||
372 | * @param string $path |
||
373 | * |
||
374 | * @return false|array |
||
375 | */ |
||
376 | 2 | public function getTimestamp($path) |
|
380 | |||
381 | /** |
||
382 | * Write a new file using a stream. |
||
383 | * |
||
384 | * @param string $path |
||
385 | * @param resource $resource |
||
386 | * @param Config $config Config object |
||
387 | * |
||
388 | * @return array|false false on failure file meta data on success |
||
389 | */ |
||
390 | 4 | public function writeStream($path, $resource, Config $config) |
|
394 | |||
395 | /** |
||
396 | * Update a file using a stream. |
||
397 | * |
||
398 | * @param string $path |
||
399 | * @param resource $resource |
||
400 | * @param Config $config Config object |
||
401 | * |
||
402 | * @return array|false false on failure file meta data on success |
||
403 | */ |
||
404 | 4 | public function updateStream($path, $resource, Config $config) |
|
408 | |||
409 | /** |
||
410 | * Copy a file. |
||
411 | * |
||
412 | * @param string $path |
||
413 | * @param string $newpath |
||
414 | * |
||
415 | * @return bool |
||
416 | */ |
||
417 | 8 | public function copy($path, $newpath) |
|
418 | { |
||
419 | 8 | $command = $this->s3Client->getCommand( |
|
420 | 8 | 'copyObject', |
|
421 | [ |
||
422 | 8 | 'Bucket' => $this->bucket, |
|
423 | 8 | 'Key' => $this->applyPathPrefix($newpath), |
|
424 | 8 | 'CopySource' => urlencode($this->bucket . '/' . $this->applyPathPrefix($path)), |
|
425 | 8 | 'ACL' => $this->getRawVisibility($path) === AdapterInterface::VISIBILITY_PUBLIC |
|
426 | 8 | ? 'public-read' : 'private', |
|
427 | 8 | ] + $this->options |
|
428 | 4 | ); |
|
429 | |||
430 | try { |
||
431 | 8 | $this->s3Client->execute($command); |
|
432 | 6 | } catch (S3Exception $e) { |
|
433 | 4 | return false; |
|
434 | } |
||
435 | |||
436 | 4 | return true; |
|
437 | } |
||
438 | |||
439 | /** |
||
440 | * Read a file as a stream. |
||
441 | * |
||
442 | * @param string $path |
||
443 | * |
||
444 | * @return array|false |
||
445 | */ |
||
446 | 6 | public function readStream($path) |
|
447 | { |
||
448 | 6 | $response = $this->readObject($path); |
|
449 | |||
450 | 6 | if ($response !== false) { |
|
451 | 6 | $response['stream'] = $response['contents']->detach(); |
|
452 | 6 | unset($response['contents']); |
|
453 | 3 | } |
|
454 | |||
455 | 6 | return $response; |
|
456 | } |
||
457 | |||
458 | /** |
||
459 | * Read an object and normalize the response. |
||
460 | * |
||
461 | * @param $path |
||
462 | * |
||
463 | * @return array|bool |
||
464 | */ |
||
465 | 10 | protected function readObject($path) |
|
466 | { |
||
467 | $options = [ |
||
468 | 10 | 'Bucket' => $this->bucket, |
|
469 | 10 | 'Key' => $this->applyPathPrefix($path), |
|
470 | 5 | ]; |
|
471 | |||
472 | 10 | if (isset($this->options['@http'])) { |
|
473 | 2 | $options['@http'] = $this->options['@http']; |
|
474 | 1 | } |
|
475 | |||
476 | 10 | $command = $this->s3Client->getCommand('getObject', $options + $this->options); |
|
477 | |||
478 | try { |
||
479 | /** @var Result $response */ |
||
480 | 10 | $response = $this->s3Client->execute($command); |
|
481 | 6 | } catch (S3Exception $e) { |
|
482 | 2 | return false; |
|
483 | } |
||
484 | |||
485 | 8 | return $this->normalizeResponse($response->toArray(), $path); |
|
486 | } |
||
487 | |||
488 | /** |
||
489 | * Set the visibility for a file. |
||
490 | * |
||
491 | * @param string $path |
||
492 | * @param string $visibility |
||
493 | * |
||
494 | * @return array|false file meta data |
||
495 | */ |
||
496 | 6 | public function setVisibility($path, $visibility) |
|
497 | { |
||
498 | 6 | $command = $this->s3Client->getCommand( |
|
499 | 6 | 'putObjectAcl', |
|
500 | [ |
||
501 | 6 | 'Bucket' => $this->bucket, |
|
502 | 6 | 'Key' => $this->applyPathPrefix($path), |
|
503 | 6 | 'ACL' => $visibility === AdapterInterface::VISIBILITY_PUBLIC ? 'public-read' : 'private', |
|
504 | ] |
||
505 | 3 | ); |
|
506 | |||
507 | try { |
||
508 | 6 | $this->s3Client->execute($command); |
|
509 | 4 | } catch (S3Exception $exception) { |
|
510 | 2 | return false; |
|
511 | } |
||
512 | |||
513 | 4 | return compact('path', 'visibility'); |
|
514 | } |
||
515 | |||
516 | /** |
||
517 | * Get the visibility of a file. |
||
518 | * |
||
519 | * @param string $path |
||
520 | * |
||
521 | * @return array|false |
||
522 | */ |
||
523 | 4 | public function getVisibility($path) |
|
527 | |||
528 | /** |
||
529 | * {@inheritdoc} |
||
530 | */ |
||
531 | 68 | public function applyPathPrefix($path) |
|
535 | |||
536 | /** |
||
537 | * {@inheritdoc} |
||
538 | */ |
||
539 | 76 | public function setPathPrefix($prefix) |
|
545 | |||
546 | /** |
||
547 | * Get the object acl presented as a visibility. |
||
548 | * |
||
549 | * @param string $path |
||
550 | * |
||
551 | * @return string |
||
552 | */ |
||
553 | 12 | protected function getRawVisibility($path) |
|
579 | |||
580 | /** |
||
581 | * Upload an object. |
||
582 | * |
||
583 | * @param $path |
||
584 | * @param $body |
||
585 | * @param Config $config |
||
586 | * |
||
587 | * @return array|bool |
||
588 | */ |
||
589 | 14 | protected function upload($path, $body, Config $config) |
|
617 | |||
618 | /** |
||
619 | * Check if the path contains only directories |
||
620 | * |
||
621 | * @param string $path |
||
622 | * @return bool |
||
623 | */ |
||
624 | 30 | private function isOnlyDir($path) |
|
628 | |||
629 | /** |
||
630 | * Get options from the config. |
||
631 | * |
||
632 | * @param Config $config |
||
633 | * |
||
634 | * @return array |
||
635 | */ |
||
636 | 14 | protected function getOptionsFromConfig(Config $config) |
|
663 | |||
664 | /** |
||
665 | * Normalize the object result array. |
||
666 | * |
||
667 | * @param array $response |
||
668 | * @param string $path |
||
669 | * |
||
670 | * @return array |
||
671 | */ |
||
672 | 28 | protected function normalizeResponse(array $response, $path = null) |
|
694 | |||
695 | /** |
||
696 | * @param $location |
||
697 | * |
||
698 | * @return bool |
||
699 | */ |
||
700 | 10 | protected function doesDirectoryExist($location) |
|
725 | } |
||
726 |