Complex classes like AwsS3Adapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AwsS3Adapter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class AwsS3Adapter extends AbstractAdapter implements CanOverwriteFiles |
||
17 | { |
||
18 | const PUBLIC_GRANT_URI = 'http://acs.amazonaws.com/groups/global/AllUsers'; |
||
19 | |||
20 | /** |
||
21 | * @var array |
||
22 | */ |
||
23 | protected static $resultMap = [ |
||
24 | 'Body' => 'contents', |
||
25 | 'ContentLength' => 'size', |
||
26 | 'ContentType' => 'mimetype', |
||
27 | 'Size' => 'size', |
||
28 | 'Metadata' => 'metadata', |
||
29 | 'StorageClass' => 'storageclass', |
||
30 | 'ETag' => 'etag', |
||
31 | 'VersionId' => 'versionid' |
||
32 | ]; |
||
33 | |||
34 | /** |
||
35 | * @var array |
||
36 | */ |
||
37 | protected static $metaOptions = [ |
||
38 | 'ACL', |
||
39 | 'CacheControl', |
||
40 | 'ContentDisposition', |
||
41 | 'ContentEncoding', |
||
42 | 'ContentLength', |
||
43 | 'ContentType', |
||
44 | 'Expires', |
||
45 | 'GrantFullControl', |
||
46 | 'GrantRead', |
||
47 | 'GrantReadACP', |
||
48 | 'GrantWriteACP', |
||
49 | 'Metadata', |
||
50 | 'RequestPayer', |
||
51 | 'SSECustomerAlgorithm', |
||
52 | 'SSECustomerKey', |
||
53 | 'SSECustomerKeyMD5', |
||
54 | 'SSEKMSKeyId', |
||
55 | 'ServerSideEncryption', |
||
56 | 'StorageClass', |
||
57 | 'Tagging', |
||
58 | 'WebsiteRedirectLocation', |
||
59 | ]; |
||
60 | |||
61 | /** |
||
62 | * @var S3Client |
||
63 | */ |
||
64 | protected $s3Client; |
||
65 | |||
66 | /** |
||
67 | * @var string |
||
68 | */ |
||
69 | protected $bucket; |
||
70 | |||
71 | /** |
||
72 | * @var array |
||
73 | */ |
||
74 | protected $options = []; |
||
75 | |||
76 | /** |
||
77 | * Constructor. |
||
78 | * |
||
79 | * @param S3Client $client |
||
80 | * @param string $bucket |
||
81 | * @param string $prefix |
||
82 | * @param array $options |
||
83 | */ |
||
84 | 76 | public function __construct(S3Client $client, $bucket, $prefix = '', array $options = []) |
|
91 | |||
92 | /** |
||
93 | * Get the S3Client bucket. |
||
94 | * |
||
95 | * @return string |
||
96 | */ |
||
97 | 4 | public function getBucket() |
|
101 | |||
102 | /** |
||
103 | * Set the S3Client bucket. |
||
104 | * |
||
105 | * @return string |
||
106 | */ |
||
107 | 2 | public function setBucket($bucket) |
|
111 | |||
112 | /** |
||
113 | * Get the S3Client instance. |
||
114 | * |
||
115 | * @return S3Client |
||
116 | */ |
||
117 | 2 | public function getClient() |
|
121 | |||
122 | /** |
||
123 | * Write a new file. |
||
124 | * |
||
125 | * @param string $path |
||
126 | * @param string $contents |
||
127 | * @param Config $config Config object |
||
128 | * |
||
129 | * @return false|array false on failure file meta data on success |
||
130 | */ |
||
131 | 6 | public function write($path, $contents, Config $config) |
|
135 | |||
136 | /** |
||
137 | * Update a file. |
||
138 | * |
||
139 | * @param string $path |
||
140 | * @param string $contents |
||
141 | * @param Config $config Config object |
||
142 | * |
||
143 | * @return false|array false on failure file meta data on success |
||
144 | */ |
||
145 | 4 | public function update($path, $contents, Config $config) |
|
149 | |||
150 | /** |
||
151 | * Rename a file. |
||
152 | * |
||
153 | * @param string $path |
||
154 | * @param string $newpath |
||
155 | * |
||
156 | * @return bool |
||
157 | */ |
||
158 | 4 | public function rename($path, $newpath) |
|
166 | |||
167 | /** |
||
168 | * Delete a file. |
||
169 | * |
||
170 | * @param string $path |
||
171 | * |
||
172 | * @return bool |
||
173 | */ |
||
174 | 4 | public function delete($path) |
|
175 | { |
||
176 | 4 | $location = $this->applyPathPrefix($path); |
|
177 | |||
178 | 4 | $command = $this->s3Client->getCommand( |
|
179 | 4 | 'deleteObject', |
|
180 | [ |
||
181 | 4 | 'Bucket' => $this->bucket, |
|
182 | 4 | 'Key' => $location, |
|
183 | ] |
||
184 | ); |
||
185 | |||
186 | 4 | $this->s3Client->execute($command); |
|
187 | |||
188 | 4 | return ! $this->has($path); |
|
189 | } |
||
190 | |||
191 | /** |
||
192 | * Delete a directory. |
||
193 | * |
||
194 | * @param string $dirname |
||
195 | * |
||
196 | * @return bool |
||
197 | */ |
||
198 | 4 | public function deleteDir($dirname) |
|
209 | |||
210 | /** |
||
211 | * Create a directory. |
||
212 | * |
||
213 | * @param string $dirname directory name |
||
214 | * @param Config $config |
||
215 | * |
||
216 | * @return bool|array |
||
217 | */ |
||
218 | 4 | public function createDir($dirname, Config $config) |
|
222 | |||
223 | /** |
||
224 | * Check whether a file exists. |
||
225 | * |
||
226 | * @param string $path |
||
227 | * |
||
228 | * @return bool |
||
229 | */ |
||
230 | 12 | public function has($path) |
|
240 | |||
241 | /** |
||
242 | * Read a file. |
||
243 | * |
||
244 | * @param string $path |
||
245 | * |
||
246 | * @return false|array |
||
247 | */ |
||
248 | 6 | public function read($path) |
|
249 | { |
||
250 | 6 | $response = $this->readObject($path); |
|
251 | |||
252 | 6 | if ($response !== false) { |
|
253 | 4 | $response['contents'] = $response['contents']->getContents(); |
|
254 | } |
||
255 | |||
256 | 6 | return $response; |
|
257 | } |
||
258 | |||
259 | /** |
||
260 | * List contents of a directory. |
||
261 | * |
||
262 | * @param string $directory |
||
263 | * @param bool $recursive |
||
264 | * |
||
265 | * @return array |
||
266 | */ |
||
267 | 4 | public function listContents($directory = '', $recursive = false) |
|
268 | { |
||
269 | 4 | $prefix = $this->applyPathPrefix(rtrim($directory, '/') . '/'); |
|
270 | 4 | $options = ['Bucket' => $this->bucket, 'Prefix' => ltrim($prefix, '/')]; |
|
271 | |||
272 | 4 | if ($recursive === false) { |
|
273 | 4 | $options['Delimiter'] = '/'; |
|
274 | } |
||
275 | |||
276 | 4 | $listing = $this->retrievePaginatedListing($options); |
|
277 | 4 | $normalizer = [$this, 'normalizeResponse']; |
|
278 | 4 | $normalized = array_map($normalizer, $listing); |
|
279 | |||
280 | 4 | return Util::emulateDirectories($normalized); |
|
281 | } |
||
282 | |||
283 | /** |
||
284 | * @param array $options |
||
285 | * |
||
286 | * @return array |
||
287 | */ |
||
288 | 4 | protected function retrievePaginatedListing(array $options) |
|
289 | { |
||
290 | 4 | $resultPaginator = $this->s3Client->getPaginator('ListObjects', $options); |
|
291 | 4 | $listing = []; |
|
292 | |||
293 | 4 | foreach ($resultPaginator as $result) { |
|
294 | 4 | $listing = array_merge($listing, $result->get('Contents') ?: [], $result->get('CommonPrefixes') ?: []); |
|
295 | } |
||
296 | |||
297 | 4 | return $listing; |
|
298 | } |
||
299 | |||
300 | /** |
||
301 | * Get all the meta data of a file or directory. |
||
302 | * |
||
303 | * @param string $path |
||
304 | * |
||
305 | * @return false|array |
||
306 | */ |
||
307 | 14 | public function getMetadata($path) |
|
308 | { |
||
309 | 14 | $command = $this->s3Client->getCommand( |
|
310 | 14 | 'headObject', |
|
311 | [ |
||
312 | 14 | 'Bucket' => $this->bucket, |
|
313 | 14 | 'Key' => $this->applyPathPrefix($path), |
|
314 | 14 | ] + $this->options |
|
315 | ); |
||
316 | |||
317 | /* @var Result $result */ |
||
318 | try { |
||
319 | 14 | $result = $this->s3Client->execute($command); |
|
320 | 4 | } catch (S3Exception $exception) { |
|
321 | 4 | $response = $exception->getResponse(); |
|
322 | |||
323 | 4 | if ($response !== null && $response->getStatusCode() === 404) { |
|
324 | 2 | return false; |
|
325 | } |
||
326 | |||
327 | 2 | throw $exception; |
|
328 | } |
||
329 | |||
330 | 10 | return $this->normalizeResponse($result->toArray(), $path); |
|
331 | } |
||
332 | |||
333 | /** |
||
334 | * Get all the meta data of a file or directory. |
||
335 | * |
||
336 | * @param string $path |
||
337 | * |
||
338 | * @return false|array |
||
339 | */ |
||
340 | 2 | public function getSize($path) |
|
344 | |||
345 | /** |
||
346 | * Get the mimetype of a file. |
||
347 | * |
||
348 | * @param string $path |
||
349 | * |
||
350 | * @return false|array |
||
351 | */ |
||
352 | 2 | public function getMimetype($path) |
|
356 | |||
357 | /** |
||
358 | * Get the timestamp of a file. |
||
359 | * |
||
360 | * @param string $path |
||
361 | * |
||
362 | * @return false|array |
||
363 | */ |
||
364 | 2 | public function getTimestamp($path) |
|
368 | |||
369 | /** |
||
370 | * Write a new file using a stream. |
||
371 | * |
||
372 | * @param string $path |
||
373 | * @param resource $resource |
||
374 | * @param Config $config Config object |
||
375 | * |
||
376 | * @return array|false false on failure file meta data on success |
||
377 | */ |
||
378 | 4 | public function writeStream($path, $resource, Config $config) |
|
382 | |||
383 | /** |
||
384 | * Update a file using a stream. |
||
385 | * |
||
386 | * @param string $path |
||
387 | * @param resource $resource |
||
388 | * @param Config $config Config object |
||
389 | * |
||
390 | * @return array|false false on failure file meta data on success |
||
391 | */ |
||
392 | 4 | public function updateStream($path, $resource, Config $config) |
|
396 | |||
397 | /** |
||
398 | * Copy a file. |
||
399 | * |
||
400 | * @param string $path |
||
401 | * @param string $newpath |
||
402 | * |
||
403 | * @return bool |
||
404 | */ |
||
405 | 8 | public function copy($path, $newpath) |
|
406 | { |
||
407 | 8 | $command = $this->s3Client->getCommand( |
|
408 | 8 | 'copyObject', |
|
409 | [ |
||
410 | 8 | 'Bucket' => $this->bucket, |
|
411 | 8 | 'Key' => $this->applyPathPrefix($newpath), |
|
412 | 8 | 'CopySource' => rawurlencode($this->bucket . '/' . $this->applyPathPrefix($path)), |
|
413 | 8 | 'ACL' => $this->getRawVisibility($path) === AdapterInterface::VISIBILITY_PUBLIC |
|
414 | 8 | ? 'public-read' : 'private', |
|
415 | 8 | ] + $this->options |
|
416 | ); |
||
417 | |||
418 | try { |
||
419 | 8 | $this->s3Client->execute($command); |
|
420 | 4 | } catch (S3Exception $e) { |
|
421 | 4 | return false; |
|
422 | } |
||
423 | |||
424 | 4 | return true; |
|
425 | } |
||
426 | |||
427 | /** |
||
428 | * Read a file as a stream. |
||
429 | * |
||
430 | * @param string $path |
||
431 | * |
||
432 | * @return array|false |
||
433 | */ |
||
434 | 6 | public function readStream($path) |
|
435 | { |
||
436 | 6 | $response = $this->readObject($path); |
|
437 | |||
438 | 6 | if ($response !== false) { |
|
439 | 6 | $response['stream'] = $response['contents']->detach(); |
|
440 | 6 | unset($response['contents']); |
|
441 | } |
||
442 | |||
443 | 6 | return $response; |
|
444 | } |
||
445 | |||
446 | /** |
||
447 | * Read an object and normalize the response. |
||
448 | * |
||
449 | * @param $path |
||
450 | * |
||
451 | * @return array|bool |
||
452 | */ |
||
453 | 10 | protected function readObject($path) |
|
454 | { |
||
455 | $options = [ |
||
456 | 10 | 'Bucket' => $this->bucket, |
|
457 | 10 | 'Key' => $this->applyPathPrefix($path), |
|
458 | ]; |
||
459 | |||
460 | 10 | if (isset($this->options['@http'])) { |
|
461 | 2 | $options['@http'] = $this->options['@http']; |
|
462 | } |
||
463 | |||
464 | 10 | $command = $this->s3Client->getCommand('getObject', $options + $this->options); |
|
465 | |||
466 | try { |
||
467 | /** @var Result $response */ |
||
468 | 10 | $response = $this->s3Client->execute($command); |
|
469 | 2 | } catch (S3Exception $e) { |
|
470 | 2 | return false; |
|
471 | } |
||
472 | |||
473 | 8 | return $this->normalizeResponse($response->toArray(), $path); |
|
474 | } |
||
475 | |||
476 | /** |
||
477 | * Set the visibility for a file. |
||
478 | * |
||
479 | * @param string $path |
||
480 | * @param string $visibility |
||
481 | * |
||
482 | * @return array|false file meta data |
||
483 | */ |
||
484 | 6 | public function setVisibility($path, $visibility) |
|
485 | { |
||
486 | 6 | $command = $this->s3Client->getCommand( |
|
487 | 6 | 'putObjectAcl', |
|
488 | [ |
||
489 | 6 | 'Bucket' => $this->bucket, |
|
490 | 6 | 'Key' => $this->applyPathPrefix($path), |
|
491 | 6 | 'ACL' => $visibility === AdapterInterface::VISIBILITY_PUBLIC ? 'public-read' : 'private', |
|
492 | ] |
||
493 | ); |
||
494 | |||
495 | try { |
||
496 | 6 | $this->s3Client->execute($command); |
|
497 | 2 | } catch (S3Exception $exception) { |
|
498 | 2 | return false; |
|
499 | } |
||
500 | |||
501 | 4 | return compact('path', 'visibility'); |
|
502 | } |
||
503 | |||
504 | /** |
||
505 | * Get the visibility of a file. |
||
506 | * |
||
507 | * @param string $path |
||
508 | * |
||
509 | * @return array|false |
||
510 | */ |
||
511 | 4 | public function getVisibility($path) |
|
515 | |||
516 | /** |
||
517 | * {@inheritdoc} |
||
518 | */ |
||
519 | 68 | public function applyPathPrefix($path) |
|
523 | |||
524 | /** |
||
525 | * {@inheritdoc} |
||
526 | */ |
||
527 | 76 | public function setPathPrefix($prefix) |
|
533 | |||
534 | /** |
||
535 | * Get the object acl presented as a visibility. |
||
536 | * |
||
537 | * @param string $path |
||
538 | * |
||
539 | * @return string |
||
540 | */ |
||
541 | 12 | protected function getRawVisibility($path) |
|
542 | { |
||
567 | |||
568 | /** |
||
569 | * Upload an object. |
||
570 | * |
||
571 | * @param $path |
||
572 | * @param $body |
||
573 | * @param Config $config |
||
574 | * |
||
575 | * @return array|bool |
||
576 | */ |
||
577 | 14 | protected function upload($path, $body, Config $config) |
|
603 | |||
604 | /** |
||
605 | * Get options from the config. |
||
606 | * |
||
607 | * @param Config $config |
||
608 | * |
||
609 | * @return array |
||
610 | */ |
||
611 | 14 | protected function getOptionsFromConfig(Config $config) |
|
638 | |||
639 | /** |
||
640 | * Normalize the object result array. |
||
641 | * |
||
642 | * @param array $response |
||
643 | * @param string $path |
||
644 | * |
||
645 | * @return array |
||
646 | */ |
||
647 | 28 | protected function normalizeResponse(array $response, $path = null) |
|
669 | |||
670 | /** |
||
671 | * @param $location |
||
672 | * |
||
673 | * @return bool |
||
674 | */ |
||
675 | 10 | protected function doesDirectoryExist($location) |
|
700 | } |
||
701 |